diff --git a/lib/music_library_web/live/stats_live/index.ex b/lib/music_library_web/live/stats_live/index.ex index aa278420..9604e28b 100644 --- a/lib/music_library_web/live/stats_live/index.ex +++ b/lib/music_library_web/live/stats_live/index.ex @@ -227,7 +227,7 @@ defmodule MusicLibraryWeb.StatsLive.Index do |> assign_top_albums() |> assign_top_artists() |> assign( - scrobble_activity_mode: :albums, + scrobble_activity_mode: "albums", latest_record: latest_record, page_title: gettext("Stats"), current_section: :stats, @@ -274,7 +274,7 @@ defmodule MusicLibraryWeb.StatsLive.Index do {:noreply, socket |> assign_scrobble_activity(recent_tracks) - |> assign(scrobble_activity_mode: String.to_existing_atom(mode))} + |> assign(scrobble_activity_mode: mode)} end def handle_info(%{track_count: 0}, socket) do diff --git a/lib/music_library_web/live/stats_live/index.html.heex b/lib/music_library_web/live/stats_live/index.html.heex index dec58b26..79b0b506 100644 --- a/lib/music_library_web/live/stats_live/index.html.heex +++ b/lib/music_library_web/live/stats_live/index.html.heex @@ -146,401 +146,409 @@ <.refresh_lastfm_feed_button /> - <%!-- TODO: replace with OSS version --%> - - <.button - phx-click={JS.push("set_scrobble_activity_mode", value: %{"mode" => :albums})} - class={[ - "rounded-l-md rounded-r-none", - @scrobble_activity_mode == :albums && "!bg-zinc-100 dark:!bg-zinc-700" - ]} - > - {gettext("Albums")} - - <.button - phx-click={JS.push("set_scrobble_activity_mode", value: %{"mode" => :tracks})} - class={[ - "-ml-px rounded-r-md rounded-l-none", - @scrobble_activity_mode == :tracks && "!bg-zinc-100 dark:!bg-zinc-700" - ]} - > - {gettext("Tracks")} - - - - + + + +
diff --git a/test/music_library_web/live/stats_live/index_test.exs b/test/music_library_web/live/stats_live/index_test.exs index 55e8da33..b0b5a8c0 100644 --- a/test/music_library_web/live/stats_live/index_test.exs +++ b/test/music_library_web/live/stats_live/index_test.exs @@ -178,7 +178,7 @@ defmodule MusicLibraryWeb.StatsLive.IndexTest do |> assert_has("#album-#{machinarium_soundtrack_track.scrobbled_at_uts}", text: "Wishlisted" ) - |> refute_has("p", text: machinarium_soundtrack_track.title) + |> assert_has("[hidden] p", text: machinarium_soundtrack_track.title) |> assert_has("p", text: machinarium_soundtrack_track.album.title) |> assert_has("#album-#{the_last_flight_track.scrobbled_at_uts}", text: "Collected") |> assert_has("#album-#{the_mystery_of_time_track.scrobbled_at_uts}",