Replace inspect(reason) with friendly error messages

Closes #81

lib/music_library_web/components/barcode_scanner.ex

@@ -4,6 +4,7 @@ defmodule MusicLibraryWeb.Components.BarcodeScanner do
   alias MusicBrainz.ReleaseGroupSearchResult
   alias MusicLibrary.BarcodeScan
   alias MusicLibrary.Records
+  alias MusicLibraryWeb.ErrorMessages
   alias MusicLibraryWeb.RecordComponents
 
   require Logger
@@ -410,7 +411,7 @@ defmodule MusicLibraryWeb.Components.BarcodeScanner do
         errors ->
           errors_summary =
             Enum.map_join(errors, "\n", fn {number, reason} ->
-              "#{number}: #{inspect(reason)}"
+              "#{number}: #{ErrorMessages.friendly_message(reason)}"
             end)
 
           put_toast(

lib/music_library_web/components/record_form.ex

@@ -7,6 +7,7 @@ defmodule MusicLibraryWeb.Components.RecordForm do
   alias MusicLibrary.{Assets, Records}
   alias MusicLibrary.Assets.Image
   alias MusicLibrary.Records.Record
+  alias MusicLibraryWeb.ErrorMessages
 
   @impl true
   def mount(socket) do
@@ -538,14 +539,20 @@ defmodule MusicLibraryWeb.Components.RecordForm do
   def handle_async(:cover_search, {:ok, {:error, reason}}, socket) do
     {:noreply,
      socket
-     |> assign(:cover_search_error, "Search failed: #{inspect(reason)}")
+     |> assign(
+       :cover_search_error,
+       gettext("Search failed") <> ": " <> ErrorMessages.friendly_message(reason)
+     )
      |> assign(:cover_search_loading, false)}
   end
 
   def handle_async(:cover_search, {:exit, reason}, socket) do
     {:noreply,
      socket
-     |> assign(:cover_search_error, "Search failed: #{inspect(reason)}")
+     |> assign(
+       :cover_search_error,
+       gettext("Search failed") <> ": " <> ErrorMessages.friendly_message(reason)
+     )
      |> assign(:cover_search_loading, false)}
   end
 
@@ -571,14 +578,20 @@ defmodule MusicLibraryWeb.Components.RecordForm do
   def handle_async(:cover_download, {:ok, {:error, reason}}, socket) do
     {:noreply,
      socket
-     |> assign(:cover_search_error, "Download failed: #{inspect(reason)}")
+     |> assign(
+       :cover_search_error,
+       gettext("Download failed") <> ": " <> ErrorMessages.friendly_message(reason)
+     )
      |> assign(:cover_search_loading, false)}
   end
 
   def handle_async(:cover_download, {:exit, reason}, socket) do
     {:noreply,
      socket
-     |> assign(:cover_search_error, "Download failed: #{inspect(reason)}")
+     |> assign(
+       :cover_search_error,
+       gettext("Download failed") <> ": " <> ErrorMessages.friendly_message(reason)
+     )
      |> assign(:cover_search_loading, false)}
   end
 

lib/music_library_web/components/release.ex

@@ -6,6 +6,7 @@ defmodule MusicLibraryWeb.Components.Release do
   alias MusicBrainz.Release
   alias MusicLibrary.ScrobbleActivity
   alias MusicLibraryWeb.Duration
+  alias MusicLibraryWeb.ErrorMessages
   alias Phoenix.LiveView.AsyncResult
 
   def open(id), do: Fluxon.open_dialog(id)
@@ -267,7 +268,7 @@ defmodule MusicLibraryWeb.Components.Release do
 
         put_toast!(
           :error,
-          gettext("Error scrobbling release") <> "," <> inspect(reason)
+          gettext("Error scrobbling release") <> ": " <> ErrorMessages.friendly_message(reason)
         )
 
         {:noreply, socket}
@@ -298,7 +299,7 @@ defmodule MusicLibraryWeb.Components.Release do
 
         put_toast!(
           :error,
-          gettext("Error scrobbling disc") <> "," <> inspect(reason)
+          gettext("Error scrobbling disc") <> ": " <> ErrorMessages.friendly_message(reason)
         )
 
         {:noreply, socket}
@@ -372,7 +373,8 @@ defmodule MusicLibraryWeb.Components.Release do
 
           put_toast!(
             :error,
-            gettext("Error scrobbling selected tracks") <> "," <> inspect(reason)
+            gettext("Error scrobbling selected tracks") <>
+              ": " <> ErrorMessages.friendly_message(reason)
           )
 
           {:noreply, socket}