cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace inspect(reason) with friendly error messages

Browse Source 
Closes #81
This commit is contained in:
Claudio Ortolina
2026-03-05 20:25:13 +00:00
parent e8f393c5a0
commit 08f7565d44
18 changed files with 542 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/music_library_web/live/artist_live/form.ex
+17 -4
View File
@@ -6,6 +6,7 @@ defmodule MusicLibraryWeb.ArtistLive.Form do
alias MusicLibrary.Artists
alias MusicLibrary.Assets
alias MusicLibrary.Assets.Image
alias MusicLibraryWeb.ErrorMessages
@impl true
def mount(socket) do
@@ -249,14 +250,20 @@ defmodule MusicLibraryWeb.ArtistLive.Form do
def handle_async(:image_search, {:ok, {:error, reason}}, socket) do
{:noreply,
socket
|> assign(:image_search_error, "Search failed: #{inspect(reason)}")
|> assign(
:image_search_error,
gettext("Search failed") <> ": " <> ErrorMessages.friendly_message(reason)
)
|> assign(:image_search_loading, false)}
end
def handle_async(:image_search, {:exit, reason}, socket) do
{:noreply,
socket
|> assign(:image_search_error, "Search failed: #{inspect(reason)}")
|> assign(
:image_search_error,
gettext("Search failed") <> ": " <> ErrorMessages.friendly_message(reason)
)
|> assign(:image_search_loading, false)}
end
@@ -283,14 +290,20 @@ defmodule MusicLibraryWeb.ArtistLive.Form do
def handle_async(:image_download, {:ok, {:error, reason}}, socket) do
{:noreply,
socket
|> assign(:image_search_error, "Download failed: #{inspect(reason)}")
|> assign(
:image_search_error,
gettext("Download failed") <> ": " <> ErrorMessages.friendly_message(reason)
)
|> assign(:image_search_loading, false)}
end
def handle_async(:image_download, {:exit, reason}, socket) do
{:noreply,
socket
|> assign(:image_search_error, "Download failed: #{inspect(reason)}")
|> assign(
:image_search_error,
gettext("Download failed") <> ": " <> ErrorMessages.friendly_message(reason)
)
|> assign(:image_search_loading, false)}
end
lib/music_library_web/live/artist_live/show.ex
+10 -5
View File
@@ -6,6 +6,7 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
alias MusicLibrary.{Artists, Records}
alias MusicLibrary.Artists.ArtistInfo
alias MusicLibraryWeb.ErrorMessages
attr :country, :map, required: true
@@ -544,7 +545,8 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
socket
|> put_toast(
:error,
gettext("Error refreshing artist info") <> "," <> inspect(reason)
gettext("Error refreshing artist info") <>
": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -563,7 +565,8 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
socket
|> put_toast(
:error,
gettext("Error refreshing Wikipedia data") <> "," <> inspect(reason)
gettext("Error refreshing Wikipedia data") <>
": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -585,7 +588,8 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
socket
|> put_toast(
:error,
gettext("Error refreshing Last.fm data") <> "," <> inspect(reason)
gettext("Error refreshing Last.fm data") <>
": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -603,7 +607,8 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
socket
|> put_toast(
:error,
gettext("Error refreshing artist image") <> "," <> inspect(reason)
gettext("Error refreshing artist image") <>
": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -624,7 +629,7 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
socket
|> put_toast(
:error,
gettext("Error importing record") <> "," <> inspect(changeset.errors)
gettext("Error importing record") <> ": " <> ErrorMessages.friendly_message(changeset)
)}
end
end
lib/music_library_web/live/collection_live/index.ex
+3 -8
View File
@@ -9,6 +9,7 @@ defmodule MusicLibraryWeb.CollectionLive.Index do
alias MusicLibrary.Collection
alias MusicLibrary.Records
alias MusicLibraryWeb.CollectionLive.Show
alias MusicLibraryWeb.ErrorMessages
@default_records_list_params %{
query: "",
@@ -272,20 +273,14 @@ defmodule MusicLibraryWeb.CollectionLive.Index do
|> put_toast(:info, gettext("Record imported successfully"))
|> push_navigate(to: ~p"/collection/#{record.id}")}
{:error, %Ecto.Changeset{} = changeset} ->
{:error, reason} ->
{:noreply,
socket
|> put_toast(
:error,
gettext("Error importing record") <> "," <> inspect(changeset.errors)
gettext("Error importing record") <> ": " <> ErrorMessages.friendly_message(reason)
)
|> push_patch(to: ~p"/collection")}
{:error, reason} ->
{:noreply,
socket
|> put_toast(:error, gettext("Error importing record") <> "," <> inspect(reason))
|> push_patch(to: ~p"/collection")}
end
end
lib/music_library_web/live/collection_live/show.ex
+7 -5
View File
@@ -21,6 +21,7 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
alias MusicLibrary.{Records, RecordSets, ScrobbleActivity}
alias MusicLibrary.Records.Similarity
alias MusicLibraryWeb.ErrorMessages
alias Phoenix.LiveView.JS
@impl true
@@ -370,7 +371,8 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
socket
|> put_toast(
:error,
gettext("Error refreshing MusicBrainz data") <> "," <> inspect(reason)
gettext("Error refreshing MusicBrainz data") <>
": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -389,7 +391,7 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
socket
|> put_toast(
:error,
gettext("Error") <> "," <> inspect(reason)
gettext("Error") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -409,7 +411,7 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
socket
|> put_toast(
:error,
gettext("Error refreshing cover") <> "," <> inspect(reason)
gettext("Error refreshing cover") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -429,7 +431,7 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
socket
|> put_toast(
:error,
gettext("Error extracting colors") <> ": " <> inspect(reason)
gettext("Error extracting colors") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -448,7 +450,7 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
socket
|> put_toast(
:error,
gettext("Error") <> "," <> inspect(reason)
gettext("Error") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
lib/music_library_web/live/maintenance_live/index.ex
+9 -2
View File
@@ -6,6 +6,7 @@ defmodule MusicLibraryWeb.MaintenanceLive.Index do
alias MusicLibrary.Artists
alias MusicLibrary.Maintenance
alias MusicLibrary.Records
alias MusicLibraryWeb.ErrorMessages
@poll_interval 2_000
@@ -268,7 +269,10 @@ defmodule MusicLibraryWeb.MaintenanceLive.Index do
{:noreply,
socket
|> put_toast(:error, "Database vacuum failed: #{inspect(reason)}.")}
|> put_toast(
:error,
gettext("Database vacuum failed") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -284,7 +288,10 @@ defmodule MusicLibraryWeb.MaintenanceLive.Index do
{:noreply,
socket
|> put_toast(:error, "Database optimize failed: #{inspect(reason)}.")}
|> put_toast(
:error,
gettext("Database optimize failed") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
end
lib/music_library_web/live/scrobble_live/show.ex
+5 -3
View File
@@ -5,6 +5,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.Show do
import MusicLibraryWeb.RecordComponents, only: [country_label: 1]
alias MusicLibrary.ScrobbleActivity
alias MusicLibraryWeb.ErrorMessages
@impl true
def render(assigns) do
@@ -156,7 +157,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.Show do
socket
|> put_toast(
:error,
gettext("Error scrobbling release") <> "," <> inspect(reason)
gettext("Error scrobbling release") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -177,7 +178,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.Show do
socket
|> put_toast(
:error,
gettext("Error scrobbling disc") <> "," <> inspect(reason)
gettext("Error scrobbling disc") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -205,7 +206,8 @@ defmodule MusicLibraryWeb.ScrobbleLive.Show do
socket
|> put_toast(
:error,
gettext("Error scrobbling selected tracks") <> "," <> inspect(reason)
gettext("Error scrobbling selected tracks") <>
": " <> ErrorMessages.friendly_message(reason)
)}
end
end
lib/music_library_web/live/stats_live/index.ex
+3 -7
View File
@@ -9,6 +9,7 @@ defmodule MusicLibraryWeb.StatsLive.Index do
alias MusicLibrary.Assets.Transform
alias MusicLibrary.{Collection, ListeningStats, Records, Wishlist}
alias MusicLibraryWeb.ErrorMessages
alias MusicLibraryWeb.StatsLive.{TopAlbums, TopArtists}
@impl true
@@ -392,18 +393,13 @@ defmodule MusicLibraryWeb.StatsLive.Index do
|> put_toast(:info, gettext("Record wishlisted successfully"))
|> push_navigate(to: ~p"/wishlist/#{record.id}")}
{:error, %Ecto.Changeset{} = changeset} ->
{:error, reason} ->
{:noreply,
socket
|> put_toast(
:error,
gettext("Error wishlisting record") <> "," <> inspect(changeset.errors)
gettext("Error wishlisting record") <> ": " <> ErrorMessages.friendly_message(reason)
)}
{:error, reason} ->
{:noreply,
socket
|> put_toast(:error, gettext("Error wishlisting record") <> "," <> inspect(reason))}
end
end
lib/music_library_web/live/wishlist_live/index.ex
+3 -8
View File
@@ -7,6 +7,7 @@ defmodule MusicLibraryWeb.WishlistLive.Index do
alias MusicLibrary.Records
alias MusicLibrary.Wishlist
alias MusicLibraryWeb.ErrorMessages
alias MusicLibraryWeb.WishlistLive.Show
@default_records_list_params %{
@@ -242,20 +243,14 @@ defmodule MusicLibraryWeb.WishlistLive.Index do
|> put_toast(:info, gettext("Record wishlisted successfully"))
|> push_navigate(to: ~p"/wishlist/#{record.id}")}
{:error, %Ecto.Changeset{} = changeset} ->
{:error, reason} ->
{:noreply,
socket
|> put_toast(
:error,
gettext("Error wishlisting record") <> "," <> inspect(changeset.errors)
gettext("Error wishlisting record") <> ": " <> ErrorMessages.friendly_message(reason)
)
|> push_patch(to: ~p"/wishlist")}
{:error, reason} ->
{:noreply,
socket
|> put_toast(:error, gettext("Error wishlisting record") <> "," <> inspect(reason))
|> push_patch(to: ~p"/wishlist")}
end
end
lib/music_library_web/live/wishlist_live/show.ex
+6 -4
View File
@@ -19,6 +19,7 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
alias MusicLibrary.OnlineStoreTemplates
alias MusicLibrary.{Records, RecordSets}
alias MusicLibrary.Records.Similarity
alias MusicLibraryWeb.ErrorMessages
@impl true
def render(assigns) do
@@ -319,7 +320,8 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
socket
|> put_toast(
:error,
gettext("Error refreshing MusicBrainz data") <> "," <> inspect(reason)
gettext("Error refreshing MusicBrainz data") <>
": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -339,7 +341,7 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
socket
|> put_toast(
:error,
gettext("Error refreshing Cover") <> "," <> inspect(reason)
gettext("Error refreshing cover") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -358,7 +360,7 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
socket
|> put_toast(
:error,
gettext("Error") <> "," <> inspect(reason)
gettext("Error") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end
@@ -394,7 +396,7 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
socket
|> put_toast(
:error,
gettext("Error extracting colors") <> ": " <> inspect(reason)
gettext("Error extracting colors") <> ": " <> ErrorMessages.friendly_message(reason)
)}
end
end