From 1298d711a3919099d616ad2bc0589363e0a33524 Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Sun, 25 May 2025 08:56:24 +0100 Subject: [PATCH] Remove unnecessary selected_release_label/1 --- lib/music_library_web/components/record_components.ex | 8 -------- priv/gettext/default.pot | 1 - priv/gettext/en/LC_MESSAGES/default.po | 1 - test/music_library_web/live/collection_live/show_test.exs | 7 ++++--- test/music_library_web/live/wishlist_live/show_test.exs | 7 ++++--- 5 files changed, 8 insertions(+), 16 deletions(-) diff --git a/lib/music_library_web/components/record_components.ex b/lib/music_library_web/components/record_components.ex index 6460bd84..11fa7ae8 100644 --- a/lib/music_library_web/components/record_components.ex +++ b/lib/music_library_web/components/record_components.ex @@ -327,14 +327,6 @@ defmodule MusicLibraryWeb.RecordComponents do def type_label(:single), do: gettext("Single") def type_label(:other), do: gettext("Other") - def selected_release_label(record) do - if release = Records.Record.selected_release(record) do - release_label(release) - else - gettext("No release selected") - end - end - def release_label(release) do [ release.date, diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot index 4bacc14c..45e5b720 100644 --- a/priv/gettext/default.pot +++ b/priv/gettext/default.pot @@ -731,7 +731,6 @@ msgstr "" msgid "Collected release" msgstr "" -#: lib/music_library_web/components/record_components.ex #: lib/music_library_web/live/collection_live/show.html.heex #: lib/music_library_web/live/wishlist_live/show.html.heex #, elixir-autogen, elixir-format diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po index 68b78a1d..c0318f4c 100644 --- a/priv/gettext/en/LC_MESSAGES/default.po +++ b/priv/gettext/en/LC_MESSAGES/default.po @@ -731,7 +731,6 @@ msgstr "" msgid "Collected release" msgstr "" -#: lib/music_library_web/components/record_components.ex #: lib/music_library_web/live/collection_live/show.html.heex #: lib/music_library_web/live/wishlist_live/show.html.heex #, elixir-autogen, elixir-format diff --git a/test/music_library_web/live/collection_live/show_test.exs b/test/music_library_web/live/collection_live/show_test.exs index 910456bc..df510306 100644 --- a/test/music_library_web/live/collection_live/show_test.exs +++ b/test/music_library_web/live/collection_live/show_test.exs @@ -3,8 +3,7 @@ defmodule MusicLibraryWeb.CollectionLive.ShowTest do import MusicLibrary.Fixtures.Records - import MusicLibraryWeb.RecordComponents, - only: [format_label: 1, type_label: 1, selected_release_label: 1] + import MusicLibraryWeb.RecordComponents, only: [format_label: 1, type_label: 1] alias MusicBrainz.Fixtures alias MusicLibrary.Records.Record @@ -50,7 +49,9 @@ defmodule MusicLibraryWeb.CollectionLive.ShowTest do |> assert_has("dd", text: Record.format_as_date(record.purchased_at)) |> assert_has("dd", text: record.id) |> assert_has("a", text: record.musicbrainz_id) - |> assert_has("dd", text: selected_release_label(record)) + |> assert_has("span", text: "Multi") + |> assert_has("span", text: "2004-05-03") + |> assert_has("span", text: "🇬🇧") |> assert_has("dd", text: Record.format_as_date(record.inserted_at)) |> assert_has("dd", text: Record.format_as_date(record.updated_at)) |> assert_has("img[src='#{cover_url}']") diff --git a/test/music_library_web/live/wishlist_live/show_test.exs b/test/music_library_web/live/wishlist_live/show_test.exs index c345345f..7a385cbe 100644 --- a/test/music_library_web/live/wishlist_live/show_test.exs +++ b/test/music_library_web/live/wishlist_live/show_test.exs @@ -3,8 +3,7 @@ defmodule MusicLibraryWeb.WishlistLive.ShowTest do import MusicLibrary.Fixtures.Records - import MusicLibraryWeb.RecordComponents, - only: [format_label: 1, type_label: 1, selected_release_label: 1] + import MusicLibraryWeb.RecordComponents, only: [format_label: 1, type_label: 1] alias MusicLibrary.Records.Record @@ -34,7 +33,9 @@ defmodule MusicLibraryWeb.WishlistLive.ShowTest do |> assert_has("p", text: type_label(record.type)) |> assert_has("dd", text: record.id) |> assert_has("a", text: record.musicbrainz_id) - |> assert_has("dd", text: selected_release_label(record)) + |> assert_has("span", text: "Multi") + |> assert_has("span", text: "2004-05-03") + |> assert_has("span", text: "🇬🇧") |> assert_has("dd", text: Record.format_as_date(record.inserted_at)) |> assert_has("dd", text: Record.format_as_date(record.updated_at)) |> assert_has("img[src='#{cover_url}']")