Make top albums and artists async

This commit is contained in:
Claudio Ortolina
2025-07-07 10:19:47 +01:00
parent a49d8d8f07
commit 1492b197ce
2 changed files with 88 additions and 70 deletions
@@ -133,6 +133,7 @@ defmodule MusicLibraryWeb.StatsLive.Index do
timezone = socket.assigns.timezone timezone = socket.assigns.timezone
current_time = DateTime.utc_now() current_time = DateTime.utc_now()
assign_async(socket, :top_albums, fn ->
top_albums = top_albums =
ScrobbleActivity.get_top_albums_by_periods( ScrobbleActivity.get_top_albums_by_periods(
limit: 10, limit: 10,
@@ -140,13 +141,15 @@ defmodule MusicLibraryWeb.StatsLive.Index do
timezone: timezone timezone: timezone
) )
assign(socket, top_albums: top_albums) {:ok, %{top_albums: top_albums}}
end)
end end
defp assign_top_artists(socket) do defp assign_top_artists(socket) do
timezone = socket.assigns.timezone timezone = socket.assigns.timezone
current_time = DateTime.utc_now() current_time = DateTime.utc_now()
assign_async(socket, :top_artists, fn ->
top_artists = top_artists =
ScrobbleActivity.get_top_artists_by_periods( ScrobbleActivity.get_top_artists_by_periods(
limit: 10, limit: 10,
@@ -154,7 +157,8 @@ defmodule MusicLibraryWeb.StatsLive.Index do
timezone: timezone timezone: timezone
) )
assign(socket, top_artists: top_artists) {:ok, %{top_artists: top_artists}}
end)
end end
# The Tailwind build step requires all needed classes to be explicitly referenced # The Tailwind build step requires all needed classes to be explicitly referenced
@@ -74,6 +74,12 @@
<h1 class="text-base lg:text-2xl text-zinc-900 dark:text-zinc-200 font-semibold"> <h1 class="text-base lg:text-2xl text-zinc-900 dark:text-zinc-200 font-semibold">
{gettext("Top Artists")} {gettext("Top Artists")}
</h1> </h1>
<.async_result :let={top_artists} assign={@top_artists}>
<:loading>
<div class="h-192 flex items-center justify-center">
<.loading />
</div>
</:loading>
<.tabs class="mt-4"> <.tabs class="mt-4">
<.tabs_list active_tab="top_artists_last_30_days" variant="segmented"> <.tabs_list active_tab="top_artists_last_30_days" variant="segmented">
<:tab class="flex-1" name="top_artists_last_30_days">{gettext("Last 30 days")}</:tab> <:tab class="flex-1" name="top_artists_last_30_days">{gettext("Last 30 days")}</:tab>
@@ -82,23 +88,30 @@
<:tab class="flex-1" name="top_artists_all_time">{gettext("All time")}</:tab> <:tab class="flex-1" name="top_artists_all_time">{gettext("All time")}</:tab>
</.tabs_list> </.tabs_list>
<.tabs_panel active name="top_artists_last_30_days"> <.tabs_panel active name="top_artists_last_30_days">
<.top_artists_by_period artists={@top_artists.last_30_days} /> <.top_artists_by_period artists={top_artists.last_30_days} />
</.tabs_panel> </.tabs_panel>
<.tabs_panel name="top_artists_last_90_days"> <.tabs_panel name="top_artists_last_90_days">
<.top_artists_by_period artists={@top_artists.last_90_days} /> <.top_artists_by_period artists={top_artists.last_90_days} />
</.tabs_panel> </.tabs_panel>
<.tabs_panel name="top_artists_last_365_days"> <.tabs_panel name="top_artists_last_365_days">
<.top_artists_by_period artists={@top_artists.last_365_days} /> <.top_artists_by_period artists={top_artists.last_365_days} />
</.tabs_panel> </.tabs_panel>
<.tabs_panel name="top_artists_all_time"> <.tabs_panel name="top_artists_all_time">
<.top_artists_by_period artists={@top_artists.all_time} /> <.top_artists_by_period artists={top_artists.all_time} />
</.tabs_panel> </.tabs_panel>
</.tabs> </.tabs>
</.async_result>
</div> </div>
<div> <div>
<h1 class="text-base lg:text-2xl text-zinc-900 dark:text-zinc-200 font-semibold"> <h1 class="text-base lg:text-2xl text-zinc-900 dark:text-zinc-200 font-semibold">
{gettext("Top Albums")} {gettext("Top Albums")}
</h1> </h1>
<.async_result :let={top_albums} assign={@top_albums}>
<:loading>
<div class="h-192 flex items-center justify-center">
<.loading />
</div>
</:loading>
<.tabs class="mt-4"> <.tabs class="mt-4">
<.tabs_list active_tab="top_albums_last_30_days" variant="segmented"> <.tabs_list active_tab="top_albums_last_30_days" variant="segmented">
<:tab class="flex-1" name="top_albums_last_30_days">{gettext("Last 30 days")}</:tab> <:tab class="flex-1" name="top_albums_last_30_days">{gettext("Last 30 days")}</:tab>
@@ -108,33 +121,34 @@
</.tabs_list> </.tabs_list>
<.tabs_panel active name="top_albums_last_30_days"> <.tabs_panel active name="top_albums_last_30_days">
<.top_albums_by_period <.top_albums_by_period
albums={@top_albums.last_30_days} albums={top_albums.last_30_days}
collected_releases={@top_albums.collected_releases} collected_releases={top_albums.collected_releases}
wishlisted_releases={@top_albums.wishlisted_releases} wishlisted_releases={top_albums.wishlisted_releases}
/> />
</.tabs_panel> </.tabs_panel>
<.tabs_panel name="top_albums_last_90_days"> <.tabs_panel name="top_albums_last_90_days">
<.top_albums_by_period <.top_albums_by_period
albums={@top_albums.last_90_days} albums={top_albums.last_90_days}
collected_releases={@top_albums.collected_releases} collected_releases={top_albums.collected_releases}
wishlisted_releases={@top_albums.wishlisted_releases} wishlisted_releases={top_albums.wishlisted_releases}
/> />
</.tabs_panel> </.tabs_panel>
<.tabs_panel name="top_albums_last_365_days"> <.tabs_panel name="top_albums_last_365_days">
<.top_albums_by_period <.top_albums_by_period
albums={@top_albums.last_365_days} albums={top_albums.last_365_days}
collected_releases={@top_albums.collected_releases} collected_releases={top_albums.collected_releases}
wishlisted_releases={@top_albums.wishlisted_releases} wishlisted_releases={top_albums.wishlisted_releases}
/> />
</.tabs_panel> </.tabs_panel>
<.tabs_panel name="top_albums_all_time"> <.tabs_panel name="top_albums_all_time">
<.top_albums_by_period <.top_albums_by_period
albums={@top_albums.all_time} albums={top_albums.all_time}
collected_releases={@top_albums.collected_releases} collected_releases={top_albums.collected_releases}
wishlisted_releases={@top_albums.wishlisted_releases} wishlisted_releases={top_albums.wishlisted_releases}
/> />
</.tabs_panel> </.tabs_panel>
</.tabs> </.tabs>
</.async_result>
</div> </div>
</div> </div>
</div> </div>