diff --git a/test/music_brainz/release_test.exs b/test/music_brainz/release_test.exs index 896f3e6a..6d0cca81 100644 --- a/test/music_brainz/release_test.exs +++ b/test/music_brainz/release_test.exs @@ -4,7 +4,7 @@ defmodule MusicBrainz.ReleaseTest do alias MusicBrainz.{Fixtures, Release} describe "release_duration/1" do - test "it returns the total seconds" do + test "it returns the total milliseconds" do release = Fixtures.Release.release_with_media(:marbles) |> Release.from_api_response() diff --git a/test/music_library/artists_test.exs b/test/music_library/artists_test.exs index f8ad3ca3..4fe9e0a8 100644 --- a/test/music_library/artists_test.exs +++ b/test/music_library/artists_test.exs @@ -82,7 +82,7 @@ defmodule MusicLibrary.ArtistsTest do end end - describe "fetch_artist_info/1" do + describe "refresh_artist_info/1" do test "it stores musicbrainz and discogs data" do steven_wilson_musicbrainz_id = "3a51b862-0144-40f6-aa17-6aaeefea29d9" diff --git a/test/music_library/collection_test.exs b/test/music_library/collection_test.exs index b27db0fb..7599d5d0 100644 --- a/test/music_library/collection_test.exs +++ b/test/music_library/collection_test.exs @@ -44,17 +44,17 @@ defmodule MusicLibrary.CollectionTest do Collection.search_records("brave") end - test "it respects limit" do + test "respects limit" do assert [%{title: "Brave"}] = Collection.search_records("brave", limit: 1) end - test "it respects offset" do + test "respects offset" do [first_match] = Collection.search_records("brave", limit: 1) [second_match] = Collection.search_records("brave", limit: 1, offset: 1) assert first_match !== second_match end - test "it respects order" do + test "respects order" do assert [%{title: "Brave (Remastered)"}, %{title: "Brave"}] = Collection.search_records("brave", order: :purchase) diff --git a/test/music_library/listening_stats_test.exs b/test/music_library/listening_stats_test.exs index e0c8480c..707b1d30 100644 --- a/test/music_library/listening_stats_test.exs +++ b/test/music_library/listening_stats_test.exs @@ -229,7 +229,7 @@ defmodule MusicLibrary.ListeningStatsTest do end end - test "returns error when track has already been deleted" do + test "raises when track has already been deleted" do track = track_fixture() {:ok, _} = ListeningStats.delete_track(track) diff --git a/test/music_library/records/record_test.exs b/test/music_library/records/record_test.exs index 0d3763ba..6dd839dc 100644 --- a/test/music_library/records/record_test.exs +++ b/test/music_library/records/record_test.exs @@ -33,7 +33,7 @@ defmodule MusicLibrary.Records.RecordTest do assert Record.released?(record, current_date) end - test "it returns true if the release date is not precise enough", %{ + test "returns true if the release date is not precise enough", %{ current_date: current_date } do record = %Record{release_date: "2019"} diff --git a/test/music_library/records_test.exs b/test/music_library/records_test.exs index 275fe63b..4ee88537 100644 --- a/test/music_library/records_test.exs +++ b/test/music_library/records_test.exs @@ -51,7 +51,7 @@ defmodule MusicLibrary.RecordsTest do assert Enum.all?(record.dominant_colors, &color_hex?/1) end - test "it queues a task to retrieve artist info data" do + test "queues a task to retrieve artist info data" do record = record(musicbrainz_data: release_group(:lockdown_trilogy)) @@ -63,7 +63,7 @@ defmodule MusicLibrary.RecordsTest do end describe "delete_record/1" do - test "it queues a task to delete artist info data" do + test "queues a task to delete artist info data" do record = record(musicbrainz_data: release_group(:lockdown_trilogy)) @@ -184,7 +184,7 @@ defmodule MusicLibrary.RecordsTest do end describe "get_record!/1" do - test "it fetches the record by id" do + test "fetches the record by id" do # while this test may seem redundant, it implicitely checks that ALL record fields are returned, # as opposed to other code paths where we only return essential ones. expected = record() @@ -193,8 +193,8 @@ defmodule MusicLibrary.RecordsTest do end end - describe "get_artists_records/1" do - test "it returns records with essential data" do + describe "get_artist_records/1" do + test "returns records with essential data" do expected = record() artist_musicbrainz_id = expected.artists |> hd() |> Map.get(:musicbrainz_id) @@ -206,7 +206,7 @@ defmodule MusicLibrary.RecordsTest do end describe "import_from_musicbrainz_release_group/2" do - test "it saves a record with its cover art" do + test "saves a record with its cover art" do current_time = DateTime.utc_now() release_group = release_group(:marbles) @@ -259,7 +259,7 @@ defmodule MusicLibrary.RecordsTest do end describe "import_from_musicbrainz_release/2" do - test "it saves a record with its cover art" do + test "saves a record with its cover art" do current_time = DateTime.utc_now() release = release(:marbles) @@ -317,8 +317,8 @@ defmodule MusicLibrary.RecordsTest do end end - describe "refresh cover/1" do - test "it fetches and stores the updated cover" do + describe "refresh_cover/1" do + test "fetches and stores the updated cover" do record = record(cover_data: marbles_cover_data()) raven_cover_data = raven_cover_data() diff --git a/test/music_library/scrobble_rules/scrobble_rule_test.exs b/test/music_library/scrobble_rules/scrobble_rule_test.exs index 8f28e290..74999c08 100644 --- a/test/music_library/scrobble_rules/scrobble_rule_test.exs +++ b/test/music_library/scrobble_rules/scrobble_rule_test.exs @@ -111,7 +111,7 @@ defmodule MusicLibrary.ScrobbleRules.ScrobbleRuleTest do assert "is invalid" in errors_on(changeset).target_musicbrainz_id end - test "valid changeset with uppercase UUID" do + test "valid changeset with numeric UUID" do attrs = %{ type: :artist, match_value: "Pink Floyd", diff --git a/test/music_library_web/controllers/asset_controller_test.exs b/test/music_library_web/controllers/asset_controller_test.exs index 4cfebc36..eb1073b5 100644 --- a/test/music_library_web/controllers/asset_controller_test.exs +++ b/test/music_library_web/controllers/asset_controller_test.exs @@ -23,7 +23,7 @@ defmodule MusicLibraryWeb.AssetControllerTest do assert text_response(conn, 404) == "Not found" end - test "serves the asset without etag", %{conn: conn, asset: asset} do + test "serves the asset when no etag is sent", %{conn: conn, asset: asset} do transform = %Transform{hash: asset.hash} payload = Transform.encode!(transform) conn = get(conn, ~p"/assets/#{payload}") @@ -70,7 +70,7 @@ defmodule MusicLibraryWeb.AssetControllerTest do assert conn.resp_body == <<>> end - test "it handles transforms with width", %{conn: conn, asset: asset} do + test "handles transforms with width", %{conn: conn, asset: asset} do transform = %Transform{hash: asset.hash, width: 480} payload = Transform.encode!(transform)