diff --git a/.formatter.exs b/.formatter.exs index 1df4ad65..a6ad6924 100644 --- a/.formatter.exs +++ b/.formatter.exs @@ -4,6 +4,6 @@ plugins: [Phoenix.LiveView.HTMLFormatter, Quokka], inputs: ["*.{heex,ex,exs}", "{config,lib,test}/**/*.{heex,ex,exs}", "priv/*/seeds.exs"], quokka: [ - only: [:module_directives, :pipes, :single_node] + only: [:blocks, :module_directives, :pipes, :single_node] ] ] diff --git a/lib/mix/tasks/esbuild/check_version.ex b/lib/mix/tasks/esbuild/check_version.ex index 84601511..919615d7 100644 --- a/lib/mix/tasks/esbuild/check_version.ex +++ b/lib/mix/tasks/esbuild/check_version.ex @@ -15,14 +15,14 @@ defmodule Mix.Tasks.Esbuild.CheckVersion do current_version = Release.fetch_current_version() latest_version = Release.fetch_latest_version!() - if current_version !== latest_version do + if current_version === latest_version do + Mix.Shell.IO.info("The esbuild version is up to date (#{current_version})") + else Mix.Shell.IO.info( "A new esbuild version is available: #{current_version} ==> #{latest_version}" ) System.halt(1) - else - Mix.Shell.IO.info("The esbuild version is up to date (#{current_version})") end end end diff --git a/lib/mix/tasks/esbuild/update_version.ex b/lib/mix/tasks/esbuild/update_version.ex index f99dd330..a67bfa04 100644 --- a/lib/mix/tasks/esbuild/update_version.ex +++ b/lib/mix/tasks/esbuild/update_version.ex @@ -13,7 +13,9 @@ defmodule Mix.Tasks.Esbuild.UpdateVersion do current_version = Release.fetch_current_version() latest_version = Release.fetch_latest_version!() - if current_version !== latest_version do + if current_version === latest_version do + Mix.Shell.IO.info("esbuild configuration is up to date (#{current_version})") + else Mix.Shell.IO.info( "Updating esbuild configuration from #{current_version} to #{latest_version}" ) @@ -22,8 +24,6 @@ defmodule Mix.Tasks.Esbuild.UpdateVersion do Path.expand("config/config.exs", File.cwd!()) Release.update_config_file!(config_file, current_version, latest_version) - else - Mix.Shell.IO.info("esbuild configuration is up to date (#{current_version})") end end end diff --git a/lib/mix/tasks/tailwind/check_version.ex b/lib/mix/tasks/tailwind/check_version.ex index 9dce5d86..0d6cd9a7 100644 --- a/lib/mix/tasks/tailwind/check_version.ex +++ b/lib/mix/tasks/tailwind/check_version.ex @@ -15,14 +15,14 @@ defmodule Mix.Tasks.Tailwind.CheckVersion do current_version = Release.fetch_current_version() latest_version = Release.fetch_latest_version!() - if current_version !== latest_version do + if current_version === latest_version do + Mix.Shell.IO.info("The tailwind version is up to date (#{current_version})") + else Mix.Shell.IO.info( "A new tailwind version is available: #{current_version} ==> #{latest_version}" ) System.halt(1) - else - Mix.Shell.IO.info("The tailwind version is up to date (#{current_version})") end end end diff --git a/lib/mix/tasks/tailwind/update_version.ex b/lib/mix/tasks/tailwind/update_version.ex index 43551003..07cb5c09 100644 --- a/lib/mix/tasks/tailwind/update_version.ex +++ b/lib/mix/tasks/tailwind/update_version.ex @@ -13,7 +13,9 @@ defmodule Mix.Tasks.Tailwind.UpdateVersion do current_version = Release.fetch_current_version() latest_version = Release.fetch_latest_version!() - if current_version !== latest_version do + if current_version === latest_version do + Mix.Shell.IO.info("tailwind configuration is up to date (#{current_version})") + else Mix.Shell.IO.info( "Updating tailwind configuration from #{current_version} to #{latest_version}" ) @@ -22,8 +24,6 @@ defmodule Mix.Tasks.Tailwind.UpdateVersion do Path.expand("config/config.exs", File.cwd!()) Release.update_config_file!(config_file, current_version, latest_version) - else - Mix.Shell.IO.info("tailwind configuration is up to date (#{current_version})") end end end diff --git a/lib/music_library/records.ex b/lib/music_library/records.ex index 3b14b77d..9bf5ad55 100644 --- a/lib/music_library/records.ex +++ b/lib/music_library/records.ex @@ -181,8 +181,6 @@ defmodule MusicLibrary.Records do "selected_release_id" => selected_release_id }) |> create_record() - else - error -> error end end diff --git a/lib/music_library/scrobble_activity.ex b/lib/music_library/scrobble_activity.ex index a3f4d9d7..dca5b218 100644 --- a/lib/music_library/scrobble_activity.ex +++ b/lib/music_library/scrobble_activity.ex @@ -164,14 +164,12 @@ defmodule MusicLibrary.ScrobbleActivity do r.release_id == track.album.musicbrainz_id end) - record_id = if matched_release, do: matched_release.record_id, else: nil + record_id = if matched_release, do: matched_release.record_id if record_id do Enum.find_value(all_artist_pairs, fn pair -> - if pair.record_id == record_id, do: pair.artist_id, else: nil + if pair.record_id == record_id, do: pair.artist_id end) - else - nil end end diff --git a/lib/music_library_web/components/add_record_component.ex b/lib/music_library_web/components/add_record_component.ex index 875ea831..5b0752f2 100644 --- a/lib/music_library_web/components/add_record_component.ex +++ b/lib/music_library_web/components/add_record_component.ex @@ -165,15 +165,15 @@ defmodule MusicLibraryWeb.AddRecordComponent do mb_query = assigns.initial_query || "" socket = - if mb_query != "" do + if mb_query == "" do + socket + else {:ok, release_groups} = MusicBrainz.search_release_group(mb_query, limit: @batch_size, offset: 0) socket |> assign(:release_groups_count, Enum.count(release_groups)) |> stream(:release_groups, release_groups, reset: true) - else - socket end {:ok, diff --git a/lib/music_library_web/components/release_component.ex b/lib/music_library_web/components/release_component.ex index c732ed80..bc5608f7 100644 --- a/lib/music_library_web/components/release_component.ex +++ b/lib/music_library_web/components/release_component.ex @@ -184,10 +184,10 @@ defmodule MusicLibraryWeb.ReleaseComponent do end defp medium_title(medium) do - if medium.title !== "" do - medium.title - else + if medium.title === "" do gettext("Disc %{no}", %{no: medium.number}) + else + medium.title end end