From 21997d5e14725b64a523bd8de663872a7cb9151c Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Thu, 2 Oct 2025 09:00:11 +0300 Subject: [PATCH] Refactor Favicon out --- lib/music_library/artists.ex | 6 ++---- lib/music_library/favicon.ex | 6 ++++++ lib/music_library/online_store_templates.ex | 7 ++----- 3 files changed, 10 insertions(+), 9 deletions(-) create mode 100644 lib/music_library/favicon.ex diff --git a/lib/music_library/artists.ex b/lib/music_library/artists.ex index 9a8b8cd9..ffe7dc2b 100644 --- a/lib/music_library/artists.ex +++ b/lib/music_library/artists.ex @@ -3,6 +3,7 @@ defmodule MusicLibrary.Artists do alias MusicLibrary.Artists.ArtistInfo alias MusicLibrary.Assets + alias MusicLibrary.Favicon alias MusicLibrary.Records.{ArtistRecord, Record} alias MusicLibrary.Repo alias MusicLibrary.{BackgroundRepo, Worker} @@ -162,10 +163,7 @@ defmodule MusicLibrary.Artists do |> Repo.update() end - def favicon_url(external_link) do - uri = URI.parse(external_link.url) - "https://www.google.com/s2/favicons?domain=#{uri.host}&sz=16" - end + def favicon_url(external_link), do: Favicon.favicon_url(external_link.url) defp get_collected_artist_ids do q = diff --git a/lib/music_library/favicon.ex b/lib/music_library/favicon.ex new file mode 100644 index 00000000..b36b18dd --- /dev/null +++ b/lib/music_library/favicon.ex @@ -0,0 +1,6 @@ +defmodule MusicLibrary.Favicon do + def favicon_url(url) do + uri = URI.parse(url) + "https://www.google.com/s2/favicons?domain=#{uri.host}&sz=16" + end +end diff --git a/lib/music_library/online_store_templates.ex b/lib/music_library/online_store_templates.ex index 65592916..59d268da 100644 --- a/lib/music_library/online_store_templates.ex +++ b/lib/music_library/online_store_templates.ex @@ -5,7 +5,7 @@ defmodule MusicLibrary.OnlineStoreTemplates do import Ecto.Query, warn: false alias MusicLibrary.OnlineStoreTemplates.OnlineStoreTemplate - alias MusicLibrary.Repo + alias MusicLibrary.{Favicon, Repo} @doc """ Returns the list of enabled online store templates ordered by name. @@ -76,8 +76,5 @@ defmodule MusicLibrary.OnlineStoreTemplates do |> String.replace("{format}", URI.encode_www_form(format_string)) end - def favicon_url(template) do - uri = URI.parse(template.url_template) - "https://www.google.com/s2/favicons?domain=#{uri.host}&sz=16" - end + def favicon_url(template), do: Favicon.favicon_url(template.url_template) end