cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ML-182.3: partial progress in conversion

Browse Source
This commit is contained in:
Claudio Ortolina
2026-05-14 23:23:15 +01:00
parent dda700ad96
commit 2237c7db20
3 changed files with 148 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/music_library_web/live/maintenance_live/index_test.exs
+69 -52
View File
@@ -4,26 +4,26 @@ defmodule MusicLibraryWeb.MaintenanceLive.IndexTest do
import MusicLibrary.ArtistInfoFixtures
import MusicLibrary.Fixtures.Records
import Phoenix.LiveViewTest
alias MusicLibrary.Secrets
describe "Maintenance page" do
test "renders all sections and Last.fm status", %{conn: conn} do
{:ok, _view, html} = live(conn, ~p"/maintenance")
assert html =~ "Records"
assert html =~ "Artists"
assert html =~ "Database"
assert html =~ "Assets"
assert html =~ "Emails"
assert html =~ "Last.fm"
conn
|> visit(~p"/maintenance")
|> assert_has("h3", "Records")
|> assert_has("h3", "Artists")
|> assert_has("h3", "Database")
|> assert_has("h3", "Assets")
|> assert_has("h3", "Emails")
|> assert_has("h3", "Last.fm")
end
test "async status resolves to :not_connected when no session key is stored", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/maintenance")
assert render_async(view) =~ "Not connected"
conn
|> visit(~p"/maintenance")
|> unwrap(&render_async/1)
|> assert_has("span", "Not connected")
end
test "async status resolves to connected when session key is valid", %{conn: conn} do
@@ -33,9 +33,10 @@ defmodule MusicLibraryWeb.MaintenanceLive.IndexTest do
Req.Test.json(conn, %{"user" => %{"name" => "alice"}})
end)
{:ok, view, _html} = live(conn, ~p"/maintenance")
assert render_async(view) =~ "Connected as alice"
conn
|> visit(~p"/maintenance")
|> unwrap(&render_async/1)
|> assert_has("span", "Connected as alice")
end
end
@@ -45,9 +46,13 @@ defmodule MusicLibraryWeb.MaintenanceLive.IndexTest do
r1 = record()
r2 = record()
{:ok, view, _html} = live(conn, ~p"/maintenance")
render_click(view, "refresh_records_musicbrainz_data")
session =
conn
|> visit(~p"/maintenance")
|> click_button(
"button[phx-click='refresh_records_musicbrainz_data']",
"Refresh MusicBrainz data"
)
assert_enqueued(
worker: MusicLibrary.Worker.RecordRefreshMusicBrainzData,
@@ -59,23 +64,24 @@ defmodule MusicLibraryWeb.MaintenanceLive.IndexTest do
args: %{"id" => r2.id}
)
assert render(view) =~ "Operation started in the background."
assert_has(session, "p", "Operation started in the background.")
end
test "'Regenerate record embeddings' enqueues a GenerateRecordEmbedding job per record",
%{conn: conn} do
r1 = record()
{:ok, view, _html} = live(conn, ~p"/maintenance")
render_click(view, "generate_record_embeddings")
session =
conn
|> visit(~p"/maintenance")
|> click_button("Regenerate record embeddings")
assert_enqueued(
worker: MusicLibrary.Worker.GenerateRecordEmbedding,
args: %{"record_id" => r1.id}
)
assert render(view) =~ "Operation started in the background."
assert_has(session, "p", "Operation started in the background.")
end
end
@@ -85,64 +91,75 @@ defmodule MusicLibraryWeb.MaintenanceLive.IndexTest do
%{artist_info: artist_info}
end
for {event, worker} <- [
{"refresh_artists_musicbrainz_data", MusicLibrary.Worker.ArtistRefreshMusicBrainzData},
{"refresh_artists_discogs_data", MusicLibrary.Worker.ArtistRefreshDiscogsData},
{"refresh_artists_wikipedia_data", MusicLibrary.Worker.ArtistRefreshWikipediaData},
{"refresh_artists_lastfm_data", MusicLibrary.Worker.FetchArtistLastFmData}
for {event, button_text, worker} <- [
{"refresh_artists_musicbrainz_data", "Refresh MusicBrainz data",
MusicLibrary.Worker.ArtistRefreshMusicBrainzData},
{"refresh_artists_discogs_data", "Refresh Discogs data",
MusicLibrary.Worker.ArtistRefreshDiscogsData},
{"refresh_artists_wikipedia_data", "Refresh Wikipedia data",
MusicLibrary.Worker.ArtistRefreshWikipediaData},
{"refresh_artists_lastfm_data", "Refresh Last.fm data",
MusicLibrary.Worker.FetchArtistLastFmData}
] do
test "'#{event}' enqueues a #{inspect(worker)} job per artist", %{
conn: conn,
artist_info: artist_info
} do
{:ok, view, _html} = live(conn, ~p"/maintenance")
render_click(view, unquote(event))
session =
conn
|> visit(~p"/maintenance")
|> click_button(
"button[phx-click='#{unquote(event)}']",
unquote(button_text)
)
assert_enqueued(worker: unquote(worker), args: %{"id" => artist_info.id})
assert render(view) =~ "Operation started in the background."
assert_has(session, "p", "Operation started in the background.")
end
end
end
describe "database section" do
test "'Optimize' runs PRAGMA optimize and toasts success", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/maintenance")
session =
conn
|> visit(~p"/maintenance")
|> click_button("Optimize")
render_click(view, "db_optimize")
assert render(view) =~ "Database optimized successfully."
assert_has(session, "p", "Database optimized successfully.")
end
end
describe "assets section" do
test "'Prune asset cache' runs synchronously and reports the pruned count", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/maintenance")
session =
conn
|> visit(~p"/maintenance")
|> click_button("Prune asset cache")
render_click(view, "prune_asset_cache")
assert render(view) =~ "Pruned 0 cached assets."
assert_has(session, "p", "Pruned 0 cached assets.")
end
test "'Prune unreferenced assets' enqueues a PruneAssets job", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/maintenance")
render_click(view, "prune_assets")
session =
conn
|> visit(~p"/maintenance")
|> click_button("Prune unreferenced assets")
assert_enqueued(worker: MusicLibrary.Worker.PruneAssets)
assert render(view) =~ "Asset pruning started in the background."
assert_has(session, "p", "Asset pruning started in the background.")
end
end
describe "emails section" do
test "'Send records on this day' shows the :no_records toast when the collection is empty",
%{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/maintenance")
session =
conn
|> visit(~p"/maintenance")
|> click_button("Send records on this day")
render_click(view, "send_records_on_this_day_email")
assert render(view) =~ "No records on this day."
assert_has(session, "p", "No records on this day.")
end
end
@@ -151,11 +168,11 @@ defmodule MusicLibraryWeb.MaintenanceLive.IndexTest do
test "'Re-connect to Last.fm' deletes the stored session key and redirects externally",
%{conn: conn} do
{:ok, _} = Secrets.store("last_fm_session_key", "sk-xyz")
{:ok, view, _html} = live(conn, ~p"/maintenance")
assert {:error, {:redirect, %{to: url}}} = render_click(view, "reconnect_lastfm")
conn
|> visit(~p"/maintenance")
|> click_button("Re-connect to Last.fm")
assert url == LastFm.auth_url()
assert Secrets.get("last_fm_session_key") == nil
end
end
test/music_library_web/live/online_store_template_live/index_test.exs
+37 -67
View File
@@ -2,7 +2,6 @@ defmodule MusicLibraryWeb.OnlineStoreTemplateLive.IndexTest do
use MusicLibraryWeb.ConnCase
import MusicLibrary.Fixtures.OnlineStoreTemplates
import Phoenix.LiveViewTest
describe "Index" do
test "lists all templates", %{conn: conn} do
@@ -19,49 +18,28 @@ defmodule MusicLibraryWeb.OnlineStoreTemplateLive.IndexTest do
online_store_template(%{name: "Amazon UK"})
online_store_template(%{name: "Bandcamp"})
{:ok, view, _html} = live(conn, ~p"/online-store-templates")
assert has_element?(view, "p", "Amazon UK")
assert has_element?(view, "p", "Bandcamp")
view
|> form("form:not([phx-target])", query: "Amazon")
|> render_change()
assert_patch(view, ~p"/online-store-templates?page=1&page_size=50&query=Amazon")
assert has_element?(view, "p", "Amazon UK")
refute has_element?(view, "p", "Bandcamp")
conn
|> visit(~p"/online-store-templates?#{[query: "Amazon"]}")
|> assert_has("p", "Amazon UK")
|> refute_has("p", "Bandcamp")
end
end
describe "Create template" do
test "creates with valid data", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/online-store-templates/new")
view
|> form("#online_store_template-form",
online_store_template: %{
name: "New Store",
url_template: "https://store.example.com/search?q={artist}+{title}"
}
)
|> render_submit()
assert has_element?(view, "p", "New Store")
conn
|> visit(~p"/online-store-templates/new")
|> fill_in("Template Name", with: "New Store")
|> fill_in("URL Template", with: "https://store.example.com/search?q={artist}+{title}")
|> click_button("Save Template")
|> assert_has("p", "New Store")
end
test "shows validation errors", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/online-store-templates/new")
html =
view
|> form("#online_store_template-form",
online_store_template: %{name: "", url_template: ""}
)
|> render_change()
assert html =~ "can&#39;t be blank"
conn
|> visit(~p"/online-store-templates/new")
|> click_button("Save Template")
|> assert_has("[data-part='error']", "can't be blank")
end
end
@@ -69,15 +47,11 @@ defmodule MusicLibraryWeb.OnlineStoreTemplateLive.IndexTest do
test "updates with valid data", %{conn: conn} do
template = online_store_template(%{name: "Old Name"})
{:ok, view, _html} = live(conn, ~p"/online-store-templates/#{template}/edit")
view
|> form("#online_store_template-form",
online_store_template: %{name: "Updated Name"}
)
|> render_submit()
assert has_element?(view, "p", "Updated Name")
conn
|> visit(~p"/online-store-templates/#{template}/edit")
|> fill_in("Template Name", with: "Updated Name")
|> click_button("Save Template")
|> assert_has("p", "Updated Name")
end
end
@@ -85,13 +59,10 @@ defmodule MusicLibraryWeb.OnlineStoreTemplateLive.IndexTest do
test "deletes from listing", %{conn: conn} do
template = online_store_template(%{name: "To Delete"})
{:ok, view, _html} = live(conn, ~p"/online-store-templates")
view
|> element("button[phx-click='delete'][phx-value-id='#{template.id}']")
|> render_click()
refute has_element?(view, "p", "To Delete")
conn
|> visit(~p"/online-store-templates")
|> click_button("button[phx-click='delete'][phx-value-id='#{template.id}']", "Delete")
|> refute_has("p", "To Delete")
end
end
@@ -99,23 +70,22 @@ defmodule MusicLibraryWeb.OnlineStoreTemplateLive.IndexTest do
test "toggles template enabled status", %{conn: conn} do
template = online_store_template(%{name: "Toggle Me", enabled: true})
{:ok, view, _html} = live(conn, ~p"/online-store-templates")
session =
conn
|> visit(~p"/online-store-templates")
|> click_button(
"button[phx-click='toggle-enabled'][phx-value-id='#{template.id}']",
"Disable template"
)
# Toggle to disabled
html =
view
|> element("button[phx-click='toggle-enabled'][phx-value-id='#{template.id}']")
|> render_click()
assert_has(session, "button", "Enable template")
assert html =~ "Enable template"
# Toggle back to enabled
html =
view
|> element("button[phx-click='toggle-enabled'][phx-value-id='#{template.id}']")
|> render_click()
assert html =~ "Disable template"
session
|> click_button(
"button[phx-click='toggle-enabled'][phx-value-id='#{template.id}']",
"Enable template"
)
|> assert_has("button", "Disable template")
end
end
end