From 26be067750e1cf2dcccdfc64f3dbd685e74058d3 Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Mon, 28 Apr 2025 20:12:15 +0100
Subject: [PATCH] Implement failure cases in fetch artist image background job

---
 lib/music_library/worker/fetch_artist_image.ex | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/lib/music_library/worker/fetch_artist_image.ex b/lib/music_library/worker/fetch_artist_image.ex
index eab8a70b..7e7ab2d6 100644
--- a/lib/music_library/worker/fetch_artist_image.ex
+++ b/lib/music_library/worker/fetch_artist_image.ex
@@ -3,8 +3,18 @@ defmodule MusicLibrary.Worker.FetchArtistImage do
 
   @impl Oban.Worker
   def perform(%Oban.Job{args: %{"id" => artist_id}}) do
-    with {:ok, _artist_info} <- MusicLibrary.Artists.fetch_image(artist_id) do
-      :ok
+    case MusicLibrary.Artists.fetch_image(artist_id) do
+      {:ok, _artist_info} ->
+        :ok
+
+      {:error, :image_not_found} ->
+        {:cancel, :image_not_found}
+
+      {:error, :no_discogs_data} ->
+        {:cancel, :no_discogs_data}
+
+      error ->
+        error
     end
   end
 end