Regenerate embeddings only when the test representation changes

lib/music_library/records/similarity.ex

@@ -316,6 +316,21 @@ defmodule MusicLibrary.Records.Similarity do
     )
   end
 
+  @spec generate_embedding(Record.t()) :: :noop | {:ok, RecordEmbedding.t()} | {:error, term()}
+  def generate_embedding(%Record{} = record) do
+    new_text = text_representation(record)
+
+    case get_embedding_text(record.id) do
+      {:ok, ^new_text} ->
+        :noop
+
+      _ ->
+        with {:ok, embedding} <- OpenAI.embeddings(new_text) do
+          store_embedding(record.id, embedding, new_text)
+        end
+    end
+  end
+
   @spec generate_embedding_async(Record.t()) :: {:ok, Oban.Job.t()} | {:error, Ecto.Changeset.t()}
   def generate_embedding_async(record) do
     meta = %{title: record.title, artists: Enum.map(record.artists, & &1.name)}

lib/music_library/worker/generate_record_embedding.ex

@@ -8,25 +8,10 @@ defmodule MusicLibrary.Worker.GenerateRecordEmbedding do
   def perform(%Oban.Job{args: %{"record_id" => record_id}}) do
     record = Records.get_record!(record_id)
 
-    with {:ok, embedding} <- generate_embedding(record),
-         {:ok, _} <- store_embedding(record, embedding) do
-      Records.notify_update(record)
+    case Similarity.generate_embedding(record) do
+      :noop -> :ok
+      {:ok, _} -> Records.notify_update(record)
+      {:error, _} = error -> error
     end
   end
-
-  defp generate_embedding(record) do
-    text = Similarity.text_representation(record)
-
-    case OpenAI.embeddings(text) do
-      {:ok, embedding} ->
-        {:ok, {embedding, text}}
-
-      error ->
-        error
-    end
-  end
-
-  defp store_embedding(record, {embedding, text_representation}) do
-    Similarity.store_embedding(record.id, embedding, text_representation)
-  end
 end