cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary fallback to empty image version string

Browse Source 
Images always have a hash now, so fallback is not needed anymore.
This commit is contained in:
Claudio Ortolina
2024-12-23 23:30:57 +00:00
parent eabae0654f
commit 326b226d96
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/music_library_web/components/record_components.ex
+1 -1
View File
@@ -26,7 +26,7 @@ defmodule MusicLibraryWeb.RecordComponents do
<img <img
class="w-20 flex-none rounded-lg" class="w-20 flex-none rounded-lg"
alt={record.title} alt={record.title}
src={~p"/covers/#{record.id}?vsn=#{record.cover_hash || ""}"} src={~p"/covers/#{record.id}?vsn=#{record.cover_hash}"}
/> />
<div class="min-w-0 flex-auto"> <div class="min-w-0 flex-auto">
<h1 class="text-sm leading-6 text-zinc-700"> <h1 class="text-sm leading-6 text-zinc-700">
lib/music_library_web/live/artist_live/show.html.heex
+2 -2
View File
@@ -85,7 +85,7 @@
<div class="group overflow-hidden rounded-lg bg-zinc-100 focus-within:ring-2 focus-within:ring-zinc-500 focus-within:ring-offset-2 focus-within:ring-offset-zinc-100"> <div class="group overflow-hidden rounded-lg bg-zinc-100 focus-within:ring-2 focus-within:ring-zinc-500 focus-within:ring-offset-2 focus-within:ring-offset-zinc-100">
<img <img
alt={record.title} alt={record.title}
src={~p"/covers/#{record.id}?vsn=#{record.cover_hash || ""}"} src={~p"/covers/#{record.id}?vsn=#{record.cover_hash}"}
class="pointer-events-none aspect-square object-cover group-hover:opacity-75" class="pointer-events-none aspect-square object-cover group-hover:opacity-75"
/> />
<button <button
@@ -140,7 +140,7 @@
<div class="group overflow-hidden rounded-lg bg-zinc-100 focus-within:ring-2 focus-within:ring-zing-500 focus-within:ring-offset-2 focus-within:ring-offset-zinc-100"> <div class="group overflow-hidden rounded-lg bg-zinc-100 focus-within:ring-2 focus-within:ring-zing-500 focus-within:ring-offset-2 focus-within:ring-offset-zinc-100">
<img <img
alt={record.title} alt={record.title}
src={~p"/covers/#{record.id}?vsn=#{record.cover_hash || ""}"} src={~p"/covers/#{record.id}?vsn=#{record.cover_hash}"}
class="pointer-events-none aspect-square object-cover group-hover:opacity-75" class="pointer-events-none aspect-square object-cover group-hover:opacity-75"
/> />
<button <button
lib/music_library_web/live/collection_live/show.html.heex
+1 -1
View File
@@ -2,7 +2,7 @@
<div class="drop-shadow md:max-w-[38rem]"> <div class="drop-shadow md:max-w-[38rem]">
<img <img
class="w-full rounded-lg drop-shadow" class="w-full rounded-lg drop-shadow"
src={~p"/covers/#{@record.id}?vsn=#{@record.cover_hash || ""}"} src={~p"/covers/#{@record.id}?vsn=#{@record.cover_hash}"}
alt={@record.title} alt={@record.title}
/> />
</div> </div>
lib/music_library_web/live/wishlist_live/show.html.heex
+1 -1
View File
@@ -2,7 +2,7 @@
<div class="drop-shadow md:max-w-[38rem]"> <div class="drop-shadow md:max-w-[38rem]">
<img <img
class="w-full rounded-lg drop-shadow" class="w-full rounded-lg drop-shadow"
src={~p"/covers/#{@record.id}?vsn=#{@record.cover_hash || ""}"} src={~p"/covers/#{@record.id}?vsn=#{@record.cover_hash}"}
alt={@record.title} alt={@record.title}
/> />
</div> </div>