From 33dfbd607c3c46c6dd3d8ddcbb96072f3ed2cb67 Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Tue, 28 Oct 2025 08:57:02 +0000
Subject: [PATCH] Add artist information to record embeddings

---
 lib/music_library/artists.ex            |  7 +++++
 lib/music_library/records/similarity.ex | 37 ++++++++++++++++++++++++-
 2 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/lib/music_library/artists.ex b/lib/music_library/artists.ex
index 9a98accc..5a386b5c 100644
--- a/lib/music_library/artists.ex
+++ b/lib/music_library/artists.ex
@@ -110,6 +110,13 @@ defmodule MusicLibrary.Artists do
     Repo.get!(ArtistInfo, artist_id)
   end
 
+  def get_artist_infos(artist_ids) do
+    q =
+      from ai in ArtistInfo, where: ai.id in ^artist_ids
+
+    Repo.all(q)
+  end
+
   def fetch_image(artist_id) do
     artist_info = get_artist_info!(artist_id)
 
diff --git a/lib/music_library/records/similarity.ex b/lib/music_library/records/similarity.ex
index 9fee9b55..68b0c11f 100644
--- a/lib/music_library/records/similarity.ex
+++ b/lib/music_library/records/similarity.ex
@@ -6,7 +6,7 @@ defmodule MusicLibrary.Records.Similarity do
   import Ecto.Query
   import(SqliteVec.Ecto.Query)
 
-  alias MusicLibrary.Records
+  alias MusicLibrary.{Artists, Records}
   alias MusicLibrary.Records.{Record, RecordEmbedding}
   alias MusicLibrary.Repo
   alias MusicLibrary.Worker.GenerateRecordEmbedding
@@ -22,6 +22,11 @@ defmodule MusicLibrary.Records.Similarity do
   - Type (album, EP, etc.)
   """
   def text_representation(%Record{} = record) do
+    artist_infos =
+      record.artists
+      |> Enum.map(& &1.musicbrainz_id)
+      |> Artists.get_artist_infos()
+
     artist_names = Record.artist_names(record)
     genres = Enum.join(record.genres, ", ")
     year = extract_year(record.release_date)
@@ -33,10 +38,40 @@ defmodule MusicLibrary.Records.Similarity do
     Genres: #{genres}
     Released: #{year}
     Type: #{type}
+
+    #{artist_infos_summary(artist_infos)}
     """
     |> String.trim()
   end
 
+  defp artist_infos_summary([]), do: ""
+
+  defp artist_infos_summary(artist_infos) do
+    Enum.map_join(artist_infos, "\n\n", &artist_info_summary/1)
+  end
+
+  defp artist_info_summary(artist_info) when is_nil(artist_info.discogs_data), do: ""
+
+  defp artist_info_summary(%{discogs_data: discogs_data}) do
+    profile_section =
+      if profile = Map.get(discogs_data, "profile") do
+        "Profile for #{discogs_data["name"]}: #{profile}"
+      else
+        ""
+      end
+
+    members_section =
+      if members = Map.get(discogs_data, "members") do
+        members_list = Enum.map_join(members, ", ", fn member -> member["name"] end)
+
+        "Members (past and present): #{members_list}"
+      else
+        ""
+      end
+
+    Enum.join([profile_section, members_section], "\n")
+  end
+
   @doc """
   Finds similar records based on embedding similarity.