From 38f7bf70bfc6b4d626d1215512712c9a060340e3 Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Fri, 24 Jan 2025 14:28:52 +0000 Subject: [PATCH] Extract artist_changeset/2 to Artist module --- lib/music_library/records/artist.ex | 8 ++++++++ lib/music_library/records/record.ex | 7 ------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/music_library/records/artist.ex b/lib/music_library/records/artist.ex index 6fe64c9b..72910b52 100644 --- a/lib/music_library/records/artist.ex +++ b/lib/music_library/records/artist.ex @@ -1,10 +1,18 @@ defmodule MusicLibrary.Records.Artist do use Ecto.Schema + import Ecto.Changeset + @primary_key {:musicbrainz_id, :binary_id, autogenerate: false} embedded_schema do field :name, :string field :sort_name, :string field :disambiguation, :string end + + def changeset(artist, attrs) do + artist + |> cast(attrs, [:name, :sort_name, :disambiguation, :musicbrainz_id]) + |> validate_required([:name, :sort_name, :musicbrainz_id]) + end end diff --git a/lib/music_library/records/record.ex b/lib/music_library/records/record.ex index c562ba16..6591c8ff 100644 --- a/lib/music_library/records/record.ex +++ b/lib/music_library/records/record.ex @@ -71,13 +71,6 @@ defmodule MusicLibrary.Records.Record do Enum.count(record.included_release_group_ids) end - @doc false - def artist_changeset(artist, attrs) do - artist - |> cast(attrs, [:name, :sort_name, :disambiguation, :musicbrainz_id]) - |> validate_required([:name, :sort_name, :musicbrainz_id]) - end - def add_artists(record, artists_attrs) do record |> change()