From 3c8b39237c70fec957044770dc0b9a22bb4d98aa Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Fri, 24 Jan 2025 10:26:12 +0000
Subject: [PATCH] Fix return type of artist_get_info fixture

---
 test/music_library/artists_test.exs                   | 7 ++-----
 test/music_library_web/live/artist_live/show_test.exs | 7 ++-----
 test/support/fixtures/last_fm_fixtures.ex             | 4 ++++
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/test/music_library/artists_test.exs b/test/music_library/artists_test.exs
index 0e9d7d21..f8060480 100644
--- a/test/music_library/artists_test.exs
+++ b/test/music_library/artists_test.exs
@@ -2,7 +2,7 @@ defmodule MusicLibrary.ArtistsTest do
   use MusicLibrary.DataCase
 
   alias MusicLibrary.Artists
-  alias LastFm.{Artist, APIBehaviourMock}
+  alias LastFm.APIBehaviourMock
   import MusicLibrary.RecordsFixtures
   import LastFm.Fixtures
   import Mox
@@ -46,10 +46,7 @@ defmodule MusicLibrary.ArtistsTest do
       [artist] = collection_record.artists
       artist_musicbrainz_id = artist.musicbrainz_id
 
-      expected_info =
-        artist_get_info()
-        |> Map.get("artist")
-        |> Artist.from_api_response()
+      expected_info = artist_get_info()
 
       expect(APIBehaviourMock, :get_artist_info, fn {:musicbrainz_id, ^artist_musicbrainz_id},
                                                     _config ->
diff --git a/test/music_library_web/live/artist_live/show_test.exs b/test/music_library_web/live/artist_live/show_test.exs
index 175abbd7..86ca8e5c 100644
--- a/test/music_library_web/live/artist_live/show_test.exs
+++ b/test/music_library_web/live/artist_live/show_test.exs
@@ -5,7 +5,7 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
   import LastFm.Fixtures
   import Mox
 
-  alias LastFm.{Artist, APIBehaviourMock}
+  alias LastFm.APIBehaviourMock
 
   setup :verify_on_exit!
 
@@ -30,10 +30,7 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
     } do
       expect(APIBehaviourMock, :get_artist_info, fn {:musicbrainz_id, ^artist_musicbrainz_id},
                                                     _config ->
-        {:ok,
-         artist_get_info()
-         |> Map.get("artist")
-         |> Artist.from_api_response()}
+        {:ok, artist_get_info()}
       end)
 
       conn
diff --git a/test/support/fixtures/last_fm_fixtures.ex b/test/support/fixtures/last_fm_fixtures.ex
index a7532554..d1f2b61a 100644
--- a/test/support/fixtures/last_fm_fixtures.ex
+++ b/test/support/fixtures/last_fm_fixtures.ex
@@ -1,9 +1,13 @@
 defmodule LastFm.Fixtures do
   @fixtures_folder Path.join([File.cwd!(), "test/support/fixtures"])
 
+  alias LastFm.Artist
+
   def artist_get_info do
     Path.join([@fixtures_folder, "artist.getinfo.json"])
     |> File.read!()
     |> JSON.decode!()
+    |> Map.get("artist")
+    |> Artist.from_api_response()
   end
 end