Use built-in Req stub for LastFm tests

test/last_fm/config_test.exs

@@ -4,7 +4,7 @@ defmodule LastFm.ConfigTest do
   describe "resolve/1" do
     test "reads data from application configuration" do
       assert %LastFm.Config{
-               api: LastFm.APIMock,
+               api: LastFm.APIImpl,
                api_key: api_key,
                user: user,
                auto_refresh: false,

test/last_fm_test.exs

@@ -1,20 +1,20 @@
 defmodule LastFmTest do
   use ExUnit.Case, async: true
 
-  alias LastFm.APIMock
-  alias LastFm.Fixtures.Artist
-  import Mox
-
-  setup :verify_on_exit!
+  alias LastFm.{Artist, Fixtures}
 
   describe "get_artist_info/1" do
     test "it returns the artist info" do
       name = "Steven Wilson"
       musicbrainz_id = Ecto.UUID.generate()
-      expected_info = Artist.get_info()
 
-      expect(APIMock, :get_artist_info, fn {:musicbrainz_id, ^musicbrainz_id}, _config ->
-        {:ok, expected_info}
+      expected_info =
+        Fixtures.Artist.get_info()
+        |> Map.get("artist")
+        |> Artist.from_api_response()
+
+      Req.Test.stub(LastFm.API, fn conn ->
+        Req.Test.json(conn, Fixtures.Artist.get_info())
       end)
 
       assert {:ok, expected_info} == LastFm.get_artist_info(musicbrainz_id, name)

test/music_library_web/live/artist_live/show_test.exs

@@ -2,12 +2,7 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
   use MusicLibraryWeb.ConnCase
 
   import MusicLibrary.Fixtures.Records
-  import LastFm.Fixtures.Artist
-  import Mox
-
-  alias LastFm.APIMock
-
-  setup :verify_on_exit!
+  alias LastFm.Fixtures
 
   defp fill_collection(_config) do
     collection_record =
@@ -28,13 +23,14 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       conn: conn,
       artist_musicbrainz_id: artist_musicbrainz_id
     } do
-      expect(APIMock, :get_artist_info, fn {:musicbrainz_id, ^artist_musicbrainz_id}, _config ->
-        {:ok, get_info()}
-      end)
+      Req.Test.stub(LastFm.API, fn conn ->
+        case Map.get(conn.params, "method") do
+          "artist.getInfo" ->
+            Req.Test.json(conn, Fixtures.Artist.get_info())
 
-      expect(APIMock, :get_similar_artists, fn {:musicbrainz_id, ^artist_musicbrainz_id},
-                                               _config ->
-        {:ok, []}
+          "artist.getSimilar" ->
+            Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+        end
       end)
 
       conn
@@ -49,13 +45,14 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       conn: conn,
       artist_musicbrainz_id: artist_musicbrainz_id
     } do
-      expect(APIMock, :get_artist_info, fn {:musicbrainz_id, ^artist_musicbrainz_id}, _config ->
-        {:error, :timeout}
-      end)
+      Req.Test.stub(LastFm.API, fn conn ->
+        case Map.get(conn.params, "method") do
+          "artist.getInfo" ->
+            Req.Test.transport_error(conn, :timeout)
 
-      expect(APIMock, :get_similar_artists, fn {:musicbrainz_id, ^artist_musicbrainz_id},
-                                               _config ->
-        {:ok, []}
+          "artist.getSimilar" ->
+            Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+        end
       end)
 
       conn
@@ -81,14 +78,14 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       other_collection_record =
         record_with_artist("Porcupine Tree", %{purchased_at: DateTime.utc_now()})
 
-      # for this test, we don't care about the artist info, but we mock it to avoid false test failures
-      expect(APIMock, :get_artist_info, fn {:musicbrainz_id, ^artist_musicbrainz_id}, _config ->
-        {:error, :timeout}
-      end)
+      Req.Test.stub(LastFm.API, fn conn ->
+        case Map.get(conn.params, "method") do
+          "artist.getInfo" ->
+            Req.Test.json(conn, Fixtures.Artist.get_info())
 
-      expect(APIMock, :get_similar_artists, fn {:musicbrainz_id, ^artist_musicbrainz_id},
-                                               _config ->
-        {:ok, []}
+          "artist.getSimilar" ->
+            Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+        end
       end)
 
       conn

test/support/fixtures/last_fm/artist.ex

@@ -1,13 +1,13 @@
 defmodule LastFm.Fixtures.Artist do
   @fixtures_folder Path.join([File.cwd!(), "test/support/fixtures/last_fm"])
 
-  alias LastFm.Artist
-
   def get_info do
     Path.join([@fixtures_folder, "artist.getinfo.json"])
     |> File.read!()
     |> JSON.decode!()
-    |> Map.get("artist")
-    |> Artist.from_api_response()
+  end
+
+  def get_similar_artists do
+    %{"similarartists" => %{"artist" => []}}
   end
 end

test/test_helper.exs

@@ -6,13 +6,5 @@ music_brainz_config =
 
 Application.put_env(:music_library, MusicBrainz, music_brainz_config)
 
-Mox.defmock(LastFm.APIMock, for: LastFm.APIBehaviour)
-
-last_fm_config =
-  Application.get_env(:music_library, LastFm)
-  |> Keyword.put(:api, LastFm.APIMock)
-
-Application.put_env(:music_library, LastFm, last_fm_config)
-
 ExUnit.start()
 Ecto.Adapters.SQL.Sandbox.mode(MusicLibrary.Repo, :manual)