From 480af30e80f2248153a6e8ebc07b9fa182040c0b Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Fri, 20 Sep 2024 18:22:10 +0100
Subject: [PATCH] Improve records#show information structure

---
 lib/music_library_web/live/record_live/show.ex     |  4 ++++
 .../live/record_live/show.html.heex                | 14 ++++++++------
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/lib/music_library_web/live/record_live/show.ex b/lib/music_library_web/live/record_live/show.ex
index 29228d4a..0f43787e 100644
--- a/lib/music_library_web/live/record_live/show.ex
+++ b/lib/music_library_web/live/record_live/show.ex
@@ -18,4 +18,8 @@ defmodule MusicLibraryWeb.RecordLive.Show do
 
   defp page_title(:show), do: "Show Record"
   defp page_title(:edit), do: "Edit Record"
+
+  defp musicbrainz_url(record) do
+    "https://musicbrainz.org/release-group/#{record.musicbrainz_id}"
+  end
 end
diff --git a/lib/music_library_web/live/record_live/show.html.heex b/lib/music_library_web/live/record_live/show.html.heex
index 7b4287b5..5acf94aa 100644
--- a/lib/music_library_web/live/record_live/show.html.heex
+++ b/lib/music_library_web/live/record_live/show.html.heex
@@ -1,6 +1,6 @@
 <.header>
-  Record <%= @record.id %>
-  <:subtitle>This is a record record from your database.</:subtitle>
+  <%= @record.title %>
+  <:subtitle><%= Enum.map(@record.artists, fn a -> a.name end) %></:subtitle>
   <:actions>
     <.link patch={~p"/records/#{@record}/show/edit"} phx-click={JS.push_focus()}>
       <.button>Edit record</.button>
@@ -10,11 +10,13 @@
 
 <.list>
   <:item title="Type"><%= @record.type %></:item>
-  <:item title="Artists"><%= Enum.map(@record.artists, fn a -> a.name end) %></:item>
-  <:item title="Title"><%= @record.title %></:item>
-  <:item title="Musicbrainz"><%= @record.musicbrainz_id %></:item>
+  <:item title="Musicbrainz ID">
+    <a href={musicbrainz_url(@record)}>
+      <%= @record.musicbrainz_id %>
+    </a>
+  </:item>
   <:item title="Year"><%= @record.year %></:item>
-  <:item title="Genres"><%= @record.genres %></:item>
+  <:item title="Genres"><%= Enum.join(@record.genres, ", ") %></:item>
   <:item title="Image">
     <img class="max-w-32" src={~p"/images/#{@record.id}"} alt={@record.title} />
   </:item>