Simplify signatures of scrobbling functions

This commit is contained in:
Claudio Ortolina
2026-03-14 22:22:41 +00:00
parent 0a26891575
commit 4fb148e9db
4 changed files with 33 additions and 80 deletions
+8 -4
View File
@@ -289,7 +289,7 @@ defmodule MusicLibraryWeb.Components.Release do
def handle_event("scrobble_release", _params, socket) when release_loaded?(socket.assigns) do
release_with_tracks = socket.assigns.release_with_tracks.result
case ScrobbleActivity.scrobble_release(release_with_tracks, finished_at: DateTime.utc_now()) do
case ScrobbleActivity.scrobble_release(release_with_tracks, :finished_at, DateTime.utc_now()) do
{:ok, _} ->
send_update_after(socket.assigns.myself, %{already_scrobbled: false}, 3000)
put_toast!(:info, gettext("Release scrobbled successfully"))
@@ -318,8 +318,11 @@ defmodule MusicLibraryWeb.Components.Release do
release_with_tracks = socket.assigns.release_with_tracks.result
{number, ""} = Integer.parse(number)
case ScrobbleActivity.scrobble_medium(number, release_with_tracks,
finished_at: DateTime.utc_now()
case ScrobbleActivity.scrobble_medium(
number,
release_with_tracks,
:finished_at,
DateTime.utc_now()
) do
{:ok, _} ->
send_update_after(socket.assigns.myself, %{already_scrobbled: false}, 3000)
@@ -390,7 +393,8 @@ defmodule MusicLibraryWeb.Components.Release do
case ScrobbleActivity.scrobble_tracks(
selected_track_ids,
release_with_tracks,
finished_at: DateTime.utc_now()
:finished_at,
DateTime.utc_now()
) do
{:ok, _} ->
send_update_after(socket.assigns.myself, %{already_scrobbled: false}, 3000)
@@ -483,9 +483,7 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
with {:ok, release} <- MusicBrainz.get_release(record.selected_release_id) do
release_with_tracks = MusicBrainz.Release.from_api_response(release)
ScrobbleActivity.scrobble_release(release_with_tracks,
finished_at: DateTime.utc_now()
)
ScrobbleActivity.scrobble_release(release_with_tracks, :finished_at, DateTime.utc_now())
end
end)}
end
@@ -147,8 +147,10 @@ defmodule MusicLibraryWeb.ScrobbleLive.Show do
@impl true
def handle_event("scrobble_release", _params, socket) do
case ScrobbleActivity.scrobble_release(socket.assigns.release,
finished_at: DateTime.utc_now()
case ScrobbleActivity.scrobble_release(
socket.assigns.release,
:finished_at,
DateTime.utc_now()
) do
{:ok, _} ->
{:noreply,
@@ -168,8 +170,11 @@ defmodule MusicLibraryWeb.ScrobbleLive.Show do
def handle_event("scrobble_medium", %{"number" => number}, socket) do
{number, ""} = Integer.parse(number)
case ScrobbleActivity.scrobble_medium(number, socket.assigns.release,
finished_at: DateTime.utc_now()
case ScrobbleActivity.scrobble_medium(
number,
socket.assigns.release,
:finished_at,
DateTime.utc_now()
) do
{:ok, _} ->
{:noreply,
@@ -196,7 +201,8 @@ defmodule MusicLibraryWeb.ScrobbleLive.Show do
case ScrobbleActivity.scrobble_tracks(
selected_track_ids,
release_with_tracks,
finished_at: DateTime.utc_now()
:finished_at,
DateTime.utc_now()
) do
{:ok, _} ->
{:noreply,