cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor with to avoid internal assignments

Browse Source
This commit is contained in:
Claudio Ortolina
2025-02-18 12:38:29 +00:00
parent 025a5105ed
commit 50b025efca
1 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/music_library/records.ex
+9 -8
View File
@@ -129,18 +129,19 @@ defmodule MusicLibrary.Records do
end end
def import_from_musicbrainz_release_group(musicbrainz_id, opts \\ []) do def import_from_musicbrainz_release_group(musicbrainz_id, opts \\ []) do
with format = Keyword.get(opts, :format, "cd"), format = Keyword.get(opts, :format, "cd")
purchased_at = Keyword.get(opts, :purchased_at), purchased_at = Keyword.get(opts, :purchased_at)
{:ok, release_group} <- MusicBrainz.get_release_group(musicbrainz_id),
with {:ok, release_group} <- MusicBrainz.get_release_group(musicbrainz_id),
{:ok, release_group_with_releases} <- merge_releases(musicbrainz_id, release_group), {:ok, release_group_with_releases} <- merge_releases(musicbrainz_id, release_group),
{:ok, cover_data} <- get_cover_art_or_default(musicbrainz_id), {:ok, cover_data} <- get_cover_art_or_default(musicbrainz_id) do
record_attrs = release_group_with_releases
build_record_attrs(release_group_with_releases, %{ |> build_record_attrs(%{
"cover_data" => cover_data, "cover_data" => cover_data,
"format" => format, "format" => format,
"purchased_at" => purchased_at "purchased_at" => purchased_at
}) do })
create_record(record_attrs) |> create_record()
else else
error -> error error -> error
end end