From 59eb603b3f61e0c7e2a350a953fec80d41f8fb5d Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Sat, 25 Oct 2025 11:52:50 +0100
Subject: [PATCH] Return more record information in the API

---
 .../controllers/collection_json.ex            |  6 ++
 .../collection_controller_test.exs            | 62 +++++++------------
 2 files changed, 28 insertions(+), 40 deletions(-)

diff --git a/lib/music_library_web/controllers/collection_json.ex b/lib/music_library_web/controllers/collection_json.ex
index 9e1c826d..5823f6a8 100644
--- a/lib/music_library_web/controllers/collection_json.ex
+++ b/lib/music_library_web/controllers/collection_json.ex
@@ -25,6 +25,12 @@ defmodule MusicLibraryWeb.CollectionJSON do
   defp record(record) do
     %{
       id: record.id,
+      type: record.type,
+      format: record.format,
+      musicbrainz_id: record.musicbrainz_id,
+      genres: record.genres,
+      release_date: record.release_date,
+      purchased_at: record.purchased_at,
       artists: Enum.map(record.artists, & &1.name),
       title: record.title,
       cover_url: url(~p"/api/assets/#{Transform.new(hash: record.cover_hash)}"),
diff --git a/test/music_library_web/controllers/collection_controller_test.exs b/test/music_library_web/controllers/collection_controller_test.exs
index f6ba7915..25915fa6 100644
--- a/test/music_library_web/controllers/collection_controller_test.exs
+++ b/test/music_library_web/controllers/collection_controller_test.exs
@@ -27,15 +27,7 @@ defmodule MusicLibraryWeb.CollectionControllerTest do
         |> put_req_header("authorization", "Bearer #{api_token()}")
         |> get(~p"/api/collection/latest")
 
-      assert json_response(conn, 200) == %{
-               "id" => record.id,
-               "artists" => ["Steven Wilson"],
-               "title" => record.title,
-               "cover_url" =>
-                 "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
-               "thumb_url" =>
-                 "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
-             }
+      assert json_response(conn, 200) == expected_record_json(record)
     end
   end
 
@@ -55,15 +47,7 @@ defmodule MusicLibraryWeb.CollectionControllerTest do
         |> put_req_header("authorization", "Bearer #{api_token()}")
         |> get(~p"/api/collection/random")
 
-      assert json_response(conn, 200) == %{
-               "id" => record.id,
-               "artists" => ["Steven Wilson"],
-               "title" => record.title,
-               "cover_url" =>
-                 "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
-               "thumb_url" =>
-                 "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
-             }
+      assert json_response(conn, 200) == expected_record_json(record)
     end
   end
 
@@ -86,17 +70,7 @@ defmodule MusicLibraryWeb.CollectionControllerTest do
                "total" => 1,
                "limit" => 20,
                "offset" => 0,
-               "records" => [
-                 %{
-                   "id" => record.id,
-                   "artists" => ["Steven Wilson"],
-                   "title" => record.title,
-                   "cover_url" =>
-                     "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
-                   "thumb_url" =>
-                     "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
-                 }
-               ]
+               "records" => [expected_record_json(record)]
              }
     end
   end
@@ -117,18 +91,26 @@ defmodule MusicLibraryWeb.CollectionControllerTest do
         |> get(~p"/api/collection/on_this_day?date=2025-06-21")
 
       assert json_response(conn, 200) == %{
-               "records" => [
-                 %{
-                   "id" => record.id,
-                   "artists" => ["Steven Wilson"],
-                   "title" => record.title,
-                   "cover_url" =>
-                     "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
-                   "thumb_url" =>
-                     "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
-                 }
-               ]
+               "records" => [expected_record_json(record)]
              }
     end
   end
+
+  defp expected_record_json(record) do
+    %{
+      "id" => record.id,
+      "type" => record.type |> to_string(),
+      "format" => record.format |> to_string(),
+      "musicbrainz_id" => record.musicbrainz_id,
+      "genres" => record.genres,
+      "release_date" => record.release_date,
+      "purchased_at" => record.purchased_at |> DateTime.to_iso8601(),
+      "artists" => Enum.map(record.artists, & &1.name),
+      "title" => record.title,
+      "cover_url" =>
+        "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
+      "thumb_url" =>
+        "http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
+    }
+  end
 end