Avoid intermediate variables, and use consistent names
This commit is contained in:
+5
-4
@@ -7,11 +7,12 @@ defmodule Wikipedia do
|
||||
|
||||
@spec get_artist_summary(String.t()) :: {:ok, map()} | {:error, :no_english_wikipedia | term()}
|
||||
def get_artist_summary(wikidata_id) do
|
||||
config = wikipedia_config()
|
||||
wikipedia_config = wikipedia_config()
|
||||
|
||||
with {:ok, title} when not is_nil(title) <- API.get_wikipedia_title(wikidata_id, config),
|
||||
{:ok, summary} <- API.get_article_summary(title, config),
|
||||
{:ok, intro_html} <- API.get_article_extract(title, config) do
|
||||
with {:ok, title} when not is_nil(title) <-
|
||||
API.get_wikipedia_title(wikidata_id, wikipedia_config),
|
||||
{:ok, summary} <- API.get_article_summary(title, wikipedia_config),
|
||||
{:ok, intro_html} <- API.get_article_extract(title, wikipedia_config) do
|
||||
{:ok, Map.put(summary, "intro_html", intro_html)}
|
||||
else
|
||||
{:ok, nil} -> {:error, :no_english_wikipedia}
|
||||
|
||||
Reference in New Issue
Block a user