Avoid intermediate variables, and use consistent names

This commit is contained in:
Claudio Ortolina
2026-04-26 07:57:40 +01:00
parent 839277de94
commit 5b94d6bdcf
4 changed files with 15 additions and 24 deletions
+5 -4
View File
@@ -7,11 +7,12 @@ defmodule Wikipedia do
@spec get_artist_summary(String.t()) :: {:ok, map()} | {:error, :no_english_wikipedia | term()}
def get_artist_summary(wikidata_id) do
config = wikipedia_config()
wikipedia_config = wikipedia_config()
with {:ok, title} when not is_nil(title) <- API.get_wikipedia_title(wikidata_id, config),
{:ok, summary} <- API.get_article_summary(title, config),
{:ok, intro_html} <- API.get_article_extract(title, config) do
with {:ok, title} when not is_nil(title) <-
API.get_wikipedia_title(wikidata_id, wikipedia_config),
{:ok, summary} <- API.get_article_summary(title, wikipedia_config),
{:ok, intro_html} <- API.get_article_extract(title, wikipedia_config) do
{:ok, Map.put(summary, "intro_html", intro_html)}
else
{:ok, nil} -> {:error, :no_english_wikipedia}