Refactor function to remove nested error handling

2025-04-29 16:11:05 +01:00
parent f1dd45e438
commit 5e9fba824c
1 changed files with 11 additions and 19 deletions
@@ -46,19 +46,14 @@ defmodule MusicLibrary.Artists do
  end

  def fetch_artist_info(artist_id) do
-    case MusicBrainz.get_artist(artist_id) do
-      {:ok, musicbrainz_artist} ->
+    with {:ok, musicbrainz_artist} <- MusicBrainz.get_artist(artist_id) do
      if discogs_id = MusicBrainz.Artist.get_discogs_id(musicbrainz_artist) do
-          case Discogs.get_artist(discogs_id) do
-            {:ok, discogs_artist} ->
+        with {:ok, discogs_artist} <- Discogs.get_artist(discogs_id) do
          create_artist_info(%{
            id: musicbrainz_artist.id,
            musicbrainz_data: musicbrainz_artist.musicbrainz_data,
            discogs_data: discogs_artist
          })
-
-            error ->
-              error
        end
      else
        create_artist_info(%{
@@ -66,9 +61,6 @@ defmodule MusicLibrary.Artists do
          musicbrainz_data: musicbrainz_artist.musicbrainz_data
        })
      end
-
-      error ->
-        error
    end
  end