From 610e1534392529153a339859ecae16f631a6f93e Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Wed, 4 Feb 2026 10:16:57 +0000 Subject: [PATCH] Remove "Add More" functionality from artist show page I don't use it, and it takes up space that I want to have for filters --- .../live/artist_live/show.ex | 53 ------------------- .../live/artist_live/show.html.heex | 20 ------- priv/gettext/default.pot | 8 --- priv/gettext/en/LC_MESSAGES/default.po | 8 --- 4 files changed, 89 deletions(-) diff --git a/lib/music_library_web/live/artist_live/show.ex b/lib/music_library_web/live/artist_live/show.ex index 0ce9ed06..324de1a9 100644 --- a/lib/music_library_web/live/artist_live/show.ex +++ b/lib/music_library_web/live/artist_live/show.ex @@ -95,34 +95,6 @@ defmodule MusicLibraryWeb.ArtistLive.Show do end @impl true - def handle_event("import", %{"id" => musicbrainz_id, "format" => format}, socket) do - case Records.import_from_musicbrainz_release_group(musicbrainz_id, - format: format, - purchased_at: nil - ) do - {:ok, _record} -> - {:noreply, - socket - |> put_toast(:info, gettext("Record wishlisted successfully")) - |> push_patch(to: ~p"/artists/#{socket.assigns.artist.musicbrainz_id}")} - - {:error, %Ecto.Changeset{} = changeset} -> - {:noreply, - socket - |> put_toast( - :error, - gettext("Error wishlisting record") <> "," <> inspect(changeset.errors) - ) - |> push_patch(to: ~p"/artists/#{socket.assigns.artist.musicbrainz_id}")} - - {:error, reason} -> - {:noreply, - socket - |> put_toast(:error, gettext("Error wishlisting record") <> "," <> inspect(reason)) - |> push_patch(to: ~p"/artists/#{socket.assigns.artist.musicbrainz_id}")} - end - end - def handle_event("refresh_artist_info", %{"id" => id}, socket) do case Artists.fetch_artist_info(id) do {:ok, artist_info} -> @@ -221,20 +193,6 @@ defmodule MusicLibraryWeb.ArtistLive.Show do |> assign(:page_title, page_title(socket.assigns.live_action, artist)) end - defp apply_action(socket, :import, params) do - socket = - if get_in(socket.assigns, [:streams, :collection_records]) == nil do - socket - |> apply_action(:show, params) - else - socket - end - - socket - |> assign(:page_title, gettext("Add more · Artist")) - |> assign(:initial_query, "arid:#{socket.assigns.artist.musicbrainz_id}") - end - defp apply_action(socket, :edit, params) do socket = if get_in(socket.assigns, [:streams, :collection_records]) == nil do @@ -283,17 +241,6 @@ defmodule MusicLibraryWeb.ArtistLive.Show do ) end - defp page_title(:import, artist) do - Enum.join( - [ - artist.name, - "·", - gettext("Add more") - ], - " " - ) - end - defp group_and_sort(records) do {collection, wishlist} = Enum.split_with(records, fn r -> r.purchased_at end) diff --git a/lib/music_library_web/live/artist_live/show.html.heex b/lib/music_library_web/live/artist_live/show.html.heex index f05518db..67b949a3 100644 --- a/lib/music_library_web/live/artist_live/show.html.heex +++ b/lib/music_library_web/live/artist_live/show.html.heex @@ -99,10 +99,6 @@ <.on_tour_link lastfm_artist_info={lastfm_artist_info} /> <.play_count play_count={lastfm_artist_info.play_count} /> - <.button variant="solid" patch={~p"/artists/#{@artist.musicbrainz_id}/import"}> - <.icon name="hero-plus" class="icon" aria-hidden="true" data-slot="icon" /> - {gettext("Add more")} - @@ -265,22 +261,6 @@ /> - <.structured_modal - :if={@live_action == :import} - id="record-modal" - on_close={JS.patch(~p"/artists/#{@artist.musicbrainz_id}")} - > - <.live_component - module={MusicLibraryWeb.Components.AddRecord} - id={:search} - title={@page_title} - action={@live_action} - patch={~p"/artists/#{@artist.musicbrainz_id}"} - initial_query={"arid:#{@artist.musicbrainz_id}"} - icon_name="hero-plus" - /> - - <.live_component id="artist-notes" sheet_id="artist-notes-sheet" diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot index fd7bee2b..be4a7b81 100644 --- a/priv/gettext/default.pot +++ b/priv/gettext/default.pot @@ -632,25 +632,17 @@ msgstr "" msgid "Tracks" msgstr "" -#: lib/music_library_web/live/artist_live/show.ex -#: lib/music_library_web/live/artist_live/show.html.heex -#, elixir-autogen, elixir-format -msgid "Add more" -msgstr "" - #: lib/music_library_web/live/artist_live/show.ex #, elixir-autogen, elixir-format msgid "Add more · Artist" msgstr "" -#: lib/music_library_web/live/artist_live/show.ex #: lib/music_library_web/live/stats_live/index.ex #: lib/music_library_web/live/wishlist_live/index.ex #, elixir-autogen, elixir-format msgid "Error wishlisting record" msgstr "" -#: lib/music_library_web/live/artist_live/show.ex #: lib/music_library_web/live/stats_live/index.ex #: lib/music_library_web/live/wishlist_live/index.ex #, elixir-autogen, elixir-format diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po index 47b39a53..40670248 100644 --- a/priv/gettext/en/LC_MESSAGES/default.po +++ b/priv/gettext/en/LC_MESSAGES/default.po @@ -632,25 +632,17 @@ msgstr "" msgid "Tracks" msgstr "" -#: lib/music_library_web/live/artist_live/show.ex -#: lib/music_library_web/live/artist_live/show.html.heex -#, elixir-autogen, elixir-format -msgid "Add more" -msgstr "" - #: lib/music_library_web/live/artist_live/show.ex #, elixir-autogen, elixir-format msgid "Add more · Artist" msgstr "" -#: lib/music_library_web/live/artist_live/show.ex #: lib/music_library_web/live/stats_live/index.ex #: lib/music_library_web/live/wishlist_live/index.ex #, elixir-autogen, elixir-format msgid "Error wishlisting record" msgstr "" -#: lib/music_library_web/live/artist_live/show.ex #: lib/music_library_web/live/stats_live/index.ex #: lib/music_library_web/live/wishlist_live/index.ex #, elixir-autogen, elixir-format