From 61cda5a62ce8d4b36eb37f68a72aca9be66c0256 Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Tue, 3 Dec 2024 19:58:17 +0000
Subject: [PATCH] Explicitly set auto-refresh config for LastFm refresh

---
 config/config.exs      | 2 +-
 config/test.exs        | 2 +-
 lib/last_fm/config.ex  | 7 ++-----
 lib/last_fm/refresh.ex | 2 +-
 4 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/config/config.exs b/config/config.exs
index 77a18333..599d8dce 100644
--- a/config/config.exs
+++ b/config/config.exs
@@ -25,9 +25,9 @@ config :music_library, MusicLibraryWeb.Endpoint,
   live_view: [signing_salt: "g/qw4SNo"]
 
 config :music_library, LastFm,
-  # to avoid runtime errors, set the user to a valid Last.fm username
   user: "username",
   api: LastFm.APIImpl,
+  auto_refresh: true,
   refresh_interval: System.convert_time_unit(60, :second, :millisecond),
   api_key: "change me"
 
diff --git a/config/test.exs b/config/test.exs
index dbe8902d..bb516f27 100644
--- a/config/test.exs
+++ b/config/test.exs
@@ -30,4 +30,4 @@ config :phoenix_live_view,
 
 config :music_library, dev_routes: true
 
-config :music_library, LastFm, api: nil
+config :music_library, LastFm, auto_refresh: false
diff --git a/lib/last_fm/config.ex b/lib/last_fm/config.ex
index df1949c7..21675219 100644
--- a/lib/last_fm/config.ex
+++ b/lib/last_fm/config.ex
@@ -3,19 +3,16 @@ defmodule LastFm.Config do
           api: module(),
           api_key: String.t(),
           user: String.t(),
+          auto_refresh: boolean(),
           refresh_interval: pos_integer()
         }
 
   defstruct api: LastFm.Api,
             api_key: "",
             user: "",
+            auto_refresh: true,
             refresh_interval: 60_000
 
-  @spec enabled?(t) :: boolean()
-  def enabled?(config) do
-    config.api && config.user !== "" && config.api_key !== ""
-  end
-
   @spec resolve(atom) :: t
   def resolve(otp_app) do
     app_config =
diff --git a/lib/last_fm/refresh.ex b/lib/last_fm/refresh.ex
index 27af83cb..ab87f74d 100644
--- a/lib/last_fm/refresh.ex
+++ b/lib/last_fm/refresh.ex
@@ -20,7 +20,7 @@ defmodule LastFm.Refresh do
   @impl true
   @spec init(config) :: {:ok, config, {:continue, :refresh}} | :ignore
   def init(config) do
-    if Config.enabled?(config) do
+    if config.auto_refresh do
       {:ok, config, {:continue, :refresh}}
     else
       :ignore