cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Open universal search modal instantly via client-side JS

Browse Source 
Replace phx-click server event with Fluxon.open_dialog for zero-latency
modal opening. The modal DOM is now always present (no :if conditional) so
it can be shown instantly; the server syncs state in the background.

Fix test selectors that now match the always-present modal form by scoping
to forms without phx-target (which the modal form always has).
This commit is contained in:
Claudio Ortolina
2026-05-07 20:43:15 +01:00
parent fa7a01b489
commit 621b35d824
6 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/music_library_web/live/scrobble_live/index_test.exs
+4 -4
View File
@@ -40,7 +40,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.IndexTest do
test "renders search page with form", %{conn: conn} do
conn
|> visit(~p"/scrobble")
|> assert_has("form[phx-submit='search']")
|> assert_has("form[phx-submit='search']:not([phx-target])")
end
test "shows connect Last.fm button when not authenticated", %{conn: conn} do
@@ -67,7 +67,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.IndexTest do
session
|> unwrap(fn view ->
view
|> form("form[phx-submit='search']", %{query: "marbles"})
|> form("form[phx-submit='search']:not([phx-target])", %{query: "marbles"})
|> render_submit()
render(view)
@@ -82,7 +82,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.IndexTest do
session
|> unwrap(fn view ->
view
|> form("form[phx-submit='search']", %{query: ""})
|> form("form[phx-submit='search']:not([phx-target])", %{query: ""})
|> render_submit()
end)
|> refute_has("h3", "Release Groups")
@@ -108,7 +108,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.IndexTest do
session
|> unwrap(fn view ->
view
|> form("form[phx-submit='search']", %{query: "nonexistent"})
|> form("form[phx-submit='search']:not([phx-target])", %{query: "nonexistent"})
|> render_submit()
render(view)