From 69e6cc67a272d40b0e507e4f2331d177dd9f4997 Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Tue, 15 Oct 2024 17:32:59 +0100 Subject: [PATCH] Make page titles consistent with application structure - All existing pages get a nice title - Suffix is "Music Library" - Fallback is current request path --- lib/music_library_web/components/layouts/root.html.heex | 4 ++-- lib/music_library_web/controllers/stats_controller.ex | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/music_library_web/components/layouts/root.html.heex b/lib/music_library_web/components/layouts/root.html.heex index ed46e393..2c793489 100644 --- a/lib/music_library_web/components/layouts/root.html.heex +++ b/lib/music_library_web/components/layouts/root.html.heex @@ -4,8 +4,8 @@ - <.live_title suffix=" · Phoenix Framework"> - <%= assigns[:page_title] || "MusicLibrary" %> + <.live_title suffix=" · Music Library"> + <%= assigns[:page_title] || assigns.conn.request_path %> diff --git a/lib/music_library_web/controllers/stats_controller.ex b/lib/music_library_web/controllers/stats_controller.ex index 4bf02f7e..7ba18286 100644 --- a/lib/music_library_web/controllers/stats_controller.ex +++ b/lib/music_library_web/controllers/stats_controller.ex @@ -15,7 +15,9 @@ defmodule MusicLibraryWeb.StatsController do records_count = Enum.reduce(records_count_by_format, 0, fn {_, count}, acc -> acc + count end) latest_record = Records.get_latest_record!() - render(conn, :index, + conn + |> assign(:page_title, "Stats") + |> render(:index, records_count_by_format: records_count_by_format, records_count_by_type: records_count_by_type, records_count: records_count,