From 71f7a38feede6b2a86406f20be03e0261aa96791 Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Wed, 26 Nov 2025 18:50:35 +0000
Subject: [PATCH] Don't use streams for records on this day

---
 .../components/stats_components.ex            |  7 +++---
 .../live/stats_live/index.ex                  |  7 +++---
 .../live/stats_live/index.html.heex           |  2 +-
 .../live/stats_live/index_test.exs            | 24 +++++--------------
 4 files changed, 13 insertions(+), 27 deletions(-)

diff --git a/lib/music_library_web/components/stats_components.ex b/lib/music_library_web/components/stats_components.ex
index cc7f67e8..a362ee1c 100644
--- a/lib/music_library_web/components/stats_components.ex
+++ b/lib/music_library_web/components/stats_components.ex
@@ -150,8 +150,7 @@ defmodule MusicLibraryWeb.StatsComponents do
     <ul
       class="mt-5 p-4"
       role="list"
-      id="records"
-      phx-update="stream"
+      id="records-on-this-day"
     >
       <li
         id="no-records-on-this-day"
@@ -160,10 +159,10 @@ defmodule MusicLibraryWeb.StatsComponents do
         {gettext("No records released on this day.")}
       </li>
       <li
-        :for={{id, record} <- @records}
+        :for={record <- @records}
         phx-click={JS.navigate(@record_show_path.(record))}
         class="flex justify-between gap-x-6 py-2 hover:bg-zinc-50 dark:hover:bg-zinc-800 px-2 -mx-2 md:px-4 md:-mx-4 cursor-pointer"
-        id={id}
+        id={record.id}
       >
         <div class="flex min-w-0 gap-x-4 items-center">
           <div class="relative w-12 flex-none">
diff --git a/lib/music_library_web/live/stats_live/index.ex b/lib/music_library_web/live/stats_live/index.ex
index bda0e47d..2dfe395b 100644
--- a/lib/music_library_web/live/stats_live/index.ex
+++ b/lib/music_library_web/live/stats_live/index.ex
@@ -30,7 +30,6 @@ defmodule MusicLibraryWeb.StatsLive.Index do
      |> stream_configure(:recent_albums,
        dom_id: fn %{album: album} -> "album-#{album.scrobbled_at_uts}" end
      )
-     |> stream(:records_on_this_day, records_on_this_day, reset: true)
      |> assign_counts()
      |> assign_scrobble_activity()
      |> assign(
@@ -40,7 +39,8 @@ defmodule MusicLibraryWeb.StatsLive.Index do
        page_title: gettext("Stats"),
        current_section: :stats,
        records_by_artist: records_by_artists,
-       records_by_genre: records_by_genre
+       records_by_genre: records_by_genre,
+       records_on_this_day: records_on_this_day
      )}
   end
 
@@ -89,8 +89,7 @@ defmodule MusicLibraryWeb.StatsLive.Index do
 
         {:noreply,
          socket
-         |> assign(:current_date, date)
-         |> stream(:records_on_this_day, records_on_this_day, reset: true)}
+         |> assign(%{current_date: date, records_on_this_day: records_on_this_day})}
 
       {:error, _reason} ->
         {:noreply, socket}
diff --git a/lib/music_library_web/live/stats_live/index.html.heex b/lib/music_library_web/live/stats_live/index.html.heex
index f280c621..0ff69232 100644
--- a/lib/music_library_web/live/stats_live/index.html.heex
+++ b/lib/music_library_web/live/stats_live/index.html.heex
@@ -510,7 +510,7 @@
       <div class="bg-white dark:bg-zinc-800 rounded-md shadow-sm">
         <.records_on_this_day
           current_date={@current_date}
-          records={@streams.records_on_this_day}
+          records={@records_on_this_day}
           record_show_path={fn record -> ~p"/collection/#{record}" end}
         />
       </div>
diff --git a/test/music_library_web/live/stats_live/index_test.exs b/test/music_library_web/live/stats_live/index_test.exs
index 2327d6dc..ddfceddd 100644
--- a/test/music_library_web/live/stats_live/index_test.exs
+++ b/test/music_library_web/live/stats_live/index_test.exs
@@ -269,13 +269,9 @@ defmodule MusicLibraryWeb.StatsLive.IndexTest do
 
       assert_has(session, "h1", text: "On This day")
 
-      assert_has(session, "#records_on_this_day-#{record_today.id} h2",
-        text: escape(record_today.title)
-      )
+      assert_has(session, "##{record_today.id} h2", text: escape(record_today.title))
 
-      refute_has(session, "#records_on_this_day-#{record_yesterday.id} h2",
-        text: escape(record_yesterday.title)
-      )
+      refute_has(session, "##{record_yesterday.id} h2", text: escape(record_yesterday.title))
     end
 
     test "it updates the 'On This Day' records when the date is changed", %{
@@ -303,13 +299,9 @@ defmodule MusicLibraryWeb.StatsLive.IndexTest do
 
       session = conn |> visit("/")
 
-      assert_has(session, "#records_on_this_day-#{record_today.id} h2",
-        text: escape(record_today.title)
-      )
+      assert_has(session, "##{record_today.id} h2", text: escape(record_today.title))
 
-      refute_has(session, "#records_on_this_day-#{record_yesterday.id} h2",
-        text: escape(record_yesterday.title)
-      )
+      refute_has(session, "##{record_yesterday.id} h2", text: escape(record_yesterday.title))
 
       session
       |> unwrap(fn view ->
@@ -318,13 +310,9 @@ defmodule MusicLibraryWeb.StatsLive.IndexTest do
         |> render_change()
       end)
 
-      refute_has(session, "#records_on_this_day-#{record_today.id} h2",
-        text: escape(record_today.title)
-      )
+      refute_has(session, "##{record_today.id} h2", text: escape(record_today.title))
 
-      assert_has(session, "#records_on_this_day-#{record_yesterday.id} h2",
-        text: escape(record_yesterday.title)
-      )
+      assert_has(session, "##{record_yesterday.id} h2", text: escape(record_yesterday.title))
     end
   end
 end