From 750dae431bd60af6ee805a8c9e166569b66a0cbe Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Fri, 25 Oct 2024 23:20:13 +0100
Subject: [PATCH] Redesign import dialog

---
 .../components/core_components.ex             |  2 +-
 .../live/record_live/import_component.ex      | 32 +++++++++++--------
 priv/gettext/default.pot                      |  8 ++---
 .../live/record_index_test.exs                |  2 +-
 4 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/lib/music_library_web/components/core_components.ex b/lib/music_library_web/components/core_components.ex
index ac5c3c55..7c67f050 100644
--- a/lib/music_library_web/components/core_components.ex
+++ b/lib/music_library_web/components/core_components.ex
@@ -74,7 +74,7 @@ defmodule MusicLibraryWeb.CoreComponents do
                 "shadow-zinc-700/10 ring-zinc-700/10",
                 "relative hidden rounded-2xl",
                 "bg-white dark:bg-zinc-800",
-                "p-14 shadow-lg ring-1 transition"
+                "p-8 shadow-lg ring-1 transition"
               ]}
             >
               <div class="absolute top-6 right-5">
diff --git a/lib/music_library_web/live/record_live/import_component.ex b/lib/music_library_web/live/record_live/import_component.ex
index 5c348486..cf501010 100644
--- a/lib/music_library_web/live/record_live/import_component.ex
+++ b/lib/music_library_web/live/record_live/import_component.ex
@@ -13,6 +13,7 @@ defmodule MusicLibraryWeb.RecordLive.ImportComponent do
         phx-target={@myself}
         phx-change="search"
         phx-submit="search"
+        class="px-4"
       >
         <.input
           id={:mb_query}
@@ -24,7 +25,11 @@ defmodule MusicLibraryWeb.RecordLive.ImportComponent do
           phx-debounce="500"
         />
       </.simple_form>
-      <ul :if={@release_groups !== []} role="list" class="divide-y divide-gray-100">
+      <ul
+        :if={@release_groups !== []}
+        role="list"
+        class="divide-y divide-gray-100 dark:divide-slate-300/30 mt-5"
+      >
         <.result :for={release_group <- @release_groups} release_group={release_group} />
       </ul>
       <div
@@ -41,23 +46,22 @@ defmodule MusicLibraryWeb.RecordLive.ImportComponent do
     ~H"""
     <li
       id={"musicbrainz_" <> @release_group.id}
-      class="flex justify-between gap-x-6 py-5 hover:bg-gray-50"
+      class="flex justify-between gap-x-6 py-5 hover:bg-gray-50 dark:hover:bg-zinc-700"
     >
-      <div class="flex min-w-0 gap-x-4">
+      <div class="shrink-0 flex items-center justify-between w-full px-4">
         <div class="min-w-0 flex-auto">
-          <p class="text-sm font-semibold leading-6 text-gray-900">
-            <.type_badge type={@release_group.type} />
+          <h1 class="text-sm leading-6 text-zinc-700 dark:text-zinc-400">
+            <%= @release_group.artists %>
+          </h1>
+          <h2 class="mt-1 flex font-semibold text-sm sm:text-base leading-5 text-zinc-700 dark:text-zinc-300 text-wrap">
             <%= @release_group.title %>
-
-            <span class="mt-1 text-xs leading-5 text-gray-500">
-              <%= @release_group.release %>
-            </span>
+          </h2>
+          <p class="mt-1 text-xs leading-5 text-zinc-500 dark:text-zinc-400">
+            <%= Records.Record.format_release(@release_group.release) %> · <%= Records.Record.type_long_label(
+              @release_group.type
+            ) %>
           </p>
-          <p class="mt-1 truncate text-xs leading-5 text-gray-500"><%= @release_group.artists %></p>
         </div>
-      </div>
-
-      <div class="shrink-0 flex items-center">
         <div class="relative flex-none">
           <button
             type="button"
@@ -103,7 +107,7 @@ defmodule MusicLibraryWeb.RecordLive.ImportComponent do
               class="block px-3 py-1 text-sm leading-6 text-gray-900 dark:text-zinc-400 hover:bg-gray-50 dark:hover:text-zinc-300 dark:hover:bg-zinc-700"
               role="menuitem"
               tabindex="-1"
-              id={"actions-#{format}-import"}
+              id={"actions-#{@release_group.id}-#{format}-import"}
               phx-click={
                 JS.push("import", value: %{id: @release_group.id, format: format}, page_loading: true)
               }
diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot
index 68e14241..e5955801 100644
--- a/priv/gettext/default.pot
+++ b/priv/gettext/default.pot
@@ -158,17 +158,17 @@ msgstr ""
 msgid "Type"
 msgstr ""
 
-#: lib/music_library_web/live/record_live/import_component.ex:34
+#: lib/music_library_web/live/record_live/import_component.ex:39
 #, elixir-autogen, elixir-format
 msgid "No results"
 msgstr ""
 
-#: lib/music_library_web/live/record_live/import_component.ex:22
+#: lib/music_library_web/live/record_live/import_component.ex:23
 #, elixir-autogen, elixir-format
 msgid "Search for a record on MusicBrainz"
 msgstr ""
 
-#: lib/music_library_web/live/record_live/import_component.ex:23
+#: lib/music_library_web/live/record_live/import_component.ex:24
 #, elixir-autogen, elixir-format
 msgid "Search for records"
 msgstr ""
@@ -219,7 +219,7 @@ msgstr ""
 msgid "Import from MusicBrainz"
 msgstr ""
 
-#: lib/music_library_web/live/record_live/import_component.ex:70
+#: lib/music_library_web/live/record_live/import_component.ex:74
 #: lib/music_library_web/live/record_live/index.html.heex:99
 #: lib/music_library_web/live/wishlist_live/index.html.heex:99
 #, elixir-autogen, elixir-format
diff --git a/test/music_library_web/live/record_index_test.exs b/test/music_library_web/live/record_index_test.exs
index fa5bc678..b110bf7a 100644
--- a/test/music_library_web/live/record_index_test.exs
+++ b/test/music_library_web/live/record_index_test.exs
@@ -282,7 +282,7 @@ defmodule MusicLibraryWeb.RecordIndexTest do
 
       for result <- mock_results do
         assert updated_list =~ result.title
-        assert updated_list =~ result.release
+        assert updated_list =~ Record.format_release(result.release)
         assert updated_list =~ result.artists
       end