Update embeddings when populating genres

lib/music_library/records/similarity.ex

@@ -121,7 +121,7 @@ defmodule MusicLibrary.Records.Similarity do
 
     params
     |> GenerateRecordEmbedding.new(meta: meta)
-    |> Oban.insert!()
+    |> Oban.insert()
   end
 
   def generate_all_embeddings_async do

lib/music_library/worker/generate_record_embedding.ex

@@ -1,8 +1,6 @@
 defmodule MusicLibrary.Worker.GenerateRecordEmbedding do
   use Oban.Worker, queue: :heavy_writes, max_attempts: 3
 
-  require Logger
-
   alias MusicLibrary.Records
   alias MusicLibrary.Records.Similarity
 
@@ -12,12 +10,7 @@ defmodule MusicLibrary.Worker.GenerateRecordEmbedding do
 
     with {:ok, embedding} <- generate_embedding(record),
          {:ok, _} <- store_embedding(record, embedding) do
-      Logger.info("Generated embedding for record #{record_id}")
+      Records.notify_update(record)
-      :ok
-    else
-      {:error, reason} = error ->
-        Logger.error("Failed to generate embedding for record #{record_id}: #{inspect(reason)}")
-        error
     end
   end
 
@@ -28,8 +21,8 @@ defmodule MusicLibrary.Worker.GenerateRecordEmbedding do
       {:ok, embedding} ->
         {:ok, {embedding, text}}
 
-      {:error, reason} ->
+      error ->
-        {:error, reason}
+        error
     end
   end
 

lib/music_library/worker/populate_genres.ex

@@ -1,12 +1,16 @@
 defmodule MusicLibrary.Worker.PopulateGenres do
   use Oban.Worker, queue: :heavy_writes, max_attempts: 10
 
+  alias MusicLibrary.Records
+
   @impl Oban.Worker
   def perform(%Oban.Job{args: %{"id" => record_id}}) do
-    record = MusicLibrary.Records.get_record!(record_id)
+    record = Records.get_record!(record_id)
 
-    with {:ok, updated_record} <- MusicLibrary.Records.populate_genres(record) do
+    with {:ok, updated_record} <- Records.populate_genres(record),
-      MusicLibrary.Records.notify_update(updated_record)
+         {:ok, _worker} <-
+           Records.Similarity.generate_embedding_async(updated_record) do
+      Records.notify_update(updated_record)
     end
   end
 end

lib/music_library_web/live/collection_live/show.ex

@@ -35,7 +35,6 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
   def handle_params(%{"id" => id}, _, socket) do
     record = Records.get_record!(id)
     last_listened_track = Records.get_last_listened_track(record)
-    similar_records = Similarity.find_similar(id, limit: 6, scope: :collection)
 
     socket =
       if record.selected_release_id do
@@ -49,7 +48,7 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
      |> assign(:page_title, page_title(socket.assigns.live_action, record))
      |> assign(:record, record)
      |> assign(:last_listened_track, last_listened_track)
-     |> assign(:similar_records, similar_records)}
+     |> assign_similar_records()}
   end
 
   @impl true
@@ -141,7 +140,10 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
 
   @impl true
   def handle_info({MusicLibraryWeb.Components.RecordForm, {:saved, record}}, socket) do
-    {:noreply, assign(socket, :record, record)}
+    {:noreply,
+     socket
+     |> assign(:record, record)
+     |> assign_similar_records()}
   end
 
   @impl true
@@ -149,7 +151,8 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
     {:noreply,
      socket
      |> put_toast(:info, gettext("Record updated in the background"))
-     |> assign(:record, record)}
+     |> assign(:record, record)
+     |> assign_similar_records()}
   end
 
   def page_title(:show, record) do
@@ -184,4 +187,11 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
 
   defp title_segment(:show), do: gettext("Show")
   defp title_segment(:edit), do: gettext("Edit")
+
+  defp assign_similar_records(socket) do
+    similar_records =
+      Similarity.find_similar(socket.assigns.record.id, limit: 6, scope: :collection)
+
+    assign(socket, :similar_records, similar_records)
+  end
 end

lib/music_library_web/live/wishlist_live/show.ex

@@ -34,14 +34,13 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
   def handle_params(%{"id" => id}, _, socket) do
     record = Records.get_record!(id)
     online_store_templates = OnlineStoreTemplates.list_enabled_templates()
-    similar_records = Similarity.find_similar(id, limit: 6, scope: :wishlist)
 
     {:noreply,
      socket
      |> assign(:page_title, page_title(socket.assigns.live_action, record))
      |> assign(:record, record)
      |> assign(:online_store_templates, online_store_templates)
-     |> assign(:similar_records, similar_records)}
+     |> assign_similar_records()}
   end
 
   @impl true
@@ -149,7 +148,10 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
 
   @impl true
   def handle_info({MusicLibraryWeb.Components.RecordForm, {:saved, record}}, socket) do
-    {:noreply, assign(socket, :record, record)}
+    {:noreply,
+     socket
+     |> assign(:record, record)
+     |> assign_similar_records()}
   end
 
   @impl true
@@ -157,7 +159,8 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
     {:noreply,
      socket
      |> put_toast(:info, gettext("Record updated in the background"))
-     |> assign(:record, record)}
+     |> assign(:record, record)
+     |> assign_similar_records()}
   end
 
   def page_title(action, record) do
@@ -177,4 +180,11 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
 
   defp title_segment(:show), do: gettext("Show")
   defp title_segment(:edit), do: gettext("Edit")
+
+  defp assign_similar_records(socket) do
+    similar_records =
+      Similarity.find_similar(socket.assigns.record.id, limit: 6, scope: :wishlist)
+
+    assign(socket, :similar_records, similar_records)
+  end
 end