cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't scrobble releases with zero duration

Browse Source
This commit is contained in:
Claudio Ortolina
2025-10-23 10:27:08 +01:00
parent fe243892f1
commit 7b697827fd
4 changed files with 848 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/music_library/scrobble_activity.ex
+6
View File
@@ -32,6 +32,11 @@ defmodule MusicLibrary.ScrobbleActivity do
end
def scrobble_release(release_with_tracks, {:started_at, started_at}) do
release_duration = Release.release_duration(release_with_tracks)
if release_duration == 0 do
{:error, :no_duration}
else
session_key = Secrets.get!("last_fm_session_key").value
{scrobbles, _finished_at} =
@@ -41,6 +46,7 @@ defmodule MusicLibrary.ScrobbleActivity do
LastFm.scrobble(scrobbles, session_key)
end
end
def scrobble_medium(number, release_with_tracks, opts) when is_list(opts) do
case Enum.sort(opts) do
test/music_brainz/release_test.exs
+24
View File
@@ -0,0 +1,24 @@
defmodule MusicBrainz.ReleaseTest do
use ExUnit.Case, async: true
alias MusicBrainz.{Fixtures, Release}
describe "release_duration/1" do
test "it returns the total seconds" do
release =
Fixtures.Release.release_with_media(:marbles)
|> Release.from_api_response()
assert Release.release_duration(release) == 5_933_595
end
test "it handles empty durations" do
release =
Fixtures.Release.release_with_media(:marbles)
|> put_in(["media", Access.all(), "tracks", Access.all(), "length"], nil)
|> Release.from_api_response()
assert Release.release_duration(release) == 0
end
end
end
test/support/fixtures/music_brainz/release.ex
+6
View File
@@ -25,6 +25,12 @@ defmodule MusicBrainz.Fixtures.Release do
|> JSON.decode!()
end
def release_with_media(:marbles) do
Path.join([@fixtures_folder, "release_with_media - marillion - marbles.json"])
|> File.read!()
|> JSON.decode!()
end
def release_id(name) do
release(name) |> Map.get("id")
end
test/support/fixtures/music_brainz/release_with_media - marillion - marbles.json
+806
View File
@@ -0,0 +1,806 @@
{
"label-info": [
{
"catalog-number": "12772",
"label": {
"id": "983e8198-6c5a-4353-8ac1-3d41a9336481",
"type-id": "7aaa37fe-2def-3476-b359-80245850062d",
"sort-name": "Intact Records",
"type": "Original Production",
"name": "Intact Records",
"disambiguation": "",
"label-code": 13355
}
},
{
"label": {
"sort-name": "Intact Records",
"type": "Original Production",
"id": "983e8198-6c5a-4353-8ac1-3d41a9336481",
"type-id": "7aaa37fe-2def-3476-b359-80245850062d",
"disambiguation": "",
"label-code": 13355,
"name": "Intact Records"
},
"catalog-number": "260404-2"
}
],
"title": "Marbles",
"date": "2004-05-03",
"release-group": {
"disambiguation": "",
"primary-type-id": "f529b476-6e62-324f-b0aa-1f3e33d313fc",
"title": "Marbles",
"primary-type": "Album",
"secondary-types": [],
"id": "20790e26-98e4-3ad3-a67f-b674758b942d",
"artist-credit": [
{
"joinphrase": "",
"artist": {
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"sort-name": "Marillion",
"type": "Group",
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band"
},
"name": "Marillion"
}
],
"first-release-date": "2004-05-03",
"secondary-type-ids": []
},
"country": "XE",
"media": [
{
"id": "eca09756-5cf2-3f73-bc42-749f811be0d7",
"format": "CD",
"track-offset": 0,
"format-id": "9712d52a-4509-3d4b-a1a2-67c88c643e31",
"track-count": 7,
"title": "",
"tracks": [
{
"recording": {
"disambiguation": "",
"title": "The Invisible Man",
"first-release-date": "2004-05-03",
"video": false,
"length": 817613,
"artist-credit": [
{
"joinphrase": "",
"artist": {
"disambiguation": "British progressive rock band",
"name": "Marillion",
"country": "GB",
"type": "Group",
"sort-name": "Marillion",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44"
},
"name": "Marillion"
}
],
"id": "03c612c6-5a13-455f-ab2f-0fe40906250a"
},
"length": 817613,
"number": "1",
"artist-credit": [
{
"artist": {
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"sort-name": "Marillion",
"type": "Group",
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band"
},
"joinphrase": "",
"name": "Marillion"
}
],
"position": 1,
"title": "The Invisible Man",
"id": "ea424146-3f1f-4651-b873-50e678a0fc7a"
},
{
"id": "76e900f8-0156-4306-b490-1945ae96d240",
"length": 102746,
"number": "2",
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"sort-name": "Marillion",
"type": "Group"
}
}
],
"recording": {
"id": "40a23122-cd24-466c-be01-187f6f3c9acf",
"disambiguation": "",
"title": "Marbles I",
"first-release-date": "2004-05-03",
"video": false,
"length": 102746,
"artist-credit": [
{
"joinphrase": "",
"artist": {
"sort-name": "Marillion",
"type": "Group",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"disambiguation": "British progressive rock band",
"country": "GB",
"name": "Marillion"
},
"name": "Marillion"
}
]
},
"title": "Marbles I",
"position": 2
},
{
"position": 3,
"title": "Genie",
"recording": {
"disambiguation": "",
"title": "Genie",
"first-release-date": "2004-05-03",
"video": false,
"length": 294293,
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"disambiguation": "British progressive rock band",
"name": "Marillion",
"country": "GB",
"type": "Group",
"sort-name": "Marillion",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b"
}
}
],
"id": "f633fea4-8f29-4fda-a15f-86627f9048da"
},
"length": 294293,
"artist-credit": [
{
"joinphrase": "",
"artist": {
"disambiguation": "British progressive rock band",
"country": "GB",
"name": "Marillion",
"type": "Group",
"sort-name": "Marillion",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b"
},
"name": "Marillion"
}
],
"number": "3",
"id": "86187f02-6779-4ded-b84e-9d21d8abb8ca"
},
{
"recording": {
"disambiguation": "",
"title": "Fantastic Place",
"length": 372520,
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"sort-name": "Marillion",
"type": "Group",
"country": "GB",
"name": "Marillion",
"disambiguation": "British progressive rock band"
}
}
],
"first-release-date": "2004-05-03",
"video": false,
"id": "f703b00d-0216-4e08-88cd-875c183d1e3c"
},
"number": "4",
"artist-credit": [
{
"artist": {
"disambiguation": "British progressive rock band",
"country": "GB",
"name": "Marillion",
"type": "Group",
"sort-name": "Marillion",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44"
},
"joinphrase": "",
"name": "Marillion"
}
],
"length": 372520,
"position": 4,
"title": "Fantastic Place",
"id": "71c3f5aa-54c2-4af4-a7b8-e269879a8ba5"
},
{
"id": "0ecee1da-d20e-4d9e-9899-d5c1c15b0588",
"title": "The Only Unforgivable Thing",
"position": 5,
"artist-credit": [
{
"joinphrase": "",
"artist": {
"sort-name": "Marillion",
"type": "Group",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"disambiguation": "British progressive rock band",
"name": "Marillion",
"country": "GB"
},
"name": "Marillion"
}
],
"number": "5",
"length": 433293,
"recording": {
"id": "af263b9a-d21c-4210-b61e-bff2be7c3424",
"video": false,
"first-release-date": "2004-05-03",
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"sort-name": "Marillion",
"type": "Group",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"disambiguation": "British progressive rock band",
"name": "Marillion",
"country": "GB"
}
}
],
"length": 433293,
"title": "The Only Unforgivable Thing",
"disambiguation": ""
}
},
{
"title": "Marbles II",
"position": 6,
"length": 122880,
"artist-credit": [
{
"name": "Marillion",
"artist": {
"disambiguation": "British progressive rock band",
"country": "GB",
"name": "Marillion",
"type": "Group",
"sort-name": "Marillion",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b"
},
"joinphrase": ""
}
],
"number": "6",
"recording": {
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"sort-name": "Marillion",
"type": "Group"
}
}
],
"length": 122880,
"video": false,
"first-release-date": "2004-05-03",
"title": "Marbles II",
"disambiguation": "",
"id": "0b20b4eb-60ac-4c19-b4ba-8ac2ace07136"
},
"id": "b71db64f-4eee-4f44-a478-2d20e52b6adf"
},
{
"recording": {
"length": 1078253,
"artist-credit": [
{
"joinphrase": "",
"artist": {
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"sort-name": "Marillion",
"type": "Group"
},
"name": "Marillion"
}
],
"first-release-date": "2004-05-03",
"video": false,
"disambiguation": "",
"title": "Ocean Cloud",
"id": "08864ce2-20fd-49d4-8ef4-d916cec4f5c9"
},
"artist-credit": [
{
"joinphrase": "",
"artist": {
"country": "GB",
"name": "Marillion",
"disambiguation": "British progressive rock band",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"type": "Group",
"sort-name": "Marillion"
},
"name": "Marillion"
}
],
"number": "7",
"length": 1078253,
"position": 7,
"title": "Ocean Cloud",
"id": "0d3a4853-22f9-46c9-a8ee-354e62c6db87"
}
],
"position": 1
},
{
"format-id": "9712d52a-4509-3d4b-a1a2-67c88c643e31",
"format": "CD",
"id": "4f272f8d-0178-38f0-9f9a-8cff2480df1c",
"track-offset": 0,
"track-count": 8,
"position": 2,
"tracks": [
{
"recording": {
"id": "d576eda2-5f8c-4f8b-b741-c1ccc5aa1216",
"title": "Marbles III",
"disambiguation": "",
"artist-credit": [
{
"artist": {
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"sort-name": "Marillion",
"type": "Group"
},
"joinphrase": "",
"name": "Marillion"
}
],
"length": 111866,
"video": false,
"first-release-date": "2004-05-03"
},
"artist-credit": [
{
"name": "Marillion",
"artist": {
"sort-name": "Marillion",
"type": "Group",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"disambiguation": "British progressive rock band",
"name": "Marillion",
"country": "GB"
},
"joinphrase": ""
}
],
"number": "1",
"length": 111866,
"position": 1,
"title": "Marbles III",
"id": "683cae13-1de9-43f5-bb80-d72a50ffd539"
},
{
"id": "435ce489-3766-4b0c-be24-7a9506fc9e90",
"position": 2,
"title": "The Damage",
"recording": {
"first-release-date": "2004-04-19",
"video": false,
"length": 275186,
"artist-credit": [
{
"artist": {
"sort-name": "Marillion",
"type": "Group",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"disambiguation": "British progressive rock band",
"country": "GB",
"name": "Marillion"
},
"joinphrase": "",
"name": "Marillion"
}
],
"disambiguation": "",
"title": "The Damage",
"id": "24e40cd4-1be3-4a41-a78f-8290a4a4b983"
},
"length": 275186,
"number": "2",
"artist-credit": [
{
"artist": {
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type": "Group",
"sort-name": "Marillion",
"country": "GB",
"name": "Marillion",
"disambiguation": "British progressive rock band"
},
"joinphrase": "",
"name": "Marillion"
}
]
},
{
"id": "5548e295-5db5-4894-aa75-985255820362",
"position": 3,
"title": "Don’t Hurt Yourself",
"recording": {
"disambiguation": "",
"title": "Don’t Hurt Yourself",
"first-release-date": "2004-05-03",
"video": false,
"length": 348746,
"artist-credit": [
{
"artist": {
"country": "GB",
"name": "Marillion",
"disambiguation": "British progressive rock band",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type": "Group",
"sort-name": "Marillion"
},
"joinphrase": "",
"name": "Marillion"
}
],
"id": "c9ada0dc-548f-4f06-86e2-ac4a4c55b1c6"
},
"artist-credit": [
{
"name": "Marillion",
"artist": {
"sort-name": "Marillion",
"type": "Group",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"disambiguation": "British progressive rock band",
"name": "Marillion",
"country": "GB"
},
"joinphrase": ""
}
],
"number": "3",
"length": 348746
},
{
"recording": {
"disambiguation": "",
"title": "You’re Gone",
"length": 385720,
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"disambiguation": "British progressive rock band",
"name": "Marillion",
"country": "GB",
"sort-name": "Marillion",
"type": "Group",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b"
}
}
],
"first-release-date": "2004-04-19",
"video": false,
"id": "9eac6df4-b14d-492c-b142-3aa081d842a9"
},
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"sort-name": "Marillion",
"type": "Group"
}
}
],
"number": "4",
"length": 385720,
"position": 4,
"title": "You’re Gone",
"id": "dd0f6929-cc08-416a-982d-454e34809aaf"
},
{
"id": "df6bd598-8333-4e3a-870a-63893dd87c01",
"recording": {
"id": "d718635b-8fd3-4d94-9fe3-68465737fed5",
"first-release-date": "2004-05-03",
"video": false,
"length": 462613,
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"sort-name": "Marillion",
"type": "Group"
}
}
],
"disambiguation": "",
"title": "Angelina"
},
"length": 462613,
"number": "5",
"artist-credit": [
{
"joinphrase": "",
"artist": {
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"sort-name": "Marillion",
"type": "Group"
},
"name": "Marillion"
}
],
"position": 5,
"title": "Angelina"
},
{
"position": 6,
"title": "Drilling Holes",
"recording": {
"disambiguation": "",
"title": "Drilling Holes",
"length": 311666,
"artist-credit": [
{
"joinphrase": "",
"artist": {
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"sort-name": "Marillion",
"type": "Group"
},
"name": "Marillion"
}
],
"first-release-date": "2004-05-03",
"video": false,
"id": "969d518d-5528-46c6-ac2b-ac2de5e78ba1"
},
"length": 311666,
"number": "6",
"artist-credit": [
{
"name": "Marillion",
"artist": {
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"type": "Group",
"sort-name": "Marillion",
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band"
},
"joinphrase": ""
}
],
"id": "d17e2d73-1365-4473-bf6a-b3250115f8ef"
},
{
"id": "acafcabd-c91a-4aa3-80fa-4f2c4b64a962",
"recording": {
"id": "5f5c3acf-5701-4ddf-b1c8-173608cdbb7b",
"disambiguation": "",
"title": "Marbles IV",
"length": 86146,
"artist-credit": [
{
"name": "Marillion",
"artist": {
"country": "GB",
"name": "Marillion",
"disambiguation": "British progressive rock band",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"sort-name": "Marillion",
"type": "Group"
},
"joinphrase": ""
}
],
"first-release-date": "2004-05-03",
"video": false
},
"artist-credit": [
{
"name": "Marillion",
"joinphrase": "",
"artist": {
"country": "GB",
"name": "Marillion",
"disambiguation": "British progressive rock band",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"sort-name": "Marillion",
"type": "Group"
}
}
],
"number": "7",
"length": 86146,
"position": 7,
"title": "Marbles IV"
},
{
"id": "635021dd-a956-4830-af47-c7b9a5540deb",
"artist-credit": [
{
"name": "Marillion",
"artist": {
"disambiguation": "British progressive rock band",
"name": "Marillion",
"country": "GB",
"type": "Group",
"sort-name": "Marillion",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44"
},
"joinphrase": ""
}
],
"number": "8",
"length": 730054,
"recording": {
"title": "Neverland",
"disambiguation": "",
"artist-credit": [
{
"joinphrase": "",
"artist": {
"country": "GB",
"name": "Marillion",
"disambiguation": "British progressive rock band",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"type": "Group",
"sort-name": "Marillion"
},
"name": "Marillion"
}
],
"length": 730054,
"video": false,
"first-release-date": "2004-05-03",
"id": "18b32261-ef00-46a1-a573-7c910cd68fb9"
},
"title": "Neverland",
"position": 8
}
],
"title": ""
}
],
"cover-art-archive": {
"back": false,
"front": false,
"count": 0,
"artwork": false,
"darkened": false
},
"artist-credit": [
{
"name": "Marillion",
"artist": {
"type-id": "e431f5f6-b5d2-343d-8b36-72607fffb74b",
"id": "1932f5b6-0b7b-4050-b1df-833ca89e5f44",
"sort-name": "Marillion",
"type": "Group",
"name": "Marillion",
"country": "GB",
"disambiguation": "British progressive rock band"
},
"joinphrase": ""
}
],
"packaging-id": "ec27701a-4a22-37f4-bfac-6616e0f9750a",
"quality": "normal",
"status-id": "4e304316-386d-3409-af2e-78857eec5cfe",
"barcode": "",
"id": "0e290154-5375-4f4f-a658-4a92bf02faa5",
"disambiguation": "non‐deluxe double CD with o‐card",
"packaging": "Jewel Case",
"text-representation": {
"script": "Latn",
"language": "eng"
},
"release-events": [
{
"area": {
"id": "89a675c2-3e37-3518-b83c-418bad59a85a",
"type-id": null,
"sort-name": "Europe",
"type": null,
"iso-3166-1-codes": [
"XE"
],
"name": "Europe",
"disambiguation": ""
},
"date": "2004-05-03"
}
],
"asin": null,
"status": "Official"
}