Improve test coverage
Files Created (8 files, 54 new tests) Fixtures 1. test/support/fixtures/music_library/record_sets.ex — record_set/1 and record_set_with_records/2 helpers 2. test/support/fixtures/music_library/online_store_templates.ex — online_store_template/1 helper Context Tests 3. test/music_library/record_sets_test.exs — 20 tests covering search, count, CRUD, add/remove/move records 4. test/music_library/online_store_templates_test.exs — 8 tests covering list, CRUD, URL generation, validation 5. test/music_library/search_test.exs — 5 tests covering universal search and search counts 6. test/music_library/notes_test.exs — 4 tests covering get, create, update LiveView Tests 7. test/music_library_web/live/record_set_live/index_test.exs — 11 tests covering listing, empty state, search, ordering, create/edit/delete sets, remove records, reorder records 8. test/music_library_web/live/online_store_template_live/index_test.exs — 6 tests covering listing, create/edit/delete, toggle enabled Results - 297 tests, 0 failures (up from 243 — 54 new tests added) - All existing tests continue to pass There's a remaining gettext warning that needs to be investigated
This commit is contained in:
Claudio Ortolina
@@ -0,0 +1,108 @@
|
||||
defmodule MusicLibraryWeb.OnlineStoreTemplateLive.IndexTest do
|
||||
use MusicLibraryWeb.ConnCase
|
||||
|
||||
import MusicLibrary.Fixtures.OnlineStoreTemplates
|
||||
import Phoenix.LiveViewTest
|
||||
|
||||
alias MusicLibrary.OnlineStoreTemplates
|
||||
|
||||
describe "Index" do
|
||||
test "lists all templates", %{conn: conn} do
|
||||
online_store_template(%{name: "Amazon UK"})
|
||||
online_store_template(%{name: "Bandcamp"})
|
||||
|
||||
conn
|
||||
|> visit(~p"/online-store-templates")
|
||||
|> assert_has("h1", text: "Online Store Templates")
|
||||
|> assert_has("p", text: "Amazon UK")
|
||||
|> assert_has("p", text: "Bandcamp")
|
||||
end
|
||||
end
|
||||
|
||||
describe "Create template" do
|
||||
test "creates with valid data", %{conn: conn} do
|
||||
{:ok, view, _html} = live(conn, ~p"/online-store-templates/new")
|
||||
|
||||
view
|
||||
|> form("#online_store_template-form",
|
||||
online_store_template: %{
|
||||
name: "New Store",
|
||||
url_template: "https://store.example.com/search?q={artist}+{title}"
|
||||
}
|
||||
)
|
||||
|> render_submit()
|
||||
|
||||
templates = OnlineStoreTemplates.list_templates()
|
||||
assert Enum.any?(templates, &(&1.name == "New Store"))
|
||||
end
|
||||
|
||||
test "shows validation errors", %{conn: conn} do
|
||||
{:ok, view, _html} = live(conn, ~p"/online-store-templates/new")
|
||||
|
||||
html =
|
||||
view
|
||||
|> form("#online_store_template-form",
|
||||
online_store_template: %{name: "", url_template: ""}
|
||||
)
|
||||
|> render_change()
|
||||
|
||||
assert html =~ "can't be blank"
|
||||
end
|
||||
end
|
||||
|
||||
describe "Edit template" do
|
||||
test "updates with valid data", %{conn: conn} do
|
||||
template = online_store_template(%{name: "Old Name"})
|
||||
|
||||
{:ok, view, _html} = live(conn, ~p"/online-store-templates/#{template}/edit")
|
||||
|
||||
view
|
||||
|> form("#online_store_template-form",
|
||||
online_store_template: %{name: "Updated Name"}
|
||||
)
|
||||
|> render_submit()
|
||||
|
||||
updated = OnlineStoreTemplates.get_template!(template.id)
|
||||
assert updated.name == "Updated Name"
|
||||
end
|
||||
end
|
||||
|
||||
describe "Delete template" do
|
||||
test "deletes from listing", %{conn: conn} do
|
||||
template = online_store_template(%{name: "To Delete"})
|
||||
|
||||
{:ok, view, _html} = live(conn, ~p"/online-store-templates")
|
||||
|
||||
view
|
||||
|> element("button[phx-click='delete'][phx-value-id='#{template.id}']")
|
||||
|> render_click()
|
||||
|
||||
refute has_element?(view, "p", "To Delete")
|
||||
assert_raise Ecto.NoResultsError, fn -> OnlineStoreTemplates.get_template!(template.id) end
|
||||
end
|
||||
end
|
||||
|
||||
describe "Toggle enabled" do
|
||||
test "toggles template enabled status", %{conn: conn} do
|
||||
template = online_store_template(%{name: "Toggle Me", enabled: true})
|
||||
|
||||
{:ok, view, _html} = live(conn, ~p"/online-store-templates")
|
||||
|
||||
# Toggle to disabled
|
||||
view
|
||||
|> element("button[phx-click='toggle-enabled'][phx-value-id='#{template.id}']")
|
||||
|> render_click()
|
||||
|
||||
updated = OnlineStoreTemplates.get_template!(template.id)
|
||||
refute updated.enabled
|
||||
|
||||
# Toggle back to enabled
|
||||
view
|
||||
|> element("button[phx-click='toggle-enabled'][phx-value-id='#{template.id}']")
|
||||
|> render_click()
|
||||
|
||||
updated = OnlineStoreTemplates.get_template!(template.id)
|
||||
assert updated.enabled
|
||||
end
|
||||
end
|
||||
end
|
||||
@@ -0,0 +1,158 @@
|
||||
defmodule MusicLibraryWeb.RecordSetLive.IndexTest do
|
||||
use MusicLibraryWeb.ConnCase
|
||||
|
||||
import MusicLibrary.Fixtures.RecordSets
|
||||
import Phoenix.LiveViewTest
|
||||
|
||||
alias MusicLibrary.RecordSets
|
||||
|
||||
describe "Index" do
|
||||
test "lists record sets with names and record counts", %{conn: conn} do
|
||||
{_set, _records} = record_set_with_records(2, %{name: "My Favorites"})
|
||||
|
||||
conn
|
||||
|> visit(~p"/record-sets")
|
||||
|> assert_has("h1", text: "Record Sets")
|
||||
|> assert_has("h2", text: "My Favorites")
|
||||
end
|
||||
|
||||
test "shows empty state when no sets exist", %{conn: conn} do
|
||||
conn
|
||||
|> visit(~p"/record-sets")
|
||||
|> assert_has("p", text: "No record sets yet")
|
||||
end
|
||||
end
|
||||
|
||||
describe "Search" do
|
||||
test "filters sets by query", %{conn: conn} do
|
||||
record_set(%{name: "Road Trip"})
|
||||
record_set(%{name: "Unrelated Set"})
|
||||
|
||||
conn
|
||||
|> visit(~p"/record-sets?query=Road")
|
||||
|> assert_has("h2", text: "Road Trip")
|
||||
|> refute_has("h2", text: "Unrelated Set")
|
||||
end
|
||||
end
|
||||
|
||||
describe "Ordering" do
|
||||
test "switches to alphabetical via URL param", %{conn: conn} do
|
||||
record_set(%{name: "Zulu Set"})
|
||||
record_set(%{name: "Alpha Set"})
|
||||
|
||||
{:ok, _view, html} = live(conn, ~p"/record-sets?order=alphabetical")
|
||||
|
||||
alpha_pos = :binary.match(html, "Alpha Set")
|
||||
zulu_pos = :binary.match(html, "Zulu Set")
|
||||
|
||||
assert alpha_pos < zulu_pos
|
||||
end
|
||||
end
|
||||
|
||||
describe "Create set" do
|
||||
test "creates a set with valid data", %{conn: conn} do
|
||||
{:ok, view, _html} = live(conn, ~p"/record-sets/new")
|
||||
|
||||
view
|
||||
|> form("#record-set-form", record_set: %{name: "Brand New Set"})
|
||||
|> render_submit()
|
||||
|
||||
assert [set] = RecordSets.search_record_sets("Brand New Set")
|
||||
assert set.name == "Brand New Set"
|
||||
end
|
||||
|
||||
test "shows validation errors with invalid data", %{conn: conn} do
|
||||
{:ok, view, _html} = live(conn, ~p"/record-sets/new")
|
||||
|
||||
html =
|
||||
view
|
||||
|> form("#record-set-form", record_set: %{name: ""})
|
||||
|> render_change()
|
||||
|
||||
assert html =~ "can't be blank"
|
||||
end
|
||||
end
|
||||
|
||||
describe "Edit set" do
|
||||
test "updates set with valid data", %{conn: conn} do
|
||||
set = record_set(%{name: "Old Name"})
|
||||
|
||||
{:ok, view, _html} = live(conn, ~p"/record-sets/#{set}/edit")
|
||||
|
||||
view
|
||||
|> form("#record-set-form", record_set: %{name: "Updated Name"})
|
||||
|> render_submit()
|
||||
|
||||
updated = RecordSets.get_record_set!(set.id)
|
||||
assert updated.name == "Updated Name"
|
||||
end
|
||||
end
|
||||
|
||||
describe "Delete set" do
|
||||
test "deletes a set from the listing", %{conn: conn} do
|
||||
set = record_set(%{name: "To Delete"})
|
||||
|
||||
{:ok, view, _html} = live(conn, ~p"/record-sets")
|
||||
|
||||
view
|
||||
|> element("button[phx-click='delete_set'][phx-value-id='#{set.id}']")
|
||||
|> render_click()
|
||||
|
||||
refute has_element?(view, "h2", "To Delete")
|
||||
assert_raise Ecto.NoResultsError, fn -> RecordSets.get_record_set!(set.id) end
|
||||
end
|
||||
end
|
||||
|
||||
describe "Remove record from set" do
|
||||
test "removes a record from the set", %{conn: conn} do
|
||||
{set, [r1 | _]} = record_set_with_records(2)
|
||||
|
||||
{:ok, view, _html} = live(conn, ~p"/record-sets")
|
||||
|
||||
view
|
||||
|> element(
|
||||
"button[phx-click='remove_record'][phx-value-set-id='#{set.id}'][phx-value-record-id='#{r1.id}']"
|
||||
)
|
||||
|> render_click()
|
||||
|
||||
updated = RecordSets.get_record_set!(set.id)
|
||||
refute Enum.any?(updated.items, &(&1.record.id == r1.id))
|
||||
end
|
||||
end
|
||||
|
||||
describe "Reorder records" do
|
||||
test "moves a record left (up)", %{conn: conn} do
|
||||
{set, [r1, r2 | _]} = record_set_with_records(3)
|
||||
|
||||
{:ok, view, _html} = live(conn, ~p"/record-sets")
|
||||
|
||||
view
|
||||
|> element(
|
||||
"button[phx-click='move_up'][phx-value-set-id='#{set.id}'][phx-value-record-id='#{r2.id}']"
|
||||
)
|
||||
|> render_click()
|
||||
|
||||
updated = RecordSets.get_record_set!(set.id)
|
||||
ids_in_order = Enum.map(updated.items, & &1.record.id)
|
||||
assert Enum.at(ids_in_order, 0) == r2.id
|
||||
assert Enum.at(ids_in_order, 1) == r1.id
|
||||
end
|
||||
|
||||
test "moves a record right (down)", %{conn: conn} do
|
||||
{set, [r1, r2 | _]} = record_set_with_records(3)
|
||||
|
||||
{:ok, view, _html} = live(conn, ~p"/record-sets")
|
||||
|
||||
view
|
||||
|> element(
|
||||
"button[phx-click='move_down'][phx-value-set-id='#{set.id}'][phx-value-record-id='#{r1.id}']"
|
||||
)
|
||||
|> render_click()
|
||||
|
||||
updated = RecordSets.get_record_set!(set.id)
|
||||
ids_in_order = Enum.map(updated.items, & &1.record.id)
|
||||
assert Enum.at(ids_in_order, 0) == r2.id
|
||||
assert Enum.at(ids_in_order, 1) == r1.id
|
||||
end
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user