Extract LastFm module

lib/last_fm.ex

@@ -0,0 +1,43 @@
+defmodule LastFm do
+  def get_artist_info(musicbrainz_id, name) do
+    last_fm_config = last_fm_config()
+
+    case last_fm_config.api.get_artist_info(
+           {:musicbrainz_id, musicbrainz_id},
+           last_fm_config
+         ) do
+      {:ok, info} ->
+        {:ok, info}
+
+      {:error, :invalid_parameters} ->
+        # Sometimes the artist info cannot be identified with the MusicBrainz ID,
+        # because Last.fm doesn't have that information. In that case, we try again with the artist name.
+        last_fm_config.api.get_artist_info({:name, name}, last_fm_config)
+
+      error ->
+        error
+    end
+  end
+
+  def get_similar_artists(musicbrainz_id, name) do
+    last_fm_config = last_fm_config()
+
+    case last_fm_config.api.get_similar_artists(
+           {:musicbrainz_id, musicbrainz_id},
+           last_fm_config
+         ) do
+      {:ok, info} ->
+        {:ok, info}
+
+      {:error, :invalid_parameters} ->
+        # Sometimes the artist info cannot be identified with the MusicBrainz ID,
+        # because Last.fm doesn't have that information. In that case, we try again with the artist name.
+        last_fm_config.api.get_similar_artists({:name, name}, last_fm_config)
+
+      error ->
+        error
+    end
+  end
+
+  defp last_fm_config, do: LastFm.Config.resolve(:music_library)
+end

lib/music_library/artists.ex

@@ -19,46 +19,4 @@ defmodule MusicLibrary.Artists do
 
     q |> Repo.all() |> MapSet.new()
   end
-
-  def get_artist_info(artist) do
-    last_fm_config = last_fm_config()
-
-    case last_fm_config.api.get_artist_info(
-           {:musicbrainz_id, artist.musicbrainz_id},
-           last_fm_config
-         ) do
-      {:ok, info} ->
-        {:ok, info}
-
-      {:error, :invalid_parameters} ->
-        # Sometimes the artist info cannot be identified with the MusicBrainz ID,
-        # because Last.fm doesn't have that information. In that case, we try again with the artist name.
-        last_fm_config.api.get_artist_info({:name, artist.name}, last_fm_config)
-
-      error ->
-        error
-    end
-  end
-
-  def get_similar_artists(artist) do
-    last_fm_config = last_fm_config()
-
-    case last_fm_config.api.get_similar_artists(
-           {:musicbrainz_id, artist.musicbrainz_id},
-           last_fm_config
-         ) do
-      {:ok, info} ->
-        {:ok, info}
-
-      {:error, :invalid_parameters} ->
-        # Sometimes the artist info cannot be identified with the MusicBrainz ID,
-        # because Last.fm doesn't have that information. In that case, we try again with the artist name.
-        last_fm_config.api.get_similar_artists({:name, artist.name}, last_fm_config)
-
-      error ->
-        error
-    end
-  end
-
-  defp last_fm_config, do: LastFm.Config.resolve(:music_library)
 end

lib/music_library_web/live/artist_live/show.ex

@@ -27,7 +27,7 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
      |> assign(:collection_records_count, Enum.count(grouped_artist_records.collection))
      |> assign(:wishlist_records_count, Enum.count(grouped_artist_records.wishlist))
      |> assign_async(:artist_info, fn ->
-       with {:ok, artist_info} <- Artists.get_artist_info(artist) do
+       with {:ok, artist_info} <- LastFm.get_artist_info(artist.musicbrainz_id, artist.name) do
          {:ok, %{artist_info: artist_info}}
        end
      end)