From 91b81de0f804b0983240f9abfbc8931ffe9517e5 Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Wed, 11 Dec 2024 23:54:21 +0300
Subject: [PATCH] Remove duplication around MusicBrainz URL generation

---
 lib/music_brainz/release_group.ex                         | 4 ++++
 lib/music_library_web/components/record_components.ex     | 6 +-----
 lib/music_library_web/live/collection_live/show.ex        | 4 ----
 lib/music_library_web/live/collection_live/show.html.heex | 2 +-
 lib/music_library_web/live/wishlist_live/show.ex          | 4 ----
 lib/music_library_web/live/wishlist_live/show.html.heex   | 2 +-
 6 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/lib/music_brainz/release_group.ex b/lib/music_brainz/release_group.ex
index ce227544..5ae0dbcd 100644
--- a/lib/music_brainz/release_group.ex
+++ b/lib/music_brainz/release_group.ex
@@ -14,6 +14,10 @@ defmodule MusicBrainz.ReleaseGroup do
     }
   end
 
+  def url(id) do
+    "https://musicbrainz.org/release-group/#{id}"
+  end
+
   defp parse_subtype("Album"), do: :album
   defp parse_subtype("EP"), do: :ep
   defp parse_subtype("Live"), do: :live
diff --git a/lib/music_library_web/components/record_components.ex b/lib/music_library_web/components/record_components.ex
index 8c36ef3a..202f930c 100644
--- a/lib/music_library_web/components/record_components.ex
+++ b/lib/music_library_web/components/record_components.ex
@@ -139,7 +139,7 @@ defmodule MusicLibraryWeb.RecordComponents do
                 {gettext("Show")}
               </.link>
               <a
-                href={musicbrainz_url(record)}
+                href={MusicBrainz.ReleaseGroup.url(record.musicbrainz_id)}
                 target=".blank"
                 class="block px-3 py-1 text-sm leading-6 text-zinc-900 dark:text-zinc-400 hover:bg-zinc-50 dark:hover:text-zinc-300 dark:hover:bg-zinc-700"
                 role="menuitem"
@@ -188,10 +188,6 @@ defmodule MusicLibraryWeb.RecordComponents do
     """
   end
 
-  defp musicbrainz_url(record) do
-    "https://musicbrainz.org/release-group/#{record.musicbrainz_id}"
-  end
-
   defp toggle_actions_menu(record_id) do
     JS.toggle(to: "#actions-#{record_id}")
     |> JS.toggle_class("pointer-events-none", to: "#records > li")
diff --git a/lib/music_library_web/live/collection_live/show.ex b/lib/music_library_web/live/collection_live/show.ex
index 471e2156..60e36153 100644
--- a/lib/music_library_web/live/collection_live/show.ex
+++ b/lib/music_library_web/live/collection_live/show.ex
@@ -145,10 +145,6 @@ defmodule MusicLibraryWeb.CollectionLive.Show do
   defp title_segment(:show), do: gettext("Show")
   defp title_segment(:edit), do: gettext("Edit")
 
-  defp musicbrainz_url(record) do
-    "https://musicbrainz.org/release-group/#{record.musicbrainz_id}"
-  end
-
   defp human_datetime(dt) do
     "#{dt.day}/#{dt.month}/#{dt.year}"
   end
diff --git a/lib/music_library_web/live/collection_live/show.html.heex b/lib/music_library_web/live/collection_live/show.html.heex
index deb18a0b..5343e0ec 100644
--- a/lib/music_library_web/live/collection_live/show.html.heex
+++ b/lib/music_library_web/live/collection_live/show.html.heex
@@ -103,7 +103,7 @@
           {gettext("MusicBrainz ID")}
         </dt>
         <dd class="mt-1 text-sm flex justify-between leading-6 text-zinc-700 dark:text-zinc-300 sm:col-span-2 sm:mt-0">
-          <a href={musicbrainz_url(@record)}>
+          <a href={MusicBrainz.ReleaseGroup.url(@record.musicbrainz_id)}>
             <code id={"mb-#{@record.musicbrainz_id}"}>{@record.musicbrainz_id}</code>
           </a>
           <button phx-click={
diff --git a/lib/music_library_web/live/wishlist_live/show.ex b/lib/music_library_web/live/wishlist_live/show.ex
index a6314d2b..b690a22e 100644
--- a/lib/music_library_web/live/wishlist_live/show.ex
+++ b/lib/music_library_web/live/wishlist_live/show.ex
@@ -128,10 +128,6 @@ defmodule MusicLibraryWeb.WishlistLive.Show do
   defp title_segment(:show), do: gettext("Show")
   defp title_segment(:edit), do: gettext("Edit")
 
-  defp musicbrainz_url(record) do
-    "https://musicbrainz.org/release-group/#{record.musicbrainz_id}"
-  end
-
   defp human_datetime(dt) do
     "#{dt.day}/#{dt.month}/#{dt.year}"
   end
diff --git a/lib/music_library_web/live/wishlist_live/show.html.heex b/lib/music_library_web/live/wishlist_live/show.html.heex
index 6cdb57f5..712f978f 100644
--- a/lib/music_library_web/live/wishlist_live/show.html.heex
+++ b/lib/music_library_web/live/wishlist_live/show.html.heex
@@ -104,7 +104,7 @@
           {gettext("MusicBrainz ID")}
         </dt>
         <dd class="mt-1 text-sm flex justify-between leading-6 text-zinc-700 dark:text-zinc-300 sm:col-span-2 sm:mt-0">
-          <a href={musicbrainz_url(@record)}>
+          <a href={MusicBrainz.ReleaseGroup.url(@record.musicbrainz_id)}>
             <code id={"mb-#{@record.musicbrainz_id}"}>{@record.musicbrainz_id}</code>
           </a>
           <button phx-click={