cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove excessively defensive coding

Browse Source
This commit is contained in:
Claudio Ortolina
2025-07-03 21:18:21 +01:00
parent b2bc5f07f7
commit 93e10bc5d9
6 changed files with 35 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/music_library/scrobble_rules_test.exs
+1 -11
View File
@@ -188,16 +188,6 @@ defmodule MusicLibrary.ScrobbleRulesTest do
assert updated_track.artist.musicbrainz_id == rule.target_musicbrainz_id
end
test "apply_album_rule/1 with wrong type returns error" do
rule = scrobble_rule_fixture(@valid_artist_attrs)
assert {:error, _reason} = ScrobbleRules.apply_album_rule(rule)
end
test "apply_artist_rule/1 with wrong type returns error" do
rule = scrobble_rule_fixture(@valid_album_attrs)
assert {:error, _reason} = ScrobbleRules.apply_artist_rule(rule)
end
test "apply_rule/1 delegates to correct function based on type" do
album_rule = scrobble_rule_fixture(@valid_album_attrs)
artist_rule = scrobble_rule_fixture(@valid_artist_attrs)
@@ -239,7 +229,7 @@ defmodule MusicLibrary.ScrobbleRulesTest do
album: %{musicbrainz_id: "", title: "Different Album"}
})
assert {:ok, results} = ScrobbleRules.apply_all_rules()
assert results = ScrobbleRules.apply_all_rules()
assert length(results) == 2
# Verify all results are successful