From 96bd453900428e0ff774111e2325290128558af6 Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Wed, 29 Jan 2025 10:21:41 +0000 Subject: [PATCH] When not possible to determine otherwise, assums a record has been released --- lib/music_library/records/record.ex | 5 ++++- test/music_library/records/record_test.exs | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/music_library/records/record.ex b/lib/music_library/records/record.ex index 4b2eff8f..3c7ead8d 100644 --- a/lib/music_library/records/record.ex +++ b/lib/music_library/records/record.ex @@ -227,7 +227,10 @@ defmodule MusicLibrary.Records.Record do Date.compare(current_day, release_date) != :lt _error -> - false + # When a release date cannot be parsed it's normally because the record + # is old and information is not specific, so we can err on the side of assuming + # it's been released. + true end end diff --git a/test/music_library/records/record_test.exs b/test/music_library/records/record_test.exs index 82f20492..eb3fddd5 100644 --- a/test/music_library/records/record_test.exs +++ b/test/music_library/records/record_test.exs @@ -27,11 +27,11 @@ defmodule MusicLibrary.Records.RecordTest do assert MusicLibrary.Records.Record.released?(record, current_date) end - test "it returns false if the release date is not precise enough", %{ + test "it returns true if the release date is not precise enough", %{ current_date: current_date } do record = %MusicLibrary.Records.Record{release: "2019"} - refute MusicLibrary.Records.Record.released?(record, current_date) + assert MusicLibrary.Records.Record.released?(record, current_date) end end end