diff --git a/backlog/tasks/ml-182.3 - Wave-3-Convert-live-2-→-visit-2-for-CRUD-LiveViews-6-files.md b/backlog/tasks/ml-182.3 - Wave-3-Convert-live-2-→-visit-2-for-CRUD-LiveViews-6-files.md index 44bd35df..ff2f0678 100644 --- a/backlog/tasks/ml-182.3 - Wave-3-Convert-live-2-→-visit-2-for-CRUD-LiveViews-6-files.md +++ b/backlog/tasks/ml-182.3 - Wave-3-Convert-live-2-→-visit-2-for-CRUD-LiveViews-6-files.md @@ -4,6 +4,7 @@ title: "Wave 3: Convert live/2 → visit/2 for CRUD LiveViews (6 files)" status: In Progress assignee: [] created_date: "2026-05-14 22:14" +updated_date: "2026-05-15 05:46" labels: - testing - refactoring @@ -28,8 +29,8 @@ Convert `live/2` → `visit/2` for standard CRUD LiveViews. Files: - **maintenance_live/index_test.exs** ✅ Done (14 tests pass) — all `live/2` → `visit/2`, `render_click/3` → `click_button/2` with scoped selectors for duplicate button texts. External redirect test simplified. Kept `unwrap(&render_async/1)` for async status tests. - **online_store_template_live/index_test.exs** ✅ Done (7 tests pass) — mixed `visit/2` and `live/2` eliminated. Field labels: "Template Name", "URL Template". Buttons: "Save Template", "Delete", "Disable/Enable template". -- **record_set_live/index_test.exs** ⏸️ Needs form label inspection — likely "Name" field, "Save" button. -- **record_set_live/show_test.exs** ⏸️ Complex: add-record modal with `phx-target`, `trigger_hook` for drag-and-drop, delete/remove buttons in dropdown menus. Need to inspect templates for exact button texts. +- **record_set_live/index_test.exs** ✅ Done (7 tests pass) — removed `import Phoenix.LiveViewTest`. Create/Edit: `live/2` + `form/3` + `render_submit/1` → `visit/2` + `fill_in/3` + `click_button/2`. Validation: `live/2` + `form/3` + `render_change/1` → `visit/2` + `click_button/2` + `assert_has("[data-part='error']", ...)`. Ordering test: `live/2` → `visit/2` + `Phoenix.LiveViewTest.render(session.view)`. Button text: "Save Set", field label: "Name". +- **record_set_live/show_test.exs** ✅ Done (15 tests pass) — removed `import Phoenix.LiveViewTest`, replaced with explicit `only:` for `render_click/1, render_hook/3, render_submit/1, element/2, form/3`. Remove record: `click_button("button[...]", "Remove")`. Delete set: `click_button("button[phx-click='delete_set']", "Delete")` + `assert_path`. Reorder: `unwrap(&render_hook/3)`. Picker search: `search_picker` helper uses `unwrap` with `form/3` + `render_submit/1`. Add record: `unwrap` with `element/2` + `render_click/1` on `