Rename /images to /covers

This commit is contained in:
Claudio Ortolina
2024-10-06 16:06:33 +01:00
parent 6913ee2d8d
commit ac27e86fb5
8 changed files with 17 additions and 17 deletions
@@ -1,4 +1,4 @@
defmodule MusicLibraryWeb.ImageControllerTest do
defmodule MusicLibraryWeb.CoverControllerTest do
use MusicLibraryWeb.ConnCase
import MusicLibrary.RecordsFixtures
@@ -7,18 +7,18 @@ defmodule MusicLibraryWeb.ImageControllerTest do
%{record: record_fixture()}
end
describe "GET /images/:record_id" do
describe "GET /covers/:record_id" do
setup [:create_record]
test "404s when record doesn't exist", %{conn: conn} do
id = Ecto.UUID.generate()
conn = get(conn, ~p"/images/#{id}")
conn = get(conn, ~p"/covers/#{id}")
assert text_response(conn, 404) == "Not found"
end
test "serves the image when etag doesn't exist", %{conn: conn, record: record} do
conn = get(conn, ~p"/images/#{record.id}")
test "serves the cover when etag doesn't exist", %{conn: conn, record: record} do
conn = get(conn, ~p"/covers/#{record.id}")
assert conn.status == 200
assert get_resp_header(conn, "content-type") == ["image/jpeg; charset=utf-8"]
@@ -27,11 +27,11 @@ defmodule MusicLibraryWeb.ImageControllerTest do
assert conn.resp_body == record.cover_data
end
test "serves the image when etag doesn't match", %{conn: conn, record: record} do
test "serves the cover when etag doesn't match", %{conn: conn, record: record} do
conn =
conn
|> put_req_header("if-none-match", "invalid-etag")
|> get(~p"/images/#{record.id}")
|> get(~p"/covers/#{record.id}")
assert conn.status == 200
assert get_resp_header(conn, "content-type") == ["image/jpeg; charset=utf-8"]
@@ -44,7 +44,7 @@ defmodule MusicLibraryWeb.ImageControllerTest do
conn =
conn
|> put_req_header("if-none-match", record.cover_hash)
|> get(~p"/images/#{record.id}")
|> get(~p"/covers/#{record.id}")
assert conn.status == 304
assert get_resp_header(conn, "content-type") == []
@@ -46,7 +46,7 @@ defmodule MusicLibraryWeb.RecordIndexTest do
assert record_row_html =~ to_string(record.release)
assert record_row_html =~ Record.format_short_label(record.format)
assert record_row_html =~ record.release
assert record_row_html =~ ~p"/images/#{record.id}?vsn=#{record.cover_hash}"
assert record_row_html =~ ~p"/covers/#{record.id}?vsn=#{record.cover_hash}"
for artist <- record.artists do
assert record_row_html =~ escape(artist["name"])
@@ -115,7 +115,7 @@ defmodule MusicLibraryWeb.RecordIndexTest do
record = record_fixture(cover_data: File.read!(marbles_cover_fixture()))
{:ok, form_live, html} = live(conn, ~p"/records/#{record.id}/edit")
assert html =~ ~p"/images/#{record.id}?vsn=#{record.cover_hash}"
assert html =~ ~p"/covers/#{record.id}?vsn=#{record.cover_hash}"
cover_metadata = cover_metadata(raven_cover_fixture())
@@ -135,7 +135,7 @@ defmodule MusicLibraryWeb.RecordIndexTest do
assert updated_cover.cover_hash !== record.cover_hash
assert list_html =~ ~p"/images/#{record.id}?vsn=#{updated_cover.cover_hash}"
assert list_html =~ ~p"/covers/#{record.id}?vsn=#{updated_cover.cover_hash}"
end
defp cover_metadata(path) do
@@ -35,7 +35,7 @@ defmodule MusicLibraryWeb.RecordShowTest do
assert html =~ to_string(record.release)
assert html =~ Record.format_short_label(record.format)
assert html =~ record.release
assert html =~ ~p"/images/#{record.id}?vsn=#{record.cover_hash}"
assert html =~ ~p"/covers/#{record.id}?vsn=#{record.cover_hash}"
for artist <- record.artists do
assert html =~ escape(artist["name"])