From be1de52984bf2c8c605735ac19f2dc09ec03673b Mon Sep 17 00:00:00 2001
From: Claudio Ortolina <cloud8421@gmail.com>
Date: Sun, 9 Feb 2025 08:33:00 +0000
Subject: [PATCH] Refactor Records.Record for simplification

- Remove unnecessary intermediate variables
- Remove unnecessary pipes
---
 lib/music_library/records/record.ex | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/lib/music_library/records/record.ex b/lib/music_library/records/record.ex
index 50828bc6..cf921b13 100644
--- a/lib/music_library/records/record.ex
+++ b/lib/music_library/records/record.ex
@@ -98,8 +98,7 @@ defmodule MusicLibrary.Records.Record do
   def update_release_ids(record = %__MODULE__{musicbrainz_data: musicbrainz_data}) do
     release_ids = Enum.map(musicbrainz_data["releases"], fn r -> r["id"] end)
 
-    record
-    |> change(release_ids: release_ids)
+    change(record, release_ids: release_ids)
   end
 
   def update_release_ids(changeset) do
@@ -114,10 +113,9 @@ defmodule MusicLibrary.Records.Record do
   end
 
   def update_included_release_group_ids(record = %__MODULE__{musicbrainz_data: musicbrainz_data}) do
-    included_release_group_ids = extract_included_release_group_ids(musicbrainz_data)
-
-    record
-    |> change(included_release_group_ids: included_release_group_ids)
+    change(record,
+      included_release_group_ids: extract_included_release_group_ids(musicbrainz_data)
+    )
   end
 
   def update_included_release_group_ids(changeset) do
@@ -126,9 +124,11 @@ defmodule MusicLibrary.Records.Record do
         changeset
 
       musicbrainz_data ->
-        included_release_group_ids = extract_included_release_group_ids(musicbrainz_data)
-
-        put_change(changeset, :included_release_group_ids, included_release_group_ids)
+        put_change(
+          changeset,
+          :included_release_group_ids,
+          extract_included_release_group_ids(musicbrainz_data)
+        )
     end
   end
 
@@ -144,9 +144,7 @@ defmodule MusicLibrary.Records.Record do
   end
 
   def generate_cover_hash(record = %__MODULE__{cover_data: cover_data}) do
-    record
-    |> change()
-    |> put_change(:cover_hash, Cover.hash(cover_data))
+    change(record, cover_hash: Cover.hash(cover_data))
   end
 
   def generate_cover_hash(changeset) do