diff --git a/.credo.exs b/.credo.exs index 663583fd..d992b87e 100644 --- a/.credo.exs +++ b/.credo.exs @@ -26,10 +26,20 @@ {ExSlop.Check.Refactor.ReduceMapPut, []}, {ExSlop.Check.Refactor.RedundantBooleanIf, []}, {ExSlop.Check.Refactor.FlatMapFilter, []}, + {ExSlop.Check.Refactor.RedundantEnumJoinSeparator, []}, + {ExSlop.Check.Refactor.UseMapJoin, []}, + {ExSlop.Check.Refactor.PreferEnumSlice, []}, + {ExSlop.Check.Refactor.GraphemesLength, []}, + {ExSlop.Check.Refactor.ManualStringReverse, []}, + {ExSlop.Check.Refactor.SortThenAt, []}, + {ExSlop.Check.Refactor.SortForTopK, []}, + {ExSlop.Check.Refactor.ListFold, []}, + {ExSlop.Check.Refactor.LengthInGuard, []}, + {ExSlop.Check.Refactor.ExplicitSumReduce, []}, {ExSlop.Check.Readability.NarratorDoc, []}, {ExSlop.Check.Readability.DocFalseOnPublicFunction, []}, {ExSlop.Check.Readability.BoilerplateDocParams, []}, - {ExSlop.Check.Readability.ObviousComment, []}, + {ExSlop.Check.Readability.ObviousComment, [additional_keywords: []]}, {ExSlop.Check.Readability.StepComment, []}, {ExSlop.Check.Readability.NarratorComment, []}, {ExSlop.Check.Readability.UnaliasedModuleUse, []}, diff --git a/lib/music_library_web/live/artist_live/biography.ex b/lib/music_library_web/live/artist_live/biography.ex index 98adeb8e..33119bfa 100644 --- a/lib/music_library_web/live/artist_live/biography.ex +++ b/lib/music_library_web/live/artist_live/biography.ex @@ -32,31 +32,25 @@ defmodule MusicLibraryWeb.ArtistLive.Biography do case String.split(bio, last_fm_link_regex, include_captures: true) do [text, link, ""] -> reformatted_bio = - Enum.join( - [ - text, - ~s(
#{link}
) - ], - "" - ) + Enum.join([ + text, + ~s(#{link}
) + ]) render_content(reformatted_bio) [text, link, license] -> reformatted_bio = - Enum.join( - [ - text, - ~s(#{link}
), - ~s(#{license}
) - ], - "" - ) + Enum.join([ + text, + ~s(#{link}
), + ~s(#{license}
) + ]) render_content(reformatted_bio) other -> - render_content(Enum.join(other, "")) + render_content(Enum.join(other)) end end diff --git a/mix.lock b/mix.lock index 2519110e..536e1998 100644 --- a/mix.lock +++ b/mix.lock @@ -21,7 +21,7 @@ "erlex": {:hex, :erlex, "0.2.8", "cd8116f20f3c0afe376d1e8d1f0ae2452337729f68be016ea544a72f767d9c12", [:mix], [], "hexpm", "9d66ff9fedf69e49dc3fd12831e12a8a37b76f8651dd21cd45fcf5561a8a7590"}, "error_tracker": {:hex, :error_tracker, "0.8.0", "15774836205c1b4cd8275b594d99c10f4de168eb00573743526b6a919f2aca4a", [:mix], [{:ecto, "~> 3.13", [hex: :ecto, repo: "hexpm", optional: false]}, {:ecto_sql, "~> 3.13", [hex: :ecto_sql, repo: "hexpm", optional: false]}, {:ecto_sqlite3, ">= 0.0.0", [hex: :ecto_sqlite3, repo: "hexpm", optional: true]}, {:igniter, "~> 0.5", [hex: :igniter, repo: "hexpm", optional: true]}, {:jason, "~> 1.1", [hex: :jason, repo: "hexpm", optional: true]}, {:myxql, ">= 0.0.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:phoenix_ecto, "~> 4.6", [hex: :phoenix_ecto, repo: "hexpm", optional: false]}, {:phoenix_live_view, "~> 1.0", [hex: :phoenix_live_view, repo: "hexpm", optional: false]}, {:plug, "~> 1.10", [hex: :plug, repo: "hexpm", optional: false]}, {:postgrex, ">= 0.0.0", [hex: :postgrex, repo: "hexpm", optional: true]}], "hexpm", "00ab8342932de7ad63be567ddd36ea238c840c122c7b2c5d1a42638ce6f39220"}, "esbuild": {:hex, :esbuild, "0.10.0", "b0aa3388a1c23e727c5a3e7427c932d89ee791746b0081bbe56103e9ef3d291f", [:mix], [{:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "468489cda427b974a7cc9f03ace55368a83e1a7be12fba7e30969af78e5f8c70"}, - "ex_slop": {:hex, :ex_slop, "0.3.1", "ffbd119a5764380bd1d6b1185743646559bd3ebedf65e35adb8c7980482c5b77", [:mix], [{:credo, "~> 1.7", [hex: :credo, repo: "hexpm", optional: false]}], "hexpm", "74c20ada7ad6b9f7d3372e82f457b933c0b6c3328be25f2b4063fe6826198ddc"}, + "ex_slop": {:hex, :ex_slop, "0.4.0", "06c39628e2a278a9adeaf76047f7b98002a453b53a38b48faa3921835675c680", [:mix], [{:credo, "~> 1.7", [hex: :credo, repo: "hexpm", optional: false]}], "hexpm", "563da973e0251ebd69785a21873ea566158c95b123a5dccf075c0c687e4acc2e"}, "expo": {:hex, :expo, "1.1.1", "4202e1d2ca6e2b3b63e02f69cfe0a404f77702b041d02b58597c00992b601db5", [:mix], [], "hexpm", "5fb308b9cb359ae200b7e23d37c76978673aa1b06e2b3075d814ce12c5811640"}, "exqlite": {:hex, :exqlite, "0.36.0", "07b4f95d61cb82b8d52946d0639497fa7d32117e09b2c8d25e24a38723c295cb", [:make, :mix], [{:cc_precompiler, "~> 0.1", [hex: :cc_precompiler, repo: "hexpm", optional: false]}, {:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:elixir_make, "~> 0.8", [hex: :elixir_make, repo: "hexpm", optional: false]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "cbeca3ce781f9ff07cfa9a87486f3ebd512a143ad6a14ed5c9fca21fe0bf3ae7"}, "file_system": {:hex, :file_system, "1.1.1", "31864f4685b0148f25bd3fbef2b1228457c0c89024ad67f7a81a3ffbc0bbad3a", [:mix], [], "hexpm", "7a15ff97dfe526aeefb090a7a9d3d03aa907e100e262a0f8f7746b78f8f87a5d"},