Move more fixtures to compile time

test/support/fixtures/discogs/artist.ex

@@ -1,16 +1,17 @@
 defmodule Discogs.Fixtures.Artist do
   @fixtures_folder Path.join([File.cwd!(), "test/support/fixtures/discogs"])
 
-  def get_artist do
-    Path.join([@fixtures_folder, "artist - steven wilson.json"])
+  # Cache fixtures at compile time to avoid repeated file I/O
+  @get_artist Path.join([@fixtures_folder, "artist - steven wilson.json"])
               |> File.read!()
               |> JSON.decode!()
-  end
 
-  def image_data do
-    Path.join([@fixtures_folder, "steven wilson.jpeg"])
+  @image_data Path.join([@fixtures_folder, "steven wilson.jpeg"])
               |> File.read!()
-  end
+
+  def get_artist, do: @get_artist
+
+  def image_data, do: @image_data
 
   def image_width, do: 225
 end

test/support/fixtures/last_fm/artist.ex

@@ -1,11 +1,12 @@
 defmodule LastFm.Fixtures.Artist do
   @fixtures_folder Path.join([File.cwd!(), "test/support/fixtures/last_fm"])
 
-  def get_info do
-    Path.join([@fixtures_folder, "artist.getinfo.json"])
+  # Cache fixtures at compile time to avoid repeated file I/O
+  @get_info Path.join([@fixtures_folder, "artist.getinfo.json"])
             |> File.read!()
             |> JSON.decode!()
-  end
+
+  def get_info, do: @get_info
 
   def get_similar_artists do
     %{"similarartists" => %{"artist" => []}}

test/support/fixtures/music_brainz/artist.ex

@@ -1,9 +1,10 @@
 defmodule MusicBrainz.Fixtures.Artist do
   @fixtures_folder Path.join([File.cwd!(), "test/support/fixtures/music_brainz"])
 
-  def get_artist do
-    Path.join([@fixtures_folder, "artist - steven wilson.json"])
+  # Cache fixtures at compile time to avoid repeated file I/O
+  @get_artist Path.join([@fixtures_folder, "artist - steven wilson.json"])
               |> File.read!()
               |> JSON.decode!()
-  end
+
+  def get_artist, do: @get_artist
 end

test/support/fixtures/wikipedia/fixtures.ex

@@ -1,32 +1,33 @@
 defmodule Wikipedia.Fixtures do
   @fixtures_folder Path.join([File.cwd!(), "test/support/fixtures/wikipedia"])
 
-  def wikidata_response do
-    Path.join([@fixtures_folder, "wikidata_response.json"])
+  # Cache fixtures at compile time to avoid repeated file I/O
+  @wikidata_response Path.join([@fixtures_folder, "wikidata_response.json"])
                      |> File.read!()
                      |> JSON.decode!()
-  end
 
-  def wikidata_response_no_enwiki do
-    Path.join([@fixtures_folder, "wikidata_response_no_enwiki.json"])
+  @wikidata_response_no_enwiki Path.join([@fixtures_folder, "wikidata_response_no_enwiki.json"])
                                |> File.read!()
                                |> JSON.decode!()
-  end
 
-  def article_summary do
-    Path.join([@fixtures_folder, "article_summary.json"])
+  @article_summary Path.join([@fixtures_folder, "article_summary.json"])
                    |> File.read!()
                    |> JSON.decode!()
-  end
 
-  def article_extract do
-    Path.join([@fixtures_folder, "article_extract.json"])
+  @article_extract Path.join([@fixtures_folder, "article_extract.json"])
                    |> File.read!()
                    |> JSON.decode!()
-  end
+
+  def wikidata_response, do: @wikidata_response
+
+  def wikidata_response_no_enwiki, do: @wikidata_response_no_enwiki
+
+  def article_summary, do: @article_summary
+
+  def article_extract, do: @article_extract
 
   def article_extract_html do
-    article_extract()
+    @article_extract
     |> get_in(["query", "pages"])
     |> Map.values()
     |> List.first()