Invert conditional and use existing functions

This commit is contained in:
Claudio Ortolina
2026-05-11 15:03:55 +01:00
parent 5b4be08e5b
commit e1943ff030
@@ -55,11 +55,7 @@ defmodule MusicLibraryWeb.CollectionController do
end
defp do_scrobble(conn, record) do
if is_nil(record.selected_release_id) or record.selected_release_id == "" do
conn
|> put_status(422)
|> json(%{status: "error", reason: "no_selected_release"})
else
if Records.Record.selected_release(record) do
case MusicBrainz.get_release(record.selected_release_id) do
{:ok, release} ->
release_with_tracks = MusicBrainz.Release.from_api_response(release)
@@ -93,6 +89,10 @@ defmodule MusicLibraryWeb.CollectionController do
|> put_status(502)
|> json(%{status: "error", reason: "musicbrainz_error"})
end
else
conn
|> put_status(422)
|> json(%{status: "error", reason: "no_selected_release"})
end
end