Invert conditional and use existing functions
This commit is contained in:
@@ -55,11 +55,7 @@ defmodule MusicLibraryWeb.CollectionController do
|
|||||||
end
|
end
|
||||||
|
|
||||||
defp do_scrobble(conn, record) do
|
defp do_scrobble(conn, record) do
|
||||||
if is_nil(record.selected_release_id) or record.selected_release_id == "" do
|
if Records.Record.selected_release(record) do
|
||||||
conn
|
|
||||||
|> put_status(422)
|
|
||||||
|> json(%{status: "error", reason: "no_selected_release"})
|
|
||||||
else
|
|
||||||
case MusicBrainz.get_release(record.selected_release_id) do
|
case MusicBrainz.get_release(record.selected_release_id) do
|
||||||
{:ok, release} ->
|
{:ok, release} ->
|
||||||
release_with_tracks = MusicBrainz.Release.from_api_response(release)
|
release_with_tracks = MusicBrainz.Release.from_api_response(release)
|
||||||
@@ -93,6 +89,10 @@ defmodule MusicLibraryWeb.CollectionController do
|
|||||||
|> put_status(502)
|
|> put_status(502)
|
||||||
|> json(%{status: "error", reason: "musicbrainz_error"})
|
|> json(%{status: "error", reason: "musicbrainz_error"})
|
||||||
end
|
end
|
||||||
|
else
|
||||||
|
conn
|
||||||
|
|> put_status(422)
|
||||||
|
|> json(%{status: "error", reason: "no_selected_release"})
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user