cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add TODOs for component extraction

Browse Source
This commit is contained in:
Claudio Ortolina
2024-11-20 15:54:12 +00:00
parent 5b3aab51ed
commit e519f355bc
3 changed files with 23 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/music_library_web/live/collection_live/show.html.heex
+3 -2
View File
@@ -25,7 +25,7 @@
@record.format @record.format
) %> · <%= Records.Record.type_long_label(@record.type) %> ) %> · <%= Records.Record.type_long_label(@record.type) %>
</p> </p>
<!-- TODO: extract to a component -->
<nav class="mt-5 isolate inline-flex rounded-md shadow-sm"> <nav class="mt-5 isolate inline-flex rounded-md shadow-sm">
<.link patch={~p"/collection/#{@record}/show/edit"} phx-click={JS.push_focus()}> <.link patch={~p"/collection/#{@record}/show/edit"} phx-click={JS.push_focus()}>
<.button type="button" class="relative inline-flex items-center rounded-r-none"> <.button type="button" class="relative inline-flex items-center rounded-r-none">
@@ -70,6 +70,7 @@
</nav> </nav>
</div> </div>
<div> <div>
<!-- TODO: extract to a component -->
<dl class="mt-4 divide-y divide-zinc-100 dark:divide-slate-300/30"> <dl class="mt-4 divide-y divide-zinc-100 dark:divide-slate-300/30">
<div class="py-2 sm:grid sm:grid-cols-3 sm:gap-4 sm:px-0"> <div class="py-2 sm:grid sm:grid-cols-3 sm:gap-4 sm:px-0">
<dt class="text-sm font-medium leading-6 text-zinc-900 dark:text-zinc-400"> <dt class="text-sm font-medium leading-6 text-zinc-900 dark:text-zinc-400">
@@ -143,7 +144,7 @@
</dl> </dl>
</div> </div>
</div> </div>
<!-- TODO: extract to a component -->
<details class="mt-4 px-4 text-zinc-700 hover:text-zinc-500 dark:text-zinc-400 dark:hover:text-zinc-300"> <details class="mt-4 px-4 text-zinc-700 hover:text-zinc-500 dark:text-zinc-400 dark:hover:text-zinc-300">
<summary class="text-xs sm:text-sm"><%= gettext("MusicBrainz data") %></summary> <summary class="text-xs sm:text-sm"><%= gettext("MusicBrainz data") %></summary>
<pre><code class="text-xs sm:text-sm"><%= Jason.encode!(@record.musicbrainz_data, pretty: true) %></code></pre> <pre><code class="text-xs sm:text-sm"><%= Jason.encode!(@record.musicbrainz_data, pretty: true) %></code></pre>
lib/music_library_web/live/wishlist_live/show.html.heex
+3 -2
View File
@@ -25,7 +25,7 @@
@record.format @record.format
) %> · <%= Records.Record.type_long_label(@record.type) %> ) %> · <%= Records.Record.type_long_label(@record.type) %>
</p> </p>
<!-- TODO: extract to a component -->
<nav class="mt-5 isolate inline-flex rounded-md shadow-sm"> <nav class="mt-5 isolate inline-flex rounded-md shadow-sm">
<.link patch={~p"/wishlist/#{@record}/show/edit"} phx-click={JS.push_focus()}> <.link patch={~p"/wishlist/#{@record}/show/edit"} phx-click={JS.push_focus()}>
<.button type="button" class="relative inline-flex items-center rounded-r-none"> <.button type="button" class="relative inline-flex items-center rounded-r-none">
@@ -71,6 +71,7 @@
</div> </div>
<div> <div>
<!-- TODO: extract to a component -->
<dl class="mt-4 divide-y divide-zinc-100 dark:divide-slate-300/30"> <dl class="mt-4 divide-y divide-zinc-100 dark:divide-slate-300/30">
<div class="py-2 sm:grid sm:grid-cols-3 sm:gap-4 sm:px-0"> <div class="py-2 sm:grid sm:grid-cols-3 sm:gap-4 sm:px-0">
<dt class="text-sm font-medium leading-6 text-zinc-900 dark:text-zinc-400"> <dt class="text-sm font-medium leading-6 text-zinc-900 dark:text-zinc-400">
@@ -136,7 +137,7 @@
</dl> </dl>
</div> </div>
</div> </div>
<!-- TODO: extract to a component -->
<details class="mt-4 px-4 text-zinc-700 hover:text-zinc-500 dark:text-zinc-400 dark:hover:text-zinc-300"> <details class="mt-4 px-4 text-zinc-700 hover:text-zinc-500 dark:text-zinc-400 dark:hover:text-zinc-300">
<summary class="text-xs sm:text-sm"><%= gettext("MusicBrainz data") %></summary> <summary class="text-xs sm:text-sm"><%= gettext("MusicBrainz data") %></summary>
<pre><code class="text-xs sm:text-sm"><%= Jason.encode!(@record.musicbrainz_data, pretty: true) %></code></pre> <pre><code class="text-xs sm:text-sm"><%= Jason.encode!(@record.musicbrainz_data, pretty: true) %></code></pre>
priv/gettext/default.pot
+17 -17
View File
@@ -29,12 +29,12 @@ msgstr ""
msgid "Attempting to reconnect" msgid "Attempting to reconnect"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:154 #: lib/music_library_web/live/collection_live/show.html.heex:155
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "Back to records" msgid "Back to records"
msgstr "" msgstr ""
#: lib/music_library_web/live/wishlist_live/show.html.heex:147 #: lib/music_library_web/live/wishlist_live/show.html.heex:148
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "Back to wishlist" msgid "Back to wishlist"
msgstr "" msgstr ""
@@ -105,8 +105,8 @@ msgstr ""
msgid "Formats" msgid "Formats"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:76 #: lib/music_library_web/live/collection_live/show.html.heex:77
#: lib/music_library_web/live/wishlist_live/show.html.heex:77 #: lib/music_library_web/live/wishlist_live/show.html.heex:78
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "Genres" msgid "Genres"
msgstr "" msgstr ""
@@ -128,8 +128,8 @@ msgstr ""
msgid "Import from MusicBrainz" msgid "Import from MusicBrainz"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:129 #: lib/music_library_web/live/collection_live/show.html.heex:130
#: lib/music_library_web/live/wishlist_live/show.html.heex:122 #: lib/music_library_web/live/wishlist_live/show.html.heex:123
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "Inserted at" msgid "Inserted at"
msgstr "" msgstr ""
@@ -154,9 +154,9 @@ msgstr ""
msgid "Logout" msgid "Logout"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:84 #: lib/music_library_web/live/collection_live/show.html.heex:85
#: lib/music_library_web/live/record_live/form_component.ex:46 #: lib/music_library_web/live/record_live/form_component.ex:46
#: lib/music_library_web/live/wishlist_live/show.html.heex:85 #: lib/music_library_web/live/wishlist_live/show.html.heex:86
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "MusicBrainz ID" msgid "MusicBrainz ID"
msgstr "" msgstr ""
@@ -205,7 +205,7 @@ msgstr ""
msgid "Purchased at" msgid "Purchased at"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:106 #: lib/music_library_web/live/collection_live/show.html.heex:107
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "Purchased on" msgid "Purchased on"
msgstr "" msgstr ""
@@ -312,8 +312,8 @@ msgstr ""
msgid "Types" msgid "Types"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:137 #: lib/music_library_web/live/collection_live/show.html.heex:138
#: lib/music_library_web/live/wishlist_live/show.html.heex:130 #: lib/music_library_web/live/wishlist_live/show.html.heex:131
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "Updated at" msgid "Updated at"
msgstr "" msgstr ""
@@ -351,14 +351,14 @@ msgstr ""
msgid "close" msgid "close"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:94 #: lib/music_library_web/live/collection_live/show.html.heex:95
#: lib/music_library_web/live/wishlist_live/show.html.heex:95 #: lib/music_library_web/live/wishlist_live/show.html.heex:96
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "Copy MusicBrainz ID to clipboard" msgid "Copy MusicBrainz ID to clipboard"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:148 #: lib/music_library_web/live/collection_live/show.html.heex:149
#: lib/music_library_web/live/wishlist_live/show.html.heex:141 #: lib/music_library_web/live/wishlist_live/show.html.heex:142
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "MusicBrainz data" msgid "MusicBrainz data"
msgstr "" msgstr ""
@@ -391,8 +391,8 @@ msgstr ""
msgid "Number of included records" msgid "Number of included records"
msgstr "" msgstr ""
#: lib/music_library_web/live/collection_live/show.html.heex:117 #: lib/music_library_web/live/collection_live/show.html.heex:118
#: lib/music_library_web/live/wishlist_live/show.html.heex:110 #: lib/music_library_web/live/wishlist_live/show.html.heex:111
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
msgid "Includes" msgid "Includes"
msgstr "" msgstr ""