From ebf3dc616e8e33b3943b58400c674f31e3151254 Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Mon, 9 Feb 2026 17:00:30 +0000 Subject: [PATCH] Improve Wikipedia worker - No need to sleep, Wikipedia API is not rate-limited - Account for non-retryable failures (no english found) --- .../worker/artist_refresh_wikipedia_data.ex | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/music_library/worker/artist_refresh_wikipedia_data.ex b/lib/music_library/worker/artist_refresh_wikipedia_data.ex index cedee3fe..4efd2a62 100644 --- a/lib/music_library/worker/artist_refresh_wikipedia_data.ex +++ b/lib/music_library/worker/artist_refresh_wikipedia_data.ex @@ -3,10 +3,9 @@ defmodule MusicLibrary.Worker.ArtistRefreshWikipediaData do @impl Oban.Worker def perform(%Oban.Job{args: %{"id" => artist_info_id}}) do - result = MusicLibrary.Artists.refresh_wikipedia_data(artist_info_id) - - Process.sleep(1_000) - - result + with {:error, :no_english_wikipedia} <- + MusicLibrary.Artists.refresh_wikipedia_data(artist_info_id) do + {:discard, :no_english_wikipedia} + end end end