ML-193: add secondary parser, search, and API coverage tests

Add ~80 focused tests across 10 files covering:

- Record set search by name, description, contained record title, artist name
- Navigation events for records, artists, record sets, links, and view-all actions
- MusicBrainz.ReleaseGroup parser (artist credits, included RGs, release IDs, types)
- MusicBrainz.ReleaseSearchResult edge cases (missing RG, unknown formats)
- LastFm.Session XML edge cases (non-subscriber, missing nodes)
- MusicLibrary.HttpError default status-kind mapping
- Discogs.API.ErrorResponse fallback message and retry-delay behavior
- ArtistRefreshWikipediaData {:cancel, :no_english_wikipedia} worker path
- StatsComponents grouped on-this-day records and anniversary labels
This commit is contained in:
Claudio Ortolina
2026-05-21 10:45:29 +01:00
parent e99597dc7e
commit ec6980eea0
10 changed files with 961 additions and 16 deletions
+69
View File
@@ -4,6 +4,75 @@ defmodule DiscogsTest do
alias Discogs.API.ErrorResponse
alias Discogs.Fixtures
describe "ErrorResponse.from_response/1" do
test "extracts message from body" do
err = ErrorResponse.from_response(%{status: 429, body: %{"message" => "rate limited"}})
assert err.message == "rate limited"
assert err.kind == :rate_limit
end
test "fallback message when body has no message key" do
err = ErrorResponse.from_response(%{status: 500, body: %{"error" => "boom"}})
assert err.message == nil
assert err.kind == :server_error
end
test "fallback message when body is not a map" do
err = ErrorResponse.from_response(%{status: 404, body: "not found"})
assert err.message == nil
assert err.kind == :not_found
end
end
describe "retry_delay_seconds/1" do
test "returns 60 for rate_limit" do
err = ErrorResponse.from_response(%{status: 429, body: %{}})
assert ErrorResponse.retry_delay_seconds(err) == 60
end
test "returns 30 for server_error" do
err = ErrorResponse.from_response(%{status: 500, body: %{}})
assert ErrorResponse.retry_delay_seconds(err) == 30
end
test "returns 10 for timeout" do
err = %ErrorResponse{status: nil, message: nil, kind: :timeout, body: nil}
assert ErrorResponse.retry_delay_seconds(err) == 10
end
test "returns 30 as default for non-retryable kinds" do
err = ErrorResponse.from_response(%{status: 404, body: %{}})
assert ErrorResponse.retry_delay_seconds(err) == 30
end
end
describe "retryable?/1" do
test "returns true for rate_limit" do
err = ErrorResponse.from_response(%{status: 429, body: %{}})
assert ErrorResponse.retryable?(err)
end
test "returns true for server_error" do
err = ErrorResponse.from_response(%{status: 503, body: %{}})
assert ErrorResponse.retryable?(err)
end
test "returns true for timeout" do
err = %ErrorResponse{status: nil, message: nil, kind: :timeout, body: nil}
assert ErrorResponse.retryable?(err)
end
test "returns false for not_found" do
err = ErrorResponse.from_response(%{status: 404, body: %{}})
refute ErrorResponse.retryable?(err)
end
test "returns false for auth_error" do
err = ErrorResponse.from_response(%{status: 401, body: %{}})
refute ErrorResponse.retryable?(err)
end
end
describe "get_artist/1" do
test "returns the artist" do
discogs_id = "discogs_id"