From f21729ac0092be34aa10150c14c56eb6a37211ed Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Fri, 31 Jan 2025 07:42:43 +0000 Subject: [PATCH] Cache covers for 1 year --- lib/music_library_web/controllers/cover_controller.ex | 4 ++-- .../controllers/cover_controller_test.exs | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/music_library_web/controllers/cover_controller.ex b/lib/music_library_web/controllers/cover_controller.ex index 8136f200..58f1a5ab 100644 --- a/lib/music_library_web/controllers/cover_controller.ex +++ b/lib/music_library_web/controllers/cover_controller.ex @@ -4,8 +4,8 @@ defmodule MusicLibraryWeb.CoverController do alias MusicLibrary.Records alias MusicLibrary.Records.Cover - # 24 hours in seconds - @cache_duration 60 * 60 * 24 + # 1 year in seconds + @cache_duration 60 * 60 * 24 * 365 def show(conn, %{"record_id" => record_id, "size" => size}) do case Records.get_cover(record_id) do diff --git a/test/music_library_web/controllers/cover_controller_test.exs b/test/music_library_web/controllers/cover_controller_test.exs index 1d9dcd33..5380eae9 100644 --- a/test/music_library_web/controllers/cover_controller_test.exs +++ b/test/music_library_web/controllers/cover_controller_test.exs @@ -23,7 +23,7 @@ defmodule MusicLibraryWeb.CoverControllerTest do assert conn.status == 200 assert get_resp_header(conn, "content-type") == ["image/jpeg; charset=utf-8"] - assert get_resp_header(conn, "cache-control") == ["public, max-age=86400"] + assert get_resp_header(conn, "cache-control") == ["public, max-age=31536000"] assert get_resp_header(conn, "etag") == [record.cover_hash] assert conn.resp_body == record.cover_data @@ -37,7 +37,7 @@ defmodule MusicLibraryWeb.CoverControllerTest do assert conn.status == 200 assert get_resp_header(conn, "content-type") == ["image/jpeg; charset=utf-8"] - assert get_resp_header(conn, "cache-control") == ["public, max-age=86400"] + assert get_resp_header(conn, "cache-control") == ["public, max-age=31536000"] assert get_resp_header(conn, "etag") == [record.cover_hash] assert conn.resp_body == record.cover_data @@ -51,7 +51,7 @@ defmodule MusicLibraryWeb.CoverControllerTest do assert conn.status == 304 assert get_resp_header(conn, "content-type") == [] - assert get_resp_header(conn, "cache-control") == ["public, max-age=86400"] + assert get_resp_header(conn, "cache-control") == ["public, max-age=31536000"] assert get_resp_header(conn, "etag") == [] assert conn.resp_body == <<>> @@ -65,7 +65,7 @@ defmodule MusicLibraryWeb.CoverControllerTest do assert conn.status == 200 assert get_resp_header(conn, "content-type") == ["image/jpeg; charset=utf-8"] - assert get_resp_header(conn, "cache-control") == ["public, max-age=86400"] + assert get_resp_header(conn, "cache-control") == ["public, max-age=31536000"] assert get_resp_header(conn, "etag") == [hash] assert conn.resp_body == thumb