From f37719f2725e576e768a5a70329f0f9bd119eb3a Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Mon, 7 Jul 2025 20:14:32 +0100 Subject: [PATCH] Rename ScrobbleRules.Worker to Worker.ApplyScrobbleRules --- config/config.exs | 2 +- .../worker.ex => worker/apply_scrobble_rules.ex} | 2 +- .../apply_scrobble_rules_test.exs} | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) rename lib/music_library/{scrobble_rules/worker.ex => worker/apply_scrobble_rules.ex} (96%) rename test/music_library/{scrobble_rules/worker_test.exs => worker/apply_scrobble_rules_test.exs} (90%) diff --git a/config/config.exs b/config/config.exs index db5c7a3a..cb07176f 100644 --- a/config/config.exs +++ b/config/config.exs @@ -87,7 +87,7 @@ config :music_library, Oban, {Oban.Plugins.Cron, crontab: [ # every 30 minutes - {"*/30 * * * *", MusicLibrary.ScrobbleRules.Worker} + {"*/30 * * * *", MusicLibrary.Worker.ApplyScrobbleRules} ]} ] diff --git a/lib/music_library/scrobble_rules/worker.ex b/lib/music_library/worker/apply_scrobble_rules.ex similarity index 96% rename from lib/music_library/scrobble_rules/worker.ex rename to lib/music_library/worker/apply_scrobble_rules.ex index 43cd0a2e..8e5cb2d3 100644 --- a/lib/music_library/scrobble_rules/worker.ex +++ b/lib/music_library/worker/apply_scrobble_rules.ex @@ -1,4 +1,4 @@ -defmodule MusicLibrary.ScrobbleRules.Worker do +defmodule MusicLibrary.Worker.ApplyScrobbleRules do @moduledoc """ Oban worker that periodically applies all enabled scrobble rules. diff --git a/test/music_library/scrobble_rules/worker_test.exs b/test/music_library/worker/apply_scrobble_rules_test.exs similarity index 90% rename from test/music_library/scrobble_rules/worker_test.exs rename to test/music_library/worker/apply_scrobble_rules_test.exs index 925219dd..c79b64df 100644 --- a/test/music_library/scrobble_rules/worker_test.exs +++ b/test/music_library/worker/apply_scrobble_rules_test.exs @@ -1,9 +1,9 @@ -defmodule MusicLibrary.ScrobbleRules.WorkerTest do +defmodule MusicLibrary.Worker.ApplyScrobbleRulesTest do use MusicLibrary.DataCase alias LastFm.Track alias MusicLibrary.ScrobbleRules - alias MusicLibrary.ScrobbleRules.Worker + alias MusicLibrary.Worker.ApplyScrobbleRules describe "perform/1" do test "successfully applies all enabled rules" do @@ -61,7 +61,7 @@ defmodule MusicLibrary.ScrobbleRules.WorkerTest do |> Repo.insert!() # Execute the worker - assert :ok = Worker.perform(%Oban.Job{args: %{}}) + assert :ok = ApplyScrobbleRules.perform(%Oban.Job{args: %{}}) # Verify rules were applied updated_track1 = Repo.get_by(Track, musicbrainz_id: "track-mbid-1") @@ -78,12 +78,12 @@ defmodule MusicLibrary.ScrobbleRules.WorkerTest do test "handles errors gracefully" do # Since we can't easily mock here, let's test with no rules # which should still return :ok - assert :ok = Worker.perform(%Oban.Job{args: %{}}) + assert :ok = ApplyScrobbleRules.perform(%Oban.Job{args: %{}}) end test "handles empty rules list" do # No rules exist - assert :ok = Worker.perform(%Oban.Job{args: %{}}) + assert :ok = ApplyScrobbleRules.perform(%Oban.Job{args: %{}}) end end end