From f6d1d3431af69b2e2a5f0f6007f6dd6ba5ba50c6 Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Mon, 14 Apr 2025 17:41:33 +0100 Subject: [PATCH] Improve meta and error handling for background cover refreshing --- lib/music_library/records.ex | 9 ++++++--- lib/music_library/worker/refresh_cover.ex | 9 +++++---- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/lib/music_library/records.ex b/lib/music_library/records.ex index e6fd4684..f1d3cb0c 100644 --- a/lib/music_library/records.ex +++ b/lib/music_library/records.ex @@ -200,9 +200,12 @@ defmodule MusicLibrary.Records do end end - def refresh_cover_async(record_id) do - %{"id" => record_id} - |> Worker.RefreshCover.new() + def refresh_cover_async(record) do + meta = %{title: record.title, artists: Enum.map(record.artists, & &1.name)} + params = %{"id" => record.id} + + params + |> Worker.RefreshCover.new(meta: meta) |> BackgroundRepo.insert() end diff --git a/lib/music_library/worker/refresh_cover.ex b/lib/music_library/worker/refresh_cover.ex index a803e2e5..14f0f146 100644 --- a/lib/music_library/worker/refresh_cover.ex +++ b/lib/music_library/worker/refresh_cover.ex @@ -1,11 +1,12 @@ defmodule MusicLibrary.Worker.RefreshCover do - use Oban.Worker, queue: :default + use Oban.Worker, queue: :default, max_attempts: 3 @impl Oban.Worker def perform(%Oban.Job{args: %{"id" => record_id}}) do record = MusicLibrary.Records.get_record!(record_id) - {:ok, new_record} = MusicLibrary.Records.refresh_cover(record) - MusicLibrary.Records.notify_update(new_record) - :ok + + with {:ok, updated_record} <- MusicLibrary.Records.refresh_cover(record) do + MusicLibrary.Records.notify_update(updated_record) + end end end