Enable unaliased modules ex_slop check

test/music_library_web/live/artist_live/show_test.exs

@@ -8,6 +8,7 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
   alias MusicLibrary.Artists
   alias MusicLibrary.Assets
   alias MusicLibrary.Assets.Asset
+  alias Req.Test
 
   defp fill_collection(_config) do
     collection_record =
@@ -34,13 +35,13 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       conn: conn,
       artist_musicbrainz_id: artist_musicbrainz_id
     } do
-      Req.Test.stub(LastFm.API, fn conn ->
+      Test.stub(LastFm.API, fn conn ->
         case Map.get(conn.params, "method") do
           "artist.getInfo" ->
-            Req.Test.json(conn, Fixtures.Artist.get_info())
+            Test.json(conn, Fixtures.Artist.get_info())
 
           "artist.getSimilar" ->
-            Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+            Test.json(conn, Fixtures.Artist.get_similar_artists())
         end
       end)
 
@@ -60,13 +61,13 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       |> Ecto.Changeset.change(wikipedia_data: Wikipedia.Fixtures.article_summary())
       |> MusicLibrary.Repo.update!()
 
-      Req.Test.stub(LastFm.API, fn conn ->
+      Test.stub(LastFm.API, fn conn ->
         case Map.get(conn.params, "method") do
           "artist.getInfo" ->
-            Req.Test.json(conn, Fixtures.Artist.get_info())
+            Test.json(conn, Fixtures.Artist.get_info())
 
           "artist.getSimilar" ->
-            Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+            Test.json(conn, Fixtures.Artist.get_similar_artists())
         end
       end)
 
@@ -82,13 +83,13 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       conn: conn,
       artist_musicbrainz_id: artist_musicbrainz_id
     } do
-      Req.Test.stub(LastFm.API, fn conn ->
+      Test.stub(LastFm.API, fn conn ->
         case Map.get(conn.params, "method") do
           "artist.getInfo" ->
-            Req.Test.transport_error(conn, :timeout)
+            Test.transport_error(conn, :timeout)
 
           "artist.getSimilar" ->
-            Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+            Test.json(conn, Fixtures.Artist.get_similar_artists())
         end
       end)
 
@@ -104,13 +105,13 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       conn: conn,
       artist_musicbrainz_id: artist_musicbrainz_id
     } do
-      Req.Test.stub(LastFm.API, fn conn ->
+      Test.stub(LastFm.API, fn conn ->
         case Map.get(conn.params, "method") do
           "artist.getInfo" ->
-            Req.Test.json(conn, Fixtures.Artist.get_info())
+            Test.json(conn, Fixtures.Artist.get_info())
 
           "artist.getSimilar" ->
-            Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+            Test.json(conn, Fixtures.Artist.get_similar_artists())
         end
       end)
 
@@ -136,13 +137,13 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       other_collection_record =
         record_with_artist("Porcupine Tree", %{purchased_at: DateTime.utc_now()})
 
-      Req.Test.stub(LastFm.API, fn conn ->
+      Test.stub(LastFm.API, fn conn ->
         case Map.get(conn.params, "method") do
           "artist.getInfo" ->
-            Req.Test.json(conn, Fixtures.Artist.get_info())
+            Test.json(conn, Fixtures.Artist.get_info())
 
           "artist.getSimilar" ->
-            Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+            Test.json(conn, Fixtures.Artist.get_similar_artists())
         end
       end)
 
@@ -175,9 +176,9 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       conn: conn,
       artist_musicbrainz_id: musicbrainz_id
     } do
-      Req.Test.stub(BraveSearch.API, fn conn ->
+      Test.stub(BraveSearch.API, fn conn ->
         assert conn.request_path == "/res/v1/images/search"
-        Req.Test.json(conn, BraveSearch.Fixtures.search_images_response())
+        Test.json(conn, BraveSearch.Fixtures.search_images_response())
       end)
 
       {:ok, view, _html} = live(conn, ~p"/artists/#{musicbrainz_id}/edit")
@@ -196,8 +197,8 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
       conn: conn,
       artist_musicbrainz_id: musicbrainz_id
     } do
-      Req.Test.stub(BraveSearch.API, fn conn ->
-        Req.Test.transport_error(conn, :timeout)
+      Test.stub(BraveSearch.API, fn conn ->
+        Test.transport_error(conn, :timeout)
       end)
 
       {:ok, view, _html} = live(conn, ~p"/artists/#{musicbrainz_id}/edit")
@@ -243,10 +244,10 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
     } do
       raven_binary = raven_cover_data()
 
-      Req.Test.stub(BraveSearch.API, fn conn ->
+      Test.stub(BraveSearch.API, fn conn ->
         case conn.request_path do
           "/res/v1/images/search" ->
-            Req.Test.json(conn, BraveSearch.Fixtures.search_images_response())
+            Test.json(conn, BraveSearch.Fixtures.search_images_response())
 
           _ ->
             Plug.Conn.send_resp(conn, 200, raven_binary)
@@ -275,13 +276,13 @@ defmodule MusicLibraryWeb.ArtistLive.ShowTest do
   end
 
   defp stub_last_fm(_config) do
-    Req.Test.stub(LastFm.API, fn conn ->
+    Test.stub(LastFm.API, fn conn ->
       case Map.get(conn.params, "method") do
         "artist.getInfo" ->
-          Req.Test.json(conn, Fixtures.Artist.get_info())
+          Test.json(conn, Fixtures.Artist.get_info())
 
         "artist.getSimilar" ->
-          Req.Test.json(conn, Fixtures.Artist.get_similar_artists())
+          Test.json(conn, Fixtures.Artist.get_similar_artists())
       end
     end)
 

test/music_library_web/live/collection_live/index_test.exs

@@ -12,6 +12,7 @@ defmodule MusicLibraryWeb.CollectionLive.IndexTest do
   alias MusicLibrary.Assets.{Image, Transform}
   alias MusicLibrary.Records.Record
   alias MusicLibrary.Worker.ImportFromMusicbrainzReleaseGroup
+  alias Req.Test
 
   # make it a multiple of 4 for easier calculations
   @default_records_page_size 4
@@ -274,8 +275,8 @@ defmodule MusicLibraryWeb.CollectionLive.IndexTest do
     end
 
     test "pre-fills the search query from import_query param", %{conn: conn} do
-      Req.Test.stub(MusicBrainz.API, fn conn ->
-        Req.Test.json(conn, %{"release-groups" => [], "count" => 0})
+      Test.stub(MusicBrainz.API, fn conn ->
+        Test.json(conn, %{"release-groups" => [], "count" => 0})
       end)
 
       conn
@@ -495,10 +496,10 @@ defmodule MusicLibraryWeb.CollectionLive.IndexTest do
   end
 
   defp stub_release_group_search do
-    Req.Test.stub(MusicBrainz.API, fn conn ->
+    Test.stub(MusicBrainz.API, fn conn ->
       case conn.path_info do
         [_ws, _version, "release-group"] ->
-          Req.Test.json(conn, release_group_search_results())
+          Test.json(conn, release_group_search_results())
       end
     end)
   end
@@ -511,16 +512,16 @@ defmodule MusicLibraryWeb.CollectionLive.IndexTest do
     release_group_releases = release_group_releases(:marbles)
     cover_data = marbles_cover_data()
 
-    Req.Test.stub(MusicBrainz.API, fn conn ->
+    Test.stub(MusicBrainz.API, fn conn ->
       case conn.path_info do
         [_ws, _version, "release-group", ^first_id] ->
-          Req.Test.json(conn, release_group)
+          Test.json(conn, release_group)
 
         [_ws, _version, "release-group"] ->
-          Req.Test.json(conn, release_group_search_results())
+          Test.json(conn, release_group_search_results())
 
         [_ws, _version, "release"] ->
-          Req.Test.json(conn, release_group_releases)
+          Test.json(conn, release_group_releases)
 
         [_release_group, ^first_id, "front"] ->
           Plug.Conn.send_resp(conn, 200, cover_data)
@@ -560,21 +561,21 @@ defmodule MusicLibraryWeb.CollectionLive.IndexTest do
 
       cover_data = marbles_cover_data()
 
-      Req.Test.stub(MusicBrainz.API, fn conn ->
+      Test.stub(MusicBrainz.API, fn conn ->
         case conn.path_info do
           [_ws, _version, "release-group", ^release_group_id] ->
-            Req.Test.json(conn, release_group)
+            Test.json(conn, release_group)
 
           [_ws, _version, "release", ^release_id] ->
-            Req.Test.json(conn, release)
+            Test.json(conn, release)
 
           [_ws, _version, "release"] ->
             if conn.params["query"] do
               # barcode scan
-              Req.Test.json(conn, releases)
+              Test.json(conn, releases)
             else
               # Search by release group ID
-              Req.Test.json(conn, release_group_releases)
+              Test.json(conn, release_group_releases)
             end
 
           [_release_group, ^release_group_id, "front"] ->

test/music_library_web/live/scrobble_live/index_test.exs

@@ -4,18 +4,19 @@ defmodule MusicLibraryWeb.ScrobbleLive.IndexTest do
   import Phoenix.LiveViewTest, only: [render: 1, render_submit: 1, render_click: 3, form: 3]
 
   alias MusicBrainz.Fixtures.ReleaseGroup
+  alias Req.Test
 
   defp stub_search_results(_) do
-    Req.Test.stub(MusicBrainz.API, fn conn ->
+    Test.stub(MusicBrainz.API, fn conn ->
       case conn.request_path do
         "/ws/2/release-group" ->
-          Req.Test.json(conn, ReleaseGroup.release_group_search_results())
+          Test.json(conn, ReleaseGroup.release_group_search_results())
 
         "/ws/2/release" ->
-          Req.Test.json(conn, ReleaseGroup.release_group_releases(:marbles))
+          Test.json(conn, ReleaseGroup.release_group_releases(:marbles))
 
         _ ->
-          Req.Test.json(conn, %{})
+          Test.json(conn, %{})
       end
     end)
 
@@ -23,13 +24,13 @@ defmodule MusicLibraryWeb.ScrobbleLive.IndexTest do
   end
 
   defp stub_empty_search_results(_) do
-    Req.Test.stub(MusicBrainz.API, fn conn ->
+    Test.stub(MusicBrainz.API, fn conn ->
       case conn.request_path do
         "/ws/2/release-group" ->
-          Req.Test.json(conn, %{"count" => 0, "release-groups" => []})
+          Test.json(conn, %{"count" => 0, "release-groups" => []})
 
         _ ->
-          Req.Test.json(conn, %{})
+          Test.json(conn, %{})
       end
     end)
 

test/music_library_web/live/scrobble_live/show_test.exs

@@ -5,17 +5,18 @@ defmodule MusicLibraryWeb.ScrobbleLive.ShowTest do
 
   alias MusicBrainz.Fixtures.Release, as: ReleaseFixtures
   alias MusicLibrary.Secrets
+  alias Req.Test
 
   @release_id ReleaseFixtures.release_id(:marbles)
 
   defp stub_musicbrainz_release(_) do
-    Req.Test.stub(MusicBrainz.API, fn conn ->
+    Test.stub(MusicBrainz.API, fn conn ->
       case conn.request_path do
         "/ws/2/release/" <> _id ->
-          Req.Test.json(conn, ReleaseFixtures.release_with_media(:marbles))
+          Test.json(conn, ReleaseFixtures.release_with_media(:marbles))
 
         _ ->
-          Req.Test.json(conn, %{})
+          Test.json(conn, %{})
       end
     end)
 
@@ -23,7 +24,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.ShowTest do
   end
 
   defp stub_musicbrainz_release_error(_) do
-    Req.Test.stub(MusicBrainz.API, fn conn ->
+    Test.stub(MusicBrainz.API, fn conn ->
       Plug.Conn.send_resp(conn, 404, "Not Found")
     end)
 
@@ -31,16 +32,16 @@ defmodule MusicLibraryWeb.ScrobbleLive.ShowTest do
   end
 
   defp stub_lastfm_scrobble(_) do
-    Req.Test.stub(LastFm.API, fn conn ->
-      Req.Test.json(conn, %{"scrobbles" => %{"@attr" => %{"accepted" => 1}}})
+    Test.stub(LastFm.API, fn conn ->
+      Test.json(conn, %{"scrobbles" => %{"@attr" => %{"accepted" => 1}}})
     end)
 
     :ok
   end
 
   defp stub_lastfm_scrobble_error(_) do
-    Req.Test.stub(LastFm.API, fn conn ->
-      Req.Test.json(conn, %{"error" => 11, "message" => "Service temporarily unavailable"})
+    Test.stub(LastFm.API, fn conn ->
+      Test.json(conn, %{"error" => 11, "message" => "Service temporarily unavailable"})
     end)
 
     :ok

test/music_library_web/live/wishlist_live/index_test.exs

@@ -9,6 +9,7 @@ defmodule MusicLibraryWeb.WishlistLive.IndexTest do
 
   alias MusicLibrary.Records.Record
   alias MusicLibrary.Worker.ImportFromMusicbrainzReleaseGroup
+  alias Req.Test
 
   defp fill_wishlist(_) do
     records = Enum.map(1..5, fn _ -> record(%{purchased_at: nil}) end)
@@ -110,10 +111,10 @@ defmodule MusicLibraryWeb.WishlistLive.IndexTest do
   end
 
   defp stub_release_group_search do
-    Req.Test.stub(MusicBrainz.API, fn conn ->
+    Test.stub(MusicBrainz.API, fn conn ->
       case conn.path_info do
         [_ws, _version, "release-group"] ->
-          Req.Test.json(conn, release_group_search_results())
+          Test.json(conn, release_group_search_results())
       end
     end)
   end
@@ -126,16 +127,16 @@ defmodule MusicLibraryWeb.WishlistLive.IndexTest do
     release_group_releases = release_group_releases(:marbles)
     cover_data = marbles_cover_data()
 
-    Req.Test.stub(MusicBrainz.API, fn conn ->
+    Test.stub(MusicBrainz.API, fn conn ->
       case conn.path_info do
         [_ws, _version, "release-group", ^first_id] ->
-          Req.Test.json(conn, release_group)
+          Test.json(conn, release_group)
 
         [_ws, _version, "release-group"] ->
-          Req.Test.json(conn, release_group_search_results())
+          Test.json(conn, release_group_search_results())
 
         [_ws, _version, "release"] ->
-          Req.Test.json(conn, release_group_releases)
+          Test.json(conn, release_group_releases)
 
         [_release_group, ^first_id, "front"] ->
           Plug.Conn.send_resp(conn, 200, cover_data)