Enable unaliased modules ex_slop check

This commit is contained in:
Claudio Ortolina
2026-04-22 20:36:13 +01:00
parent 5c1beede53
commit f7f38d580e
26 changed files with 226 additions and 193 deletions
@@ -4,18 +4,19 @@ defmodule MusicLibraryWeb.ScrobbleLive.IndexTest do
import Phoenix.LiveViewTest, only: [render: 1, render_submit: 1, render_click: 3, form: 3]
alias MusicBrainz.Fixtures.ReleaseGroup
alias Req.Test
defp stub_search_results(_) do
Req.Test.stub(MusicBrainz.API, fn conn ->
Test.stub(MusicBrainz.API, fn conn ->
case conn.request_path do
"/ws/2/release-group" ->
Req.Test.json(conn, ReleaseGroup.release_group_search_results())
Test.json(conn, ReleaseGroup.release_group_search_results())
"/ws/2/release" ->
Req.Test.json(conn, ReleaseGroup.release_group_releases(:marbles))
Test.json(conn, ReleaseGroup.release_group_releases(:marbles))
_ ->
Req.Test.json(conn, %{})
Test.json(conn, %{})
end
end)
@@ -23,13 +24,13 @@ defmodule MusicLibraryWeb.ScrobbleLive.IndexTest do
end
defp stub_empty_search_results(_) do
Req.Test.stub(MusicBrainz.API, fn conn ->
Test.stub(MusicBrainz.API, fn conn ->
case conn.request_path do
"/ws/2/release-group" ->
Req.Test.json(conn, %{"count" => 0, "release-groups" => []})
Test.json(conn, %{"count" => 0, "release-groups" => []})
_ ->
Req.Test.json(conn, %{})
Test.json(conn, %{})
end
end)
@@ -5,17 +5,18 @@ defmodule MusicLibraryWeb.ScrobbleLive.ShowTest do
alias MusicBrainz.Fixtures.Release, as: ReleaseFixtures
alias MusicLibrary.Secrets
alias Req.Test
@release_id ReleaseFixtures.release_id(:marbles)
defp stub_musicbrainz_release(_) do
Req.Test.stub(MusicBrainz.API, fn conn ->
Test.stub(MusicBrainz.API, fn conn ->
case conn.request_path do
"/ws/2/release/" <> _id ->
Req.Test.json(conn, ReleaseFixtures.release_with_media(:marbles))
Test.json(conn, ReleaseFixtures.release_with_media(:marbles))
_ ->
Req.Test.json(conn, %{})
Test.json(conn, %{})
end
end)
@@ -23,7 +24,7 @@ defmodule MusicLibraryWeb.ScrobbleLive.ShowTest do
end
defp stub_musicbrainz_release_error(_) do
Req.Test.stub(MusicBrainz.API, fn conn ->
Test.stub(MusicBrainz.API, fn conn ->
Plug.Conn.send_resp(conn, 404, "Not Found")
end)
@@ -31,16 +32,16 @@ defmodule MusicLibraryWeb.ScrobbleLive.ShowTest do
end
defp stub_lastfm_scrobble(_) do
Req.Test.stub(LastFm.API, fn conn ->
Req.Test.json(conn, %{"scrobbles" => %{"@attr" => %{"accepted" => 1}}})
Test.stub(LastFm.API, fn conn ->
Test.json(conn, %{"scrobbles" => %{"@attr" => %{"accepted" => 1}}})
end)
:ok
end
defp stub_lastfm_scrobble_error(_) do
Req.Test.stub(LastFm.API, fn conn ->
Req.Test.json(conn, %{"error" => 11, "message" => "Service temporarily unavailable"})
Test.stub(LastFm.API, fn conn ->
Test.json(conn, %{"error" => 11, "message" => "Service temporarily unavailable"})
end)
:ok